Message ID | 20230624082054.37697-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp6271107vqr; Sat, 24 Jun 2023 01:24:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6lVAY6+MpK4pEiei0KpwIFNVXl4HcHS1UtrJuH0Qaq25cjUgxJ6fw74lV/i0PyVoA3qlFk X-Received: by 2002:a17:90a:2d8f:b0:255:2dde:17cc with SMTP id p15-20020a17090a2d8f00b002552dde17ccmr22808808pjd.47.1687595070667; Sat, 24 Jun 2023 01:24:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687595070; cv=none; d=google.com; s=arc-20160816; b=SokFo0sRBs/fA7RGFUXsINrAos8Vl+UB4rxxqhfqX9kxmLCn6Qr5WrN21cZTGPeJ21 WpPhqCh8k9AHWr16SgYGsrCCgMz3kKPmXsYzYFRafo+Y2bO1RhwvGAqiGcDLVKMq5l0g 6mgMZNdHEMcAha4YseC5fX27k5ZCMDP0PzUVqhd9CctU9G2KEWippAh3xNQs0jLPgDNC Co93XN78CDXbDBYe4jUzmu+RriJTvle0R4Qo1E2Xe5xGolmSDA9Z0LV+6l+dC2Z2EWEU 6MmR/w6z9WXXeyvnRkZMLfxz5dwrEpLLpcGOJFs0dMlGj06rUqhW5ZFxwHwnbKATgIs9 dGSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=KXFy1y+GxEpWoS2XA5y1VOww+5x8Ww/esZIImWKElzw=; fh=U69qBMcaH6rHJjOF9js5aGFjbyfwvV85pEhH/BSyMZk=; b=vWf3B7iBQL9NnyRiR8oM916PheCL9CedKRGDdSYZGTzV2qKzmr1Ztp8wduYlASmZYK mufBkWsr1I8zq8PoKHF0yIqhUHBuvtLldaHlYmvKWMESZ25P/a8FKBCRXocSnRz2Rmp9 fDL7txmnY3Fn3DEqoG4Cke26c917jzl6L+xJAUjFDBXC7rQkYUn9vXNpXy0bKKxvO2QE 0s0ZMuVyM1D/q0XRF8iC8H04qrki0iehP2qw9syXTKe+p2GETJbE/jCjOgUZ/opSn0Fa JGLjIKcmPd3VuY7qkqm8JRwlAU5ofyfPMmfUGq5nl5qyF3km2gvCxvTcblzfhWE7cXrv sUpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KZWyreTm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w6-20020a17090a460600b0025c16614fa6si3385206pjg.145.2023.06.24.01.24.17; Sat, 24 Jun 2023 01:24:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KZWyreTm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229667AbjFXIVK (ORCPT <rfc822;maxin.john@gmail.com> + 99 others); Sat, 24 Jun 2023 04:21:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229586AbjFXIVG (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 24 Jun 2023 04:21:06 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D767B18F for <linux-kernel@vger.kernel.org>; Sat, 24 Jun 2023 01:21:04 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-988883b0d8fso181573066b.1 for <linux-kernel@vger.kernel.org>; Sat, 24 Jun 2023 01:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687594863; x=1690186863; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KXFy1y+GxEpWoS2XA5y1VOww+5x8Ww/esZIImWKElzw=; b=KZWyreTmC1qMsLkMg9b2+Z1ASl0sWM0ljIY3qKhqRnYi15DikQw0zG5fCfGcZTwc/o vTzzxN3uKQl57M38sqb0Imep8NumWIGU5bCDlvQ7U3++vbVDzH5i7skKyMxcO4nsyqE8 CZq+qxCEmHxaWuFo+ld4MhAac2VFr0IuReGEWIMrFEWGwkdFGLKnO4KdYixVxCeIgd0L qHBZxYYlOcj2ncXonY6MEUOOXFHxXDxXsxQ9D9jyeGJn+2snhLATis6Lz/wvXtEVYPyF NkQCjak6+ErMoQVHuhBCoHxeFj1cXvqOLzUViXv44ZG2ekGONNF7Gj/PmvABD94TlCjT Yzrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687594863; x=1690186863; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KXFy1y+GxEpWoS2XA5y1VOww+5x8Ww/esZIImWKElzw=; b=V+YGrqIIsmCTt83J2D/163iZdNLi1Modvj5/oLTwDSqoRL3UM5v+dGkEBFUhOYqDMv yjyYkNmwpmCgomGWOFQWFOuVdwFGXx7V0KPpw+A44fAjOdRoUi/q3v0bhAmDbmCciDEI yTtesGwIve18r4tCe1Z0twJmWhMYtd0calyMjvFkg4nYXamG/uXOpxbEsXhP036U7+tJ UOQ0GJn0udc1lyeJ+fXDgJWm21fbmXeJK9QQhe1DBmzQGIRxwwO69Nk2j1nLokgXX1NU G1AuubkyLjE1nGzD+d/GbGCUizYR6f6pK6/ybYlAN/1kRl+EkUklK7PBfUgSVAeGUXgj A/Gg== X-Gm-Message-State: AC+VfDynQeX6HW/8tF0K0AqqIeUlycqx9j668tMFqxJd8sXGXccID9yb jxEwq3+72Vc25Q80t9DmoSKDFg== X-Received: by 2002:a17:907:70d:b0:979:65f0:cced with SMTP id xb13-20020a170907070d00b0097965f0ccedmr18872642ejb.17.1687594863305; Sat, 24 Jun 2023 01:21:03 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id bm4-20020a170906c04400b00973ca837a68sm602287ejb.217.2023.06.24.01.21.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jun 2023 01:21:02 -0700 (PDT) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Claudiu Beznea <claudiu.beznea@microchip.com>, Tudor Ambarus <tudor.ambarus@linaro.org>, Varshini Rajendran <varshini.rajendran@microchip.com>, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH] spi: dt-bindings: atmel,at91rm9200-spi: fix broken sam9x7 compatible Date: Sat, 24 Jun 2023 10:20:54 +0200 Message-Id: <20230624082054.37697-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769571688619558740?= X-GMAIL-MSGID: =?utf-8?q?1769571688619558740?= |
Series |
spi: dt-bindings: atmel,at91rm9200-spi: fix broken sam9x7 compatible
|
|
Commit Message
Krzysztof Kozlowski
June 24, 2023, 8:20 a.m. UTC
Commit a3eb95484f27 ("spi: dt-bindings: atmel,at91rm9200-spi: add sam9x7
compatible") adding sam9x7 compatible did not make any sense as it added
new compatible into middle of existing compatible list. The intention
was probably to add new set of compatibles with sam9x7 as first one.
Fixes: a3eb95484f27 ("spi: dt-bindings: atmel,at91rm9200-spi: add sam9x7 compatible")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 3 +++
1 file changed, 3 insertions(+)
Comments
On Sat, Jun 24, 2023 at 10:20:54AM +0200, Krzysztof Kozlowski wrote: > Commit a3eb95484f27 ("spi: dt-bindings: atmel,at91rm9200-spi: add sam9x7 > compatible") adding sam9x7 compatible did not make any sense as it added > new compatible into middle of existing compatible list. The intention > was probably to add new set of compatibles with sam9x7 as first one. > > Fixes: a3eb95484f27 ("spi: dt-bindings: atmel,at91rm9200-spi: add sam9x7 compatible") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> @Varshini, this is the template to follow for the rest of the series. I know there's a lot of complaints while running dtbs_check for the entire directory, but you can isolate things to a singular binding and check the dts against it using: make dtbs_check DT_SCHEMA_FILES=atmel,at91rm9200-spi.yaml That should make it easier to see that you don't break existing dts by modifying the binding. Cheers, Conor. > --- > .../devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml > index bdc42eeacba4..58367587bfbc 100644 > --- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml > +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml > @@ -19,7 +19,10 @@ properties: > - const: atmel,at91rm9200-spi > - items: > - const: microchip,sam9x60-spi > + - const: atmel,at91rm9200-spi > + - items: > - const: microchip,sam9x7-spi > + - const: microchip,sam9x60-spi > - const: atmel,at91rm9200-spi > > reg: > -- > 2.34.1 >
On Sat, 24 Jun 2023 10:20:54 +0200, Krzysztof Kozlowski wrote: > Commit a3eb95484f27 ("spi: dt-bindings: atmel,at91rm9200-spi: add sam9x7 > compatible") adding sam9x7 compatible did not make any sense as it added > new compatible into middle of existing compatible list. The intention > was probably to add new set of compatibles with sam9x7 as first one. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: dt-bindings: atmel,at91rm9200-spi: fix broken sam9x7 compatible commit: e884a133340a470070b2c59833c9ff87aa6517ba All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml index bdc42eeacba4..58367587bfbc 100644 --- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml @@ -19,7 +19,10 @@ properties: - const: atmel,at91rm9200-spi - items: - const: microchip,sam9x60-spi + - const: atmel,at91rm9200-spi + - items: - const: microchip,sam9x7-spi + - const: microchip,sam9x60-spi - const: atmel,at91rm9200-spi reg: