From patchwork Fri Jun 23 15:22:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 112228 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5881288vqr; Fri, 23 Jun 2023 09:06:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4g+PAxDNDnpi9IpP7EowLzBKoJVFVvSDsWBuoiQzAHwSVC6rQeKmkzQDvY86XUE5ifyJUL X-Received: by 2002:a05:6a00:1912:b0:668:753a:b150 with SMTP id y18-20020a056a00191200b00668753ab150mr13761091pfi.21.1687536368781; Fri, 23 Jun 2023 09:06:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687536368; cv=none; d=google.com; s=arc-20160816; b=VXKvtffGNOmeR7EqrtghS3us7bHEtzHzJzNBcpDQqPJkbdjfK7z3rO+uuKsL+R7zII 4MLdSePdGA5HigDQuwHMqYdxwjKQRVKM3a40TFurofiBz6mxz8AWD2DtfEYY4l0sEBzH gVJpdPJkht20eIOcsINt+fuxyVg93ZfxZek359PhhcL4LQ3AK06sKMiEkfwxkrJ4O5J9 qJDbkusTvgIXf3ezRGi78gCyhOHrdhLEwPwYxMIUqhcVjYouOIsOChF6dDYhEjFZBBys GvJx+r58HM35DnM3hts0bvF9b1jZy4caawqJuXlEqDAltBMkttXbeSM7lXKBCk7cX8Nn orRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=mwuYxpnGCF4rpIdDDcXhM2oC5nZg5ew8ppfHM/JGk6k=; b=phaGF7vit131DeJxKNZeyNKcHAQbwzmh8CSmMUPJQDanjplhaqgmBuEO1Cdf1ktUed 29tN8opZCBWOo0yMXLQKImnProTDrhHWe3itWEflGX9maBjAZnvVGCY9obi2vIcOfro5 czIhC5+5tZSjWtEevzunFoxcWtc5ULm3wCIRQHDduAOeWbYK8aXoWXk2dMxPqkkIRQyi c6bv/o1EKOuvD6B5LvliBoOvVGFUazJbnCNugUMPPSaeIKJgWPwgzdPWQ7+pNPva1Yvk ZPTctZg1/f7kDWkVd57JfTA9Aqkshs2kpgVtatvvzCXK3SCuP5lAaH72HkR27cCE/P3C NCyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=g5i0UUMm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p6-20020a625b06000000b00666acab17acsi2469317pfb.318.2023.06.23.09.05.55; Fri, 23 Jun 2023 09:06:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=g5i0UUMm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231998AbjFWPWq (ORCPT + 99 others); Fri, 23 Jun 2023 11:22:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232098AbjFWPWl (ORCPT ); Fri, 23 Jun 2023 11:22:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A71071AC; Fri, 23 Jun 2023 08:22:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A1CB61A94; Fri, 23 Jun 2023 15:22:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C16AFC433C8; Fri, 23 Jun 2023 15:22:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687533758; bh=sRj5H73scWO/9TBS+e2MwEJ4mooOFaJ0HbXk3SIJWAM=; h=From:To:Cc:Subject:Date:From; b=g5i0UUMm4sK9b+44ZtTnyAGB15oqq45T8zvGFnZlw7UWNvTOHaMpxcHU3sk2ieLBj N2j1PBm5Ewl+dSuQsuug7lBu1PAu09qzehGzGN9XQZdsYB1XiIWIYvSffIyxB+UGMe vMb1yWtjb2v+vhns3FARfi/Ppr3o98Oub/GBGkcruBfunUYXqrrr94yEC4eMLKygc2 5cO6fHOSYd9UFuCNlkhf0XtU7ShyaDDKOmp7nn1L/C1oXmA2LEd9ZvtJCAHmfCCu7A 1R+SuuslDJeeWi/XWllcgULrdPzkWnjyN0XUDjjYpRDxAO59Yac3x16Vqh1FMmUp7B yMqjfclwyFQow== From: Arnd Bergmann To: Pavel Machek , Lee Jones , Andy Shevchenko , Henning Schild Cc: Arnd Bergmann , Hans de Goede , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] leds: simatic-ipc-leds-gpio: restore LEDS_CLASS dependency Date: Fri, 23 Jun 2023 17:22:29 +0200 Message-Id: <20230623152233.2246285-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769510135426190869?= X-GMAIL-MSGID: =?utf-8?q?1769510135426190869?= From: Arnd Bergmann A recent rework accidentally lost the dependency on LEDS_CLASS, which leads to a link error when LED support is disbled: x86_64-linux-ld: drivers/leds/simple/simatic-ipc-leds.o: in function `simatic_ipc_leds_probe': simatic-ipc-leds.c:(.text+0x10c): undefined reference to `devm_led_classdev_register_ext' Add back the dependency that was there originally. Fixes: a6c80bec3c935 ("leds: simatic-ipc-leds-gpio: Add GPIO version of Siemens driver") Signed-off-by: Arnd Bergmann --- drivers/leds/simple/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/simple/Kconfig b/drivers/leds/simple/Kconfig index 44fa0f93cb3b3..02443e745ff3b 100644 --- a/drivers/leds/simple/Kconfig +++ b/drivers/leds/simple/Kconfig @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config LEDS_SIEMENS_SIMATIC_IPC tristate "LED driver for Siemens Simatic IPCs" + depends on LEDS_CLASS depends on SIEMENS_SIMATIC_IPC help This option enables support for the LEDs of several Industrial PCs