| Message ID | 20230623143011.7deba53c@canb.auug.org.au |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5524652vqr;
Thu, 22 Jun 2023 21:38:23 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ7bFpawuzKmfsDdNxXHAJ2/yW5M9XOQAVtgJGbNKfavkVdQ/EqVIdiWJl+is2Kc6hRWwLya
X-Received: by 2002:a17:90a:35d:b0:25c:2260:9f5c with SMTP id
29-20020a17090a035d00b0025c22609f5cmr14199648pjf.34.1687495102773;
Thu, 22 Jun 2023 21:38:22 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1687495102; cv=none;
d=google.com; s=arc-20160816;
b=GUQD9jgd24cUWpDDiNEpogA4YC8thBiEmD9UEnG7AoE5a6QBGBXvubpZU/wiv4mw30
K4WORkV08uALdgulJP+5Y9MAf3MhZ7vF9AC1MUbl4B4o+EYweNLlZBktS96fDWSwz6RP
FYf+9CqK4UzYUfSaWTElJ0/bi4ZfFALps9k5WrkTHFPy53HrvhkfyWxFOuzSacyJjrZX
Gpp6V5x6YNl0hI//Y30wnZ5hpW9Vose7TjY/jIZHKEEmvR3pMFs5CgB1EV1Z/zzdHcMU
pjFavr81+tiamEjjzFZRoQPyAWwdzy17P2Y1/4nRcqAKgn2IxoWwrasdhEIeqczNspVV
rngQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:mime-version:message-id:subject:cc:to:from:date
:dkim-signature;
bh=HLzyUWe2JdTNFgsbOVFqKpagFNhTmjAHxqDf7II5T4I=;
fh=BcwjsOZBYmzV2Iqiw00C3T0Ut3cGwP9P8YFWAMrqOMQ=;
b=ZospmvTbRdB3JUx3qg8ykgoG5ZKS68Rj2D0FfED9AiipBkTbMNRPY77Fpq7EgcqAab
1loUZuPYdBN43KIXCHeFMGtWuOcBIVRabVVd4i8m/n0J9kykVtZhcKImw7dq9QRaOdCi
tt+2N76ZVpP0u6/tkprLTpz3tDMyOSK927OTxO+RZhJvdkLISS26q0WMv25nLpk1NaNQ
AWB6DoLeU7iVr3lo7axO3gkLg0VPSbgpLLKeIXnMmu42UryQX6Toqssl15zPTBfa4H2r
f5fDypQf/L5cOyzYaKVnhF1Z4Zvx8NtY/ERhCxeZeBi5BkTJq3Nsv8hWCAy9tGOUD11m
oZzA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=L57Mqkaw;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
k5-20020a17090a4c8500b002612b8cd1dcsi1056348pjh.162.2023.06.22.21.38.10;
Thu, 22 Jun 2023 21:38:22 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=L57Mqkaw;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230306AbjFWEa0 (ORCPT <rfc822;maxin.john@gmail.com> + 99 others);
Fri, 23 Jun 2023 00:30:26 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44202 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229477AbjFWEaX (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 23 Jun 2023 00:30:23 -0400
Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 592972126;
Thu, 22 Jun 2023 21:30:20 -0700 (PDT)
Received: from authenticated.ozlabs.org (localhost [127.0.0.1])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits)
server-digest SHA256)
(No client certificate requested)
by mail.ozlabs.org (Postfix) with ESMTPSA id 4QnPRZ4hpGz4wj9;
Fri, 23 Jun 2023 14:30:18 +1000 (AEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au;
s=201702; t=1687494619;
bh=HLzyUWe2JdTNFgsbOVFqKpagFNhTmjAHxqDf7II5T4I=;
h=Date:From:To:Cc:Subject:From;
b=L57MqkawvTsztT6t1CeX2hsBVT21KqHEoLXcQDmZeobmJW4S8HX7SPI2QDWIxOCP8
HG1yUlSdC9RPiYCh6mP6tN3xrwEY0mKx0UHDwRmqG6ppqBnp3x2QudOk9SLN7iyTHv
AW7jio0wTwZVX6v3Zxy5UdoM/2+QzxoYp0utlliOaTUgI7dOVMvc/R3CCSmEHyhMar
UIBzWR2W6z9UtmNWfuKBJU2p5WQEKnjD7CwA7I+l8QCrSk1Znbz9QiusWw3jxC3HK9
Yyzwr3F8/vDoGSNvLAIVEBDwMwZV/aAmMIIQ6W7GfgwP2c0LgApcnqsSXRFexVoho3
w8lh1T3gM6Lzg==
Date: Fri, 23 Jun 2023 14:30:11 +1000
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Alasdair G Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>
Cc: Demi Marie Obenour <demi@invisiblethingslab.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the device-mapper tree
Message-ID: <20230623143011.7deba53c@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/LwocnfiZv+HSDnECGx87lz+";
protocol="application/pgp-signature"; micalg=pgp-sha256
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1769466864840194588?=
X-GMAIL-MSGID: =?utf-8?q?1769466864840194588?=
|
| Series |
linux-next: build failure after merge of the device-mapper tree
|
|
Commit Message
Stephen Rothwell
June 23, 2023, 4:30 a.m. UTC
Hi all,
After merging the device-mapper tree, today's linux-next build (i386
defconfig) failed like this:
In file included from include/linux/kernel.h:30,
from arch/x86/include/asm/percpu.h:27,
from arch/x86/include/asm/current.h:10,
from include/linux/sched.h:12,
from include/linux/kthread.h:6,
from drivers/md/dm-core.h:13,
from drivers/md/dm-ioctl.c:9:
drivers/md/dm-ioctl.c: In function 'next_target':
include/linux/kern_levels.h:5:25: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format=]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/printk.h:427:25: note: in definition of macro 'printk_index_wrap'
427 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~
include/linux/printk.h:498:9: note: in expansion of macro 'printk'
498 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~
include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH'
11 | #define KERN_ERR KERN_SOH "3" /* error conditions */
| ^~~~~~~~
include/linux/printk.h:498:16: note: in expansion of macro 'KERN_ERR'
498 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~
include/linux/device-mapper.h:626:25: note: in expansion of macro 'pr_err'
626 | #define DMERR(fmt, ...) pr_err(DM_FMT(fmt), ##__VA_ARGS__)
| ^~~~~~
drivers/md/dm-ioctl.c:1421:17: note: in expansion of macro 'DMERR'
1421 | DMERR("Next dm_target_spec (offset %u) is not %lu-byte aligned",
| ^~~~~
cc1: all warnings being treated as errors
Caused by commit
5df1daff2cc6 ("dm ioctl: Check dm_target_spec is sufficiently aligned")
I have applied the following patch for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 23 Jun 2023 14:24:29 +1000
Subject: [PATCH] fix up for "dm ioctl: Check dm_target_spec is sufficiently aligned"
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/md/dm-ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Jun 23, 2023 at 02:30:11PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the device-mapper tree, today's linux-next build (i386 > defconfig) failed like this: > > In file included from include/linux/kernel.h:30, > from arch/x86/include/asm/percpu.h:27, > from arch/x86/include/asm/current.h:10, > from include/linux/sched.h:12, > from include/linux/kthread.h:6, > from drivers/md/dm-core.h:13, > from drivers/md/dm-ioctl.c:9: > drivers/md/dm-ioctl.c: In function 'next_target': > include/linux/kern_levels.h:5:25: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format=] > 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ > | ^~~~~~ > include/linux/printk.h:427:25: note: in definition of macro 'printk_index_wrap' > 427 | _p_func(_fmt, ##__VA_ARGS__); \ > | ^~~~ > include/linux/printk.h:498:9: note: in expansion of macro 'printk' > 498 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) > | ^~~~~~ > include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH' > 11 | #define KERN_ERR KERN_SOH "3" /* error conditions */ > | ^~~~~~~~ > include/linux/printk.h:498:16: note: in expansion of macro 'KERN_ERR' > 498 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) > | ^~~~~~~~ > include/linux/device-mapper.h:626:25: note: in expansion of macro 'pr_err' > 626 | #define DMERR(fmt, ...) pr_err(DM_FMT(fmt), ##__VA_ARGS__) > | ^~~~~~ > drivers/md/dm-ioctl.c:1421:17: note: in expansion of macro 'DMERR' > 1421 | DMERR("Next dm_target_spec (offset %u) is not %lu-byte aligned", > | ^~~~~ > cc1: all warnings being treated as errors > > Caused by commit > > 5df1daff2cc6 ("dm ioctl: Check dm_target_spec is sufficiently aligned") Ugh, sorry about that. I’m pretty sure the code would actually work okay at runtime since unsigned long and unsigned int are passed the same way, but this is still a bug. > I have applied the following patch for today: > > From: Stephen Rothwell <sfr@canb.auug.org.au> > Date: Fri, 23 Jun 2023 14:24:29 +1000 > Subject: [PATCH] fix up for "dm ioctl: Check dm_target_spec is sufficiently aligned" > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> > --- > drivers/md/dm-ioctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c > index 5f0b641538d8..8b480d7825fe 100644 > --- a/drivers/md/dm-ioctl.c > +++ b/drivers/md/dm-ioctl.c > @@ -1418,7 +1418,7 @@ static int next_target(struct dm_target_spec *last, uint32_t next, const char *e > } > > if (next % __alignof__(struct dm_target_spec)) { > - DMERR("Next dm_target_spec (offset %u) is not %lu-byte aligned", > + DMERR("Next dm_target_spec (offset %u) is not %zu-byte aligned", > next, __alignof__(struct dm_target_spec)); > return -EINVAL; > } > -- > 2.39.2 That fix is correct, thanks!
diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c index 5f0b641538d8..8b480d7825fe 100644 --- a/drivers/md/dm-ioctl.c +++ b/drivers/md/dm-ioctl.c @@ -1418,7 +1418,7 @@ static int next_target(struct dm_target_spec *last, uint32_t next, const char *e } if (next % __alignof__(struct dm_target_spec)) { - DMERR("Next dm_target_spec (offset %u) is not %lu-byte aligned", + DMERR("Next dm_target_spec (offset %u) is not %zu-byte aligned", next, __alignof__(struct dm_target_spec)); return -EINVAL; }