From patchwork Sat Jun 24 12:23:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 112454 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp6377509vqr; Sat, 24 Jun 2023 05:48:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7EzCieenD8Tr8lWTBEiq+mi0UFU5xQ6d1qEzoJ72VnUXMoWhnkMxsiQcNBjO7CsoCgsVmQ X-Received: by 2002:a05:6e02:60c:b0:345:79eb:dffd with SMTP id t12-20020a056e02060c00b0034579ebdffdmr1421974ils.23.1687610922914; Sat, 24 Jun 2023 05:48:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687610922; cv=none; d=google.com; s=arc-20160816; b=XqBNYggAsLEobKL5INT4TBfCTmUqDE0n5BMXVZL1kYiRRd/UQOqWyvtOV8JWEaBzlY KMgmwBLx1MfV8Kk7omOFPR6Vfl62S1z9/JJ9ylXy82voouvDW2rVzbOPhKh9IuGF8ZHb LcNtCuWeJfz7JwmdaYUp4RkkhAbSBz250zgiHG/vwf8uJif6io77YAp4xKTV0AUgPP5U Y4D8J3TVFqUGBZejzrHZ4r+N8JxoAwcgPc6Nk2/YY6Y90g218sv8iS/Rk8yUGUiGf76I svGIlTI4Tokl7MoTO0HtayAbDAH+S8sLtu5AFK6cbk0S418Jt5quDJsn9RjVRs+U2hZj mwTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=SdwUD4ja8kl0C3si3v+OvYMyCtcQIhX5wG+ZPdgw56w=; fh=VsX4z0tyvf0RAheyUx8BwMMyitohmjFBru78Qc382AE=; b=xcvoj9QBADN6+qH2z/z/IEZB0MYW5O7VwN22Bp3HgRjyBP4GNUar0Lsg/UgbpfhlsR +vbO4hD/tjZLuVrMF/SJBH6Y4npKMLnCT+BPeDlZmURLeh6F8KGFozRqHutGqiugEf+f l2/7PnnT43OofZxEyUGAwC+k246x4zzWUTAHv4+eLclVzfOQ3Q7iMKB+mIcV5F7+n4wD au7jVjdkEpsTJt6HKVhMBraZW2pd6ugY7ZPInQyxB3XHYuqa7bcsI9SVo9bH6zskSPnz pD9mIbtkZ1gAVk2EwvnsxB0/nXDjgSmF2UDNlqg31hfLd/GXPX+8WBQ+GizL3qJ8xsD/ EwCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hWJrUE+y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s4-20020a63d044000000b0052c73367c13si1274412pgi.871.2023.06.24.05.48.29; Sat, 24 Jun 2023 05:48:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hWJrUE+y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233176AbjFXMX4 (ORCPT + 99 others); Sat, 24 Jun 2023 08:23:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233153AbjFXMXw (ORCPT ); Sat, 24 Jun 2023 08:23:52 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3461E45 for ; Sat, 24 Jun 2023 05:23:50 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2b47a15ca10so24751091fa.1 for ; Sat, 24 Jun 2023 05:23:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687609429; x=1690201429; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SdwUD4ja8kl0C3si3v+OvYMyCtcQIhX5wG+ZPdgw56w=; b=hWJrUE+yTMBo33EWAQ3Fuij490p7Z6ilnJGULElb6XCef93PXynQsqdx65ZyA9hvMP w+j0Rm3iw7Anuz0b7KQ5oLmrSxm82yiCBW2dPS7ToTeJI/MONb1/+v+owUk5iSuUTy1F erDe/Ii8RS6H+eMWDHfzeWu1RzWmVh80oRQyplQLmXi2QHoCLwLAbxqUwsN26va8QJ+W NfRYg+rmlgHipqH8hXioYWNcI6I0tr9thcD4aYq7aPt0q7MQVR3CHnMEjWrSckPqYegX hEsWpGxbNyr5rKUw61VFdhSEIBrYE55sJuHwiHSUkdcys/fD0OV7ckiWTGxOTOwLOkya ekqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687609429; x=1690201429; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SdwUD4ja8kl0C3si3v+OvYMyCtcQIhX5wG+ZPdgw56w=; b=FnxkYlYgncaIG2ghPLSQ3+vhCOkU55W+atumnkvXKAkSieZeEoJguvmbF0fEtyDCN5 u8Dix2oGw6XE/E5A4Rd4r85q9k+ZZPdi1g2uxj+RGLAVPnlOG92oOkQDmP0S2FM4GnmO j9UXSVX/kVGb032snD4tbog9A5lG9f4MxfEdyK9XE8rOqhfmpie9gfUyPZRcx9JOVEW2 mrhplyGL5WNPHrLvOPj9cV+M6X3liHBlvt2NMljc3TJj+n5tzbIXnQobv3pva1j5f4sB YRU7DOtXWSe/XqxR/6zHjYTyoMKXEdiwOuDQkBvOXUJOOeSWXjJbU1S8eu9bUN8oyB8G Is3Q== X-Gm-Message-State: AC+VfDzIJ3ACeif8CedNCabetMSOLDjRfsCB4Vvwe1esR5Wla6GLYSqz fC5TVqN8KQoEIsPjmdDiznH26w== X-Received: by 2002:a19:5050:0:b0:4f8:598b:e62d with SMTP id z16-20020a195050000000b004f8598be62dmr13826809lfj.56.1687609429133; Sat, 24 Jun 2023 05:23:49 -0700 (PDT) Received: from [192.168.1.101] (abyk197.neoplus.adsl.tpnet.pl. [83.9.30.197]) by smtp.gmail.com with ESMTPSA id s13-20020a19ad4d000000b004f00189e1dcsm260200lfd.117.2023.06.24.05.23.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jun 2023 05:23:48 -0700 (PDT) From: Konrad Dybcio Date: Sat, 24 Jun 2023 14:23:46 +0200 Subject: [PATCH v2 2/3] firmware: qcom_scm: Always return devm_clk_get_optional errors MIME-Version: 1.0 Message-Id: <20230623-topic-scm_cleanup-v2-2-9db8c583138d@linaro.org> References: <20230623-topic-scm_cleanup-v2-0-9db8c583138d@linaro.org> In-Reply-To: <20230623-topic-scm_cleanup-v2-0-9db8c583138d@linaro.org> To: Andy Gross , Bjorn Andersson Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687609426; l=1572; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=LId2EVrQK5HfRRaxbRB0VnCSfdSPSyuZN4O6GtpVCuM=; b=TGAD5/2nSgKWjnQ1tOb5GK/LXL4aWbiquVPfQsfgiWQ9LZowwvQHrOdjJzXUbK3Q9yl5l/+ra qMQ6GwEnkJpDNQdO6nYIpMZmx15RuochA73XruUynPQoYXNWr7DlCmW X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769588310808470759?= X-GMAIL-MSGID: =?utf-8?q?1769588310808470759?= If devm_clk_get_optional throws an error, something is really wrong. It may be a probe deferral, or it may be a problem with the clock provider. Regardless of what it may be, it should definitely not be ignored. Stop doing that. Signed-off-by: Konrad Dybcio --- drivers/firmware/qcom_scm.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 237d05d6208b..b8398002205d 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -1419,22 +1419,16 @@ static int qcom_scm_probe(struct platform_device *pdev) "failed to acquire interconnect path\n"); scm->core_clk = devm_clk_get_optional(&pdev->dev, "core"); - if (IS_ERR(scm->core_clk)) { - if (PTR_ERR(scm->core_clk) == -EPROBE_DEFER) - return PTR_ERR(scm->core_clk); - } + if (IS_ERR(scm->core_clk)) + return PTR_ERR(scm->core_clk); scm->iface_clk = devm_clk_get_optional(&pdev->dev, "iface"); - if (IS_ERR(scm->iface_clk)) { - if (PTR_ERR(scm->iface_clk) == -EPROBE_DEFER) - return PTR_ERR(scm->iface_clk); - } + if (IS_ERR(scm->iface_clk)) + return PTR_ERR(scm->iface_clk); scm->bus_clk = devm_clk_get_optional(&pdev->dev, "bus"); - if (IS_ERR(scm->bus_clk)) { - if (PTR_ERR(scm->bus_clk) == -EPROBE_DEFER) - return PTR_ERR(scm->bus_clk); - } + if (IS_ERR(scm->bus_clk)) + return PTR_ERR(scm->bus_clk); scm->reset.ops = &qcom_scm_pas_reset_ops; scm->reset.nr_resets = 1;