From patchwork Fri Jun 23 21:49:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 112350 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp6071392vqr; Fri, 23 Jun 2023 15:20:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7xYypRg+tz9pmwpU0yfkL+zPmiKAj/8kg45A6INonM6WlBXTsNgl1Zv79nGDMVurWYxDYq X-Received: by 2002:a05:6a00:1914:b0:668:74e9:8eea with SMTP id y20-20020a056a00191400b0066874e98eeamr16602927pfi.33.1687558802375; Fri, 23 Jun 2023 15:20:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687558802; cv=none; d=google.com; s=arc-20160816; b=lkiEevrY1SAsUDYn1pzOMLSf1/RY2xLiP76jvT4HrL8+MbpaXTHsHg6OiEpb25mER1 +mWNWQK0WKGT7NURgShnornVFgBYgnyLVj0El8+eWTKbt0ScTlqzYwsj8lHom3uYpJXn MzLxm2L+WXywPrXF4acsySuiYo651YMyGuq6q3JyZODhCMIBfUne7d5KOZsnHSyffN/G sT0PSTN+vpUV6mdhkeq83W5We/UqaZWp3rOAJl7MhnpdDMloSuT1JDpCef15rOvjF759 1tudYrQKCXONGr6EqTG4HPhMeGGG2UoMOTFJjBVrYyv2rW061DJyNng8JMvE0sHu+79F S1qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=5DBVmcbPM6O4YzyX5TBk3hTNZ7EUrOs7o/4qOremoNA=; fh=VsX4z0tyvf0RAheyUx8BwMMyitohmjFBru78Qc382AE=; b=LY/83BVNaFaionJNKnnNqSejkRx0Ye1SQlOkJfNBxdCQzAaurNInlRt62J44fYKk/f 3+BOiQn6jI3NUeBUkj9CgYIM65Hk25F9newkkXn/zDW6Cy8Zh8upk85P6gQON57Ccof0 GhcsQkj/g5GImRta5qdC7OaiCia0CZxnx2m788k81IvX1P+njz0r0nGhpinmui34RqQ0 1LLcpxyFlUwhMmgM5wdJRaa3FZVqpzcm9Bx61LFS3f3ofTXy9KQ+mWvrl3GlqcNtX6Jj S2uWR8rhEqdNVk55tsvw7y1Kp3YrWLbVitfJY2XZhC2m+PIuSw1MnGxADyfP/xuMlIA7 QN5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DLTVi3Ko; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n17-20020a63e051000000b005573ed4beb7si326812pgj.819.2023.06.23.15.19.49; Fri, 23 Jun 2023 15:20:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DLTVi3Ko; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232153AbjFWVuk (ORCPT + 99 others); Fri, 23 Jun 2023 17:50:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232807AbjFWVtr (ORCPT ); Fri, 23 Jun 2023 17:49:47 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8904E2707 for ; Fri, 23 Jun 2023 14:49:46 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4f766777605so1504834e87.1 for ; Fri, 23 Jun 2023 14:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687556985; x=1690148985; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5DBVmcbPM6O4YzyX5TBk3hTNZ7EUrOs7o/4qOremoNA=; b=DLTVi3Ko6yVpZslF+BPqKOP0yiJUwxq4mfFrffeByYiurppR0iv8Pwj9rR+Es5MgkR 44er5a2wZohpMA5HoiEVmEhLqWdlTC6wKk0YQPdzimLPeV2brVMgFqaa4zGJ167odeuk LCqrxyhKuHvZ0RyxLdqqJhJ7vTTloIe/lTJoXFGxYGAbE9QGBgJLquMbFpvmGJJIwi4F ZJjkmQyfH9LuBHRFr6XXwd9V6ryr57hVuFPku3arzNnkJXBKofaNdsrcyVVwnRp1QKT9 v8qObWZs/Jk2iRhMEAYkagEpLKzTmL2zvS4WKenl0DO9/FbXHm/RQ4yM53u4/h4p2epQ QFYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687556985; x=1690148985; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5DBVmcbPM6O4YzyX5TBk3hTNZ7EUrOs7o/4qOremoNA=; b=XCJTvB+/oX0NpaaTS5dSdZDBTN3hKIg0glANEJ7/inY9SqsP2IUXxynPVc9YNQh8qS ue5P0CYR0ZrqnPyldGN0ihl36W2+TU8nl/V4YEIWdZRPZ8UZkV9MFvvyF3zalbRKajDz sD76bhAV5pxf9IBcO4tjE91yVKDF8iBxNy/eLDWDPNanu2iYmbl7nODcxehAYiR8Cjl7 PP/Rd1lAIXmMz55KBpDsASIReSRgW4M3eE3lEDw2dwY/LQRMlTTIGsS60rivllay+YTM ZgV2h3ZBcBpU82ZuiEAOd8gnf57RXHqhSU2g9nV6Afh0hPEkUVz48W4XcI9a1P6i+u1U yT0g== X-Gm-Message-State: AC+VfDyWp/Tv2NYwiblJXX+O+Fmg9DEa0T6cx3Jl7TY6HYx4bA9cYVi/ HtdEnOGfFRbuX2kDSE9omrrY8Q== X-Received: by 2002:a2e:900a:0:b0:2b4:6195:bb26 with SMTP id h10-20020a2e900a000000b002b46195bb26mr13985888ljg.25.1687556984775; Fri, 23 Jun 2023 14:49:44 -0700 (PDT) Received: from [192.168.1.101] (abyk30.neoplus.adsl.tpnet.pl. [83.9.30.30]) by smtp.gmail.com with ESMTPSA id x20-20020a2e9c94000000b002b48437dcaasm1840919lji.103.2023.06.23.14.49.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 14:49:44 -0700 (PDT) From: Konrad Dybcio Date: Fri, 23 Jun 2023 23:49:43 +0200 Subject: [PATCH 2/3] firmware: qcom_scm: Always return devm_clk_get_optional errors MIME-Version: 1.0 Message-Id: <20230623-topic-scm_cleanup-v1-2-383089eae98d@linaro.org> References: <20230623-topic-scm_cleanup-v1-0-383089eae98d@linaro.org> In-Reply-To: <20230623-topic-scm_cleanup-v1-0-383089eae98d@linaro.org> To: Andy Gross , Bjorn Andersson Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687556981; l=1572; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=pHysGjB4oZJ+5xN5W/FUx19qYCDxjkWrQHiYcbKX6uQ=; b=F9TfQwe9lA2sfHfajdi4PRDRwx/kETtoE4+UfIsGvDLi7W2Ey/0Aj1XfKriTsLSO9cvh0+L5l Aiesih+NUnqC8nf3K7HoDCSDZhyNQmUFCUg0jMBQKusn2IFa34idJ0v X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769533658496916691?= X-GMAIL-MSGID: =?utf-8?q?1769533658496916691?= If devm_clk_get_optional throws an error, something is really wrong. It may be a probe deferral, or it may be a problem with the clock provider. Regardless of what it may be, it should definitely not be ignored. Stop doing that. Signed-off-by: Konrad Dybcio --- drivers/firmware/qcom_scm.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index dfa298347041..d7fc972b20ab 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -1422,22 +1422,16 @@ static int qcom_scm_probe(struct platform_device *pdev) "failed to acquire interconnect path\n"); scm->core_clk = devm_clk_get_optional(&pdev->dev, "core"); - if (IS_ERR(scm->core_clk)) { - if (PTR_ERR(scm->core_clk) == -EPROBE_DEFER) - return PTR_ERR(scm->core_clk); - } + if (IS_ERR(scm->core_clk)) + return PTR_ERR(scm->core_clk); scm->iface_clk = devm_clk_get_optional(&pdev->dev, "iface"); - if (IS_ERR(scm->iface_clk)) { - if (PTR_ERR(scm->iface_clk) == -EPROBE_DEFER) - return PTR_ERR(scm->iface_clk); - } + if (IS_ERR(scm->iface_clk)) + return PTR_ERR(scm->iface_clk); scm->bus_clk = devm_clk_get_optional(&pdev->dev, "bus"); - if (IS_ERR(scm->bus_clk)) { - if (PTR_ERR(scm->bus_clk) == -EPROBE_DEFER) - return PTR_ERR(scm->bus_clk); - } + if (IS_ERR(scm->bus_clk)) + return PTR_ERR(scm->bus_clk); scm->reset.ops = &qcom_scm_pas_reset_ops; scm->reset.nr_resets = 1;