From patchwork Thu Jun 22 14:57:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugo Villeneuve X-Patchwork-Id: 111732 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5147269vqr; Thu, 22 Jun 2023 08:20:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ75/viiy5bRn6Zan/PH+sY8YxQZ4iSWXrKxB1yvcdh+bzj2tR7HStqk+tFbwUCWn89sz8um X-Received: by 2002:a17:903:25c4:b0:1b2:2c8e:5435 with SMTP id jc4-20020a17090325c400b001b22c8e5435mr17810865plb.4.1687447212840; Thu, 22 Jun 2023 08:20:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687447212; cv=none; d=google.com; s=arc-20160816; b=JrI/LTCNt9n3gFdeDG6DCsuv1hG4lfrv647BthGe0eLsTFsD/u5MARy3rjcNau9pms sMO5SrklbHCziIzklp8Wkd2oZeIR7NEDPAdmJO18mWyALr2bCRa65ddvWD4bbDUY4VUf jmeicxAH5f6E7aduDk8C5SYbGRHRwaIHCzPgiIz/LD1OYuAIFEOf3KcCfcBj40YBUNrH oSeUC50Lz8liDUOs4waFXi0k49jpX6tRzjlosggG9OqZc4DfwJTjV4BCq1jy3p4dfMKq wtmYa6lGVVi4q2+pVduGtOxT1sut4631T4kDB3hSUNgp5MQAiWt9y4J4ToOQ2ZgLJIZb pz+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from:dkim-signature; bh=L1Kzx+4zWacYuJwz+3sy0iCyc6Bbeym/Q/vUjvy7NUE=; b=a919e8JiU0myrxH0CnRiSy9vt2ZsbMtady3ELrRDqnPIt6XAVhRjO4W8q9OL7M5xir eF7BHJ9uGenJCw5sLpWyqbe5SU1Q1upIklFdsHIoQwSArZMvuM/Or+cDNc0U+T8tKu1m thu5T2cFomesrpZnkXWRVNfd52XxDgVSFqSorDY1qIhEhOLbj6mJkazoFoWcGnT8d9yX nt698FMBwLiy9OEbou0PNGd+bvzcgoRNmoaWcNe+AlljsmRPscw03RQWlEE0cBumS1WJ jaoDHnBdwYpj1pieAcdNFP+JkyU5tjSEB4rtbQarzlcobUg7B3nRAe7J2xS9g86UBUKA XL8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=LGpDIDJM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x21-20020a17090300d500b001b6b08f03ccsi1414946plc.345.2023.06.22.08.19.59; Thu, 22 Jun 2023 08:20:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=LGpDIDJM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232314AbjFVO7X (ORCPT + 99 others); Thu, 22 Jun 2023 10:59:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232155AbjFVO6a (ORCPT ); Thu, 22 Jun 2023 10:58:30 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36D4A1FF6; Thu, 22 Jun 2023 07:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=L1Kzx+4zWacYuJwz+3sy0iCyc6Bbeym/Q/vUjvy7NUE=; b=LGpDIDJMawFuTJEfbtZFl2D8g0 uKGn5ocRrVnLEO8n4cvf+SXi75Bnu2zqB31nIExbz6GxdUBE4+brxWcq0dqU6geII0/4vb2/QTS29 LH2BcKqkzJ5KyuGCWlWAiTF2EYxT1KNp0F6Ww41jFf6r6ZmK06u1I9vmKv+zYOvFhJ/M=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:55382 helo=localhost.localdomain) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qCLlQ-0002fr-DN; Thu, 22 Jun 2023 10:58:24 -0400 From: Hugo Villeneuve To: a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, hugo@hugovil.com, Hugo Villeneuve Date: Thu, 22 Jun 2023 10:57:59 -0400 Message-Id: <20230622145800.2442116-17-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230622145800.2442116-1-hugo@hugovil.com> References: <20230622145800.2442116-1-hugo@hugovil.com> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Subject: [PATCH v4 16/17] rtc: pcf2127: add UIE support for PCF2131 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769416648481015772?= X-GMAIL-MSGID: =?utf-8?q?1769416648481015772?= From: Hugo Villeneuve The PCF2127/29 do NOT support alarms with a 1 second resolution, but the PCF2131 does. Signed-off-by: Hugo Villeneuve --- drivers/rtc/rtc-pcf2127.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c index 9da3f0096d6b..0ff589789aea 100644 --- a/drivers/rtc/rtc-pcf2127.c +++ b/drivers/rtc/rtc-pcf2127.c @@ -1128,8 +1128,16 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap, pcf2127->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; pcf2127->rtc->range_max = RTC_TIMESTAMP_END_2099; pcf2127->rtc->set_start_time = true; /* Sets actual start to 1970 */ - set_bit(RTC_FEATURE_ALARM_RES_2S, pcf2127->rtc->features); - clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, pcf2127->rtc->features); + + /* + * PCF2127/29 do not work correctly when setting alarms at 1s intervals. + * PCF2131 is ok. + */ + if (pcf2127->cfg->type == PCF2127 || pcf2127->cfg->type == PCF2129) { + set_bit(RTC_FEATURE_ALARM_RES_2S, pcf2127->rtc->features); + clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, pcf2127->rtc->features); + } + clear_bit(RTC_FEATURE_ALARM, pcf2127->rtc->features); if (alarm_irq > 0) {