From patchwork Thu Jun 22 08:18:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 111485 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp4908776vqr; Thu, 22 Jun 2023 01:24:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6uztLtl1a9DUvIwi+Bc+6/TSj6DT+pdh82W46x3e6zek4+Xa6dG1vOGO6jGjaQBcErWxnh X-Received: by 2002:a05:6359:b9d:b0:12f:28f3:4cec with SMTP id gf29-20020a0563590b9d00b0012f28f34cecmr8575041rwb.26.1687422246770; Thu, 22 Jun 2023 01:24:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687422246; cv=none; d=google.com; s=arc-20160816; b=Z9XIMmd1Lj0S01/teiaFIbSxhQI2piSXaMAg20S8BBOUlcibnFUV9Ilk5ozxilILWj BJuClQg12IhS5tlKIBq8dE370FynoS8zux1BaXj1dJ6ekzCUNj8bBOAgwFObd+xIX/DC ZVeIeFL9fWG5k1gds9515WJLYpvm71lQN746znPtiw7P5g71SR1JlLh6qjeXF4yO97qd xpLWtQD0wsfm21/dVHLEPqi0U1BPG74nBCZosZmsQQwfMxdK8Z0b93RHMkIlA+RGBTs/ iFQNMk86rX+3x2Q/3G3/ZI6RH/EoOAyx+hXsYxk6zZXGSfYBohWLNWrsdKTgku+lhp+2 tk7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=NS1xFrJX+6qQ1UwuwL9AKus1/EqzRZr8t+BiNUW5wqs=; b=XeRtfmgWDT29EXc19r/6opXe/3Jx12hH6BB2if42SF7NIsv9Kw6MoBB4I0/OO/Gl2k Oqlk6VZlh5j7rnGwHjPP60AU1yhRyBeLzCVdTBf1kUWkQ4+qSuTvuakJBJP39GD8Vxru 0dw/zoutJroh6zJh4ZMSOdr20ndWFlQ4RDg+C7JaGUeIp6TIw80WBx9Uk42nBQzq4PDR eyndS8gTZllsErXfJ0qEmhdYOqT5DYApLkaRRQUHMKBsWiTnAv1qgbjSVvLXTinecqJ/ M2ZL1CASQ4qA0TpljFaEXPtMzZn/Ls7mN2KTw3k9Trxk5uYZmX4+U0R06kRxM08K1+kO z8/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=eNROBa+n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a73-20020a63904c000000b0053f812a109esi6090543pge.796.2023.06.22.01.23.53; Thu, 22 Jun 2023 01:24:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=eNROBa+n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229993AbjFVITF (ORCPT + 99 others); Thu, 22 Jun 2023 04:19:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229828AbjFVIS7 (ORCPT ); Thu, 22 Jun 2023 04:18:59 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19A3D2137; Thu, 22 Jun 2023 01:18:24 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f900cd3f96so57711005e9.2; Thu, 22 Jun 2023 01:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687421900; x=1690013900; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NS1xFrJX+6qQ1UwuwL9AKus1/EqzRZr8t+BiNUW5wqs=; b=eNROBa+nMhlNdHc5aqnSWxtIYlaf62BFhUpz3BgduwicT5nT/o7qgZbb9ZmQjexO7y u/ohXuwkI+0nJayvgLe7ECvtIsciAgZtCa8tg03D4U6R7iv1mR2rEyiEyiC6OuZdV8Qj 8/BdVOR6wex1mt6PZCFd1zhJhWc40aH06z6Hk0GuunE/sDtZYhUuA1tlUrs+AaBNn/SZ KOBPp3YV3wB1ieZMi9hKdLOYSRhYnIlNkry4+s+2sdA4he7xI+qtIYwsDOPIrMPHkxDF Kff0V9ZmLdLeYRTR/hsrjaMThmNzDVwV8yYb2rGQ4f9LPlCsHry03XCAK10mGFZ2R93G IQtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687421900; x=1690013900; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NS1xFrJX+6qQ1UwuwL9AKus1/EqzRZr8t+BiNUW5wqs=; b=HaThwW/4srncxR9vM/qdMeTrtJq+JvMf4UK3UrKPjvKjdvH9ZYKYmwj3fIhcg/0W+G U7+KA0StJcnCWLNJPjMWzCAFQs/n3Iu4TZaeNs327lvRcAVGCdEZ0y7ysAy/R24rqopV RveY4put+gkPuzbtzZhbupsBWsWLxnMl8N6bvCLTDxFweB7c+zpK4dG/BsDXZgqpiWNk 8MMW8F8hSQwyYaAVqDUYTO7t8taroP+Ju4n1PSGfZVBRY88Q5TNsNfhT2b5iRvabrmC3 dzVcVQn958qASK7wQeiHGJbzYGH1V9vjNCsTal5Vj08EtDW8RxUHGLy/E3ob/c92GYNp zcgA== X-Gm-Message-State: AC+VfDyNwHQykgQoMXVzrTDpliGSWwt03xxA4GFaZkUf0ntnbgLSuOXK cItc4L4bml+s81w3MaqIOD8= X-Received: by 2002:a7b:cbcd:0:b0:3fa:74bf:f028 with SMTP id n13-20020a7bcbcd000000b003fa74bff028mr486383wmi.0.1687421899802; Thu, 22 Jun 2023 01:18:19 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id 9-20020a05600c240900b003f93c450657sm6974330wmp.38.2023.06.22.01.18.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 01:18:19 -0700 (PDT) From: Colin Ian King To: Alexander Viro , Christian Brauner Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] pipe: remove redundant initialization of pointer buf Date: Thu, 22 Jun 2023 09:18:18 +0100 Message-Id: <20230622081818.2795019-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769390469772695503?= X-GMAIL-MSGID: =?utf-8?q?1769390469772695503?= The pointer buf is being initialized with a value that is never read. Buf is being re-assigned later on, the initialization is redundant and can be removed. Cleans up clang scan build warning: fs/pipe.c:492:24: warning: Value stored to 'buf' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King --- fs/pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/pipe.c b/fs/pipe.c index 2d88f73f585a..71b6b0545e0f 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -489,7 +489,7 @@ pipe_write(struct kiocb *iocb, struct iov_iter *from) head = pipe->head; if (!pipe_full(head, pipe->tail, pipe->max_usage)) { unsigned int mask = pipe->ring_size - 1; - struct pipe_buffer *buf = &pipe->bufs[head & mask]; + struct pipe_buffer *buf; struct page *page = pipe->tmp_page; int copied;