diff mbox series

dmaengine: mediatek: drop bogus pm_runtime_set_active()

Message ID 20230622075150.885-1-johan+linaro@kernel.org
State New
Headers
Series dmaengine: mediatek: drop bogus pm_runtime_set_active() |

Commit Message

Johan Hovold June 22, 2023, 7:51 a.m. UTC 
  The runtime PM state must be updated while runtime PM is disabled for
the change to take effect.

Drop the bogus pm_runtime_set_active() which left the PM state set to
suspended (as it should be or the clock would not be enabled when the
device is resumed).

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/dma/mediatek/mtk-uart-apdma.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Vinod Koul July 11, 2023, 4:44 p.m. UTC | #1 
On Thu, 22 Jun 2023 09:51:50 +0200, Johan Hovold wrote:
> The runtime PM state must be updated while runtime PM is disabled for
> the change to take effect.
> 
> Drop the bogus pm_runtime_set_active() which left the PM state set to
> suspended (as it should be or the clock would not be enabled when the
> device is resumed).
> 
> [...]

Applied, thanks!

[1/1] dmaengine: mediatek: drop bogus pm_runtime_set_active()
      commit: 1775a0d9f021739a69e4cf12c049801c9cf1a072

Best regards,
diff mbox series

Patch

diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c
index a1517ef1f4a0..92864c9371a3 100644
--- a/drivers/dma/mediatek/mtk-uart-apdma.c
+++ b/drivers/dma/mediatek/mtk-uart-apdma.c
@@ -551,7 +551,6 @@  static int mtk_uart_apdma_probe(struct platform_device *pdev)
 	}
 
 	pm_runtime_enable(&pdev->dev);
-	pm_runtime_set_active(&pdev->dev);
 
 	rc = dma_async_device_register(&mtkd->ddev);
 	if (rc)