From patchwork Thu Jun 22 06:53:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Leonard_G=C3=B6hrs?= X-Patchwork-Id: 111464 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp4877850vqr; Thu, 22 Jun 2023 00:12:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5pv3AsRQNsbLUmulEdwKFVgSulU1i7Q0zGrIFVCl/IVqNsdz8MdsmPrxxKfGKouVekbsM2 X-Received: by 2002:a05:6a00:124f:b0:66a:4dd2:7b43 with SMTP id u15-20020a056a00124f00b0066a4dd27b43mr3048443pfi.9.1687417924319; Thu, 22 Jun 2023 00:12:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687417924; cv=none; d=google.com; s=arc-20160816; b=x6Nz1nn/YKZJi31GMuz0teOVZzNHrlPWIbY+OL3qyKDpskDv0YKxVV3sBcGWqaGRSB RpcpDmAPiHPwzChqZkKVNgy9AROpuFqTUo09ZVbENXNA32iNpKC9BPjJwtrVV50l5yIz vPSFxskzIAUsZ/kW8rKgbmKZDW3pfA7P6FNWVZCWu0t9RlnLMZ2f0sVdQ/EtPLC84B+0 NbiAnB7ZlhN+Ao41f7HAxuAH7H4jidjkQsvXCNNn0GSscGNUkh7b4olF+Ma5NjjwwtBF 8riPTWRJlByMLbFIlhIZ2+BUYxtZn5RqIMAUkGqpqiyaJHoOK4sQlSCta9cffwa8T22r 2Fxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=3PzTOWSWaUlX/FZusCMC67ssWt/Sfb8Gux7EfEmwbmM=; b=oE7MBwqdBBuq8l0h/D82UCI8S6k1gApgzuhi7SmtBPszUauj2bDItW2swJo7rgz1ux UBNi67WPuQB+dLBVU8HRKF1uis/gOaKfKZFowTTigqWQEGITqdL26doi9+drKXK4aYjZ A0T8Ug7gFcXR3HLjDwe8DXPmE1qzv9dFkLqxN3bQOr4WBWEpOqvgMvij0MIOxbIOthKG n5J9Csxsu5xFiBE1PqBSuW6P/eHTmslzkbN9jcCz5nCh6YYp01S6nBNPge16C+hYsFrq Jb41WSBWm7kY0U4NQxL2OhIX75F1ksGSfuFGPEr2NC3DQa3XmvLjW1T6WmMLKvFI3gGw NRow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l65-20020a639144000000b005573d0a4de4si2160249pge.218.2023.06.22.00.11.52; Thu, 22 Jun 2023 00:12:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231301AbjFVG41 (ORCPT + 99 others); Thu, 22 Jun 2023 02:56:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230511AbjFVGzw (ORCPT ); Thu, 22 Jun 2023 02:55:52 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADB8B1FDF for ; Wed, 21 Jun 2023 23:55:20 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qCEDP-0005ps-T8; Thu, 22 Jun 2023 08:54:47 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qCEDP-009DEL-3z; Thu, 22 Jun 2023 08:54:47 +0200 Received: from lgo by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qCEDO-004k4R-CG; Thu, 22 Jun 2023 08:54:46 +0200 From: =?utf-8?q?Leonard_G=C3=B6hrs?= To: =?utf-8?q?Leonard_G=C3=B6hrs?= , kernel@pengutronix.de, Jonathan Cameron , Lars-Peter Clausen Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] iio: adc: add buffering support to the TI LMP92064 ADC driver Date: Thu, 22 Jun 2023 08:53:41 +0200 Message-Id: <20230622065341.1100525-1-l.goehrs@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: lgo@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768664361572363339?= X-GMAIL-MSGID: =?utf-8?q?1769385937403071477?= Enable buffered reading of samples from the LMP92064 ADC. The main benefit of this change is being able to read out current and voltage measurements in a single transfer, allowing instantaneous power measurements. Reads into the buffer can be triggered by any software triggers, e.g. the iio-trig-hrtimer: $ mkdir /sys/kernel/config/iio/triggers/hrtimer/my-trigger $ cat /sys/bus/iio/devices/iio\:device3/name lmp92064 $ iio_readdev -t my-trigger -b 16 iio:device3 | hexdump WARNING: High-speed mode not enabled 0000000 0000 0176 0101 0001 5507 abd5 7645 1768 0000010 0000 016d 0101 0001 ee1e ac6b 7645 1768 ... Signed-off-by: Leonard Göhrs --- Changes v1->v2: - Remove superfluous .shift = 0 initialization in scan_type. - Replace kmalloc buffer allocation for every read with a stack allocated structure. A struct is used to ensure correct alignment of the timestamp field. See e.g. adc/rockchip_saradc.c for other users of the same pattern. - Use available_scan_masks and always push both voltage and current measurements to the buffer. --- drivers/iio/adc/ti-lmp92064.c | 50 +++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7 diff --git a/drivers/iio/adc/ti-lmp92064.c b/drivers/iio/adc/ti-lmp92064.c index c30ed824924f3..a4e64ee8a7b50 100644 --- a/drivers/iio/adc/ti-lmp92064.c +++ b/drivers/iio/adc/ti-lmp92064.c @@ -16,7 +16,10 @@ #include #include +#include #include +#include +#include #define TI_LMP92064_REG_CONFIG_A 0x0000 #define TI_LMP92064_REG_CONFIG_B 0x0001 @@ -91,6 +94,12 @@ static const struct iio_chan_spec lmp92064_adc_channels[] = { .address = TI_LMP92064_CHAN_INC, .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), + .scan_index = TI_LMP92064_CHAN_INC, + .scan_type = { + .sign = 'u', + .realbits = 12, + .storagebits = 16, + }, .datasheet_name = "INC", }, { @@ -98,8 +107,20 @@ static const struct iio_chan_spec lmp92064_adc_channels[] = { .address = TI_LMP92064_CHAN_INV, .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), + .scan_index = TI_LMP92064_CHAN_INV, + .scan_type = { + .sign = 'u', + .realbits = 12, + .storagebits = 16, + }, .datasheet_name = "INV", }, + IIO_CHAN_SOFT_TIMESTAMP(2), +}; + +static const unsigned long lmp92064_scan_masks[] = { + BIT(TI_LMP92064_CHAN_INC) | BIT(TI_LMP92064_CHAN_INV), + 0 }; static int lmp92064_read_meas(struct lmp92064_adc_priv *priv, u16 *res) @@ -171,6 +192,29 @@ static int lmp92064_read_raw(struct iio_dev *indio_dev, } } +static irqreturn_t lmp92064_trigger_handler(int irq, void *p) +{ + struct iio_poll_func *pf = p; + struct iio_dev *indio_dev = pf->indio_dev; + struct lmp92064_adc_priv *priv = iio_priv(indio_dev); + struct { + u16 values[2]; + int64_t timestamp; + } data; + int ret; + + ret = lmp92064_read_meas(priv, data.values); + if (ret >= 0) { + /* Only push values if the read succeeded */ + iio_push_to_buffers_with_timestamp(indio_dev, &data, + iio_get_time_ns(indio_dev)); + } + + iio_trigger_notify_done(indio_dev->trig); + + return IRQ_HANDLED; +} + static int lmp92064_reset(struct lmp92064_adc_priv *priv, struct gpio_desc *gpio_reset) { @@ -301,6 +345,12 @@ static int lmp92064_adc_probe(struct spi_device *spi) indio_dev->channels = lmp92064_adc_channels; indio_dev->num_channels = ARRAY_SIZE(lmp92064_adc_channels); indio_dev->info = &lmp92064_adc_info; + indio_dev->available_scan_masks = lmp92064_scan_masks; + + ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, + lmp92064_trigger_handler, NULL); + if (ret) + return dev_err_probe(dev, ret, "Failed to setup buffered read\n"); return devm_iio_device_register(dev, indio_dev); }