diff mbox series

perf test: Remove x permission from lib/stat_output.sh

Message ID 20230622055832.83476-1-namhyung@kernel.org
State New
Headers
Series perf test: Remove x permission from lib/stat_output.sh |

Commit Message

Namhyung Kim June 22, 2023, 5:58 a.m. UTC 
  The commit fc51fc87b1b8 factored out the helper functions to a library
but the new file had execute permission.  Due to the way it detects
the shell test scripts, it showed up in the perf test list unexpectedly.

  $ ./perf test list 2>&1 | grep 86
   76: x86 bp modify
   77: x86 Sample parsing
   78: x86 hybrid
   86:                        <---- (here)

  $ ./perf test -v 86
   86:                                                                 :
  --- start ---
  test child forked, pid 1932207
  test child finished with 0
  ---- end ----
  : Ok

As it's a collection of library functions, it should not run as is.
Let's remove the execute permission.

Fixes: fc51fc87b1b8 ("perf test: Move all the check functions of stat CSV output to lib")
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/tests/shell/lib/stat_output.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100755 => 100644 tools/perf/tests/shell/lib/stat_output.sh

Comments

Ian Rogers June 22, 2023, 5:51 p.m. UTC | #1 
On Wed, Jun 21, 2023 at 10:58 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> The commit fc51fc87b1b8 factored out the helper functions to a library
> but the new file had execute permission.  Due to the way it detects
> the shell test scripts, it showed up in the perf test list unexpectedly.
>
>   $ ./perf test list 2>&1 | grep 86
>    76: x86 bp modify
>    77: x86 Sample parsing
>    78: x86 hybrid
>    86:                        <---- (here)
>
>   $ ./perf test -v 86
>    86:                                                                 :
>   --- start ---
>   test child forked, pid 1932207
>   test child finished with 0
>   ---- end ----
>   : Ok
>
> As it's a collection of library functions, it should not run as is.
> Let's remove the execute permission.
>
> Fixes: fc51fc87b1b8 ("perf test: Move all the check functions of stat CSV output to lib")
> Cc: Kan Liang <kan.liang@linux.intel.com>
> Cc: Andi Kleen <ak@linux.intel.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/tests/shell/lib/stat_output.sh | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  mode change 100755 => 100644 tools/perf/tests/shell/lib/stat_output.sh
>
> diff --git a/tools/perf/tests/shell/lib/stat_output.sh b/tools/perf/tests/shell/lib/stat_output.sh
> old mode 100755
> new mode 100644
> --
> 2.41.0.162.gfafddb0af9-goog
>
diff mbox series

Patch

diff --git a/tools/perf/tests/shell/lib/stat_output.sh b/tools/perf/tests/shell/lib/stat_output.sh
old mode 100755
new mode 100644