From patchwork Wed Jun 21 19:13:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pawel Dembicki X-Patchwork-Id: 111289 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp4591965vqr; Wed, 21 Jun 2023 12:25:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4SC0OFRoSwjEnRyPyMylST/bkJvmilKAKiPL4k1teNjpG8kx4QO7fwz0dTRsgC37UpAFev X-Received: by 2002:a05:6a20:7f8c:b0:11a:f632:78fb with SMTP id d12-20020a056a207f8c00b0011af63278fbmr21195839pzj.19.1687375548649; Wed, 21 Jun 2023 12:25:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687375548; cv=none; d=google.com; s=arc-20160816; b=KD77OKZuP5d7emVxye7Q0Aa8OEnietiyJNn2mKhHLaZIa+IjyWu4JlAoWVcahYIItX N4rnNHabFe2n5cU4ujzhrxEsAnjOupYrdgCoH5RwBe/VH9NqnaZqv9fIsKB3iwHmZWsM qxeY2lvvCu4W88YlQ4A7y6D2BNf0k1aTtPu1PfGwCvCmoZ0M53oCLiJu7cgPHZsmnygn SGM+VIf6Kjt6XjC639JJlVumvd3ycohWbkV0UU3vMbmMeCV7iA715S/OjSF9RivwtHU6 a2h1WKolARybv8xGrgS6QtytGISQTV/XimXM0OmCJUXqvdrlIEO3wjUHVOp75W4NoWbQ hnfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BdYtgHKZj+ELTXrWmyVhlIH7tFc3MvfFabglOK+p780=; b=SjSPDyS4M73e1SiDZ888fK2nrczOqmpnCMJXpN1ZX/tDIjvP+kn/Gt5yG1Sb+mIWYR yfb+x+Keg1/cptwHxce0fqtMiUYV6I1EMarA3UBHFFj4AlITedJj0uRHGU2+TMQpdXj2 /9n0Z9hsMAiHCq1etP/RtQrqMgjcdCDWCNVO+JW/1YzUfX6ZKF2cCadMQcHToaFVfxIa wgJOdQ0aZKdn5312It4b4FWhwtDwVVAZIHd2IywiSc3LtKsgucfxFBjrYRCeceE8qJgu xdYdhEUgSNUqcPGEZLdk/DkoTR9tf1RoBiHjhbV5sC4iiFtrLGkFAucE9cOJkOoiZ4t8 cU2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=WXgkrRpN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s20-20020a63af54000000b005539d3ab912si4536445pgo.575.2023.06.21.12.25.34; Wed, 21 Jun 2023 12:25:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=WXgkrRpN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231963AbjFUTOy (ORCPT + 99 others); Wed, 21 Jun 2023 15:14:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbjFUTO3 (ORCPT ); Wed, 21 Jun 2023 15:14:29 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41DAF1FE6; Wed, 21 Jun 2023 12:14:20 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-98862e7e3e6so589299466b.0; Wed, 21 Jun 2023 12:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687374858; x=1689966858; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BdYtgHKZj+ELTXrWmyVhlIH7tFc3MvfFabglOK+p780=; b=WXgkrRpNV56pikPYNbETkpOiv1IcHYuJvW8/KS9rXaLhYXpVRTs6PWx1fAuFZN72Q1 HTbGS1e2jMI0pZK66Asq4XV1AF9EUKf/iQyjhQr0eIzu17rYRmk+V0fB7gVsrXUoLxPj sP3YWzUET9wo/mA4jfFp/DH1t3i2kmWfv1I4kHy2mWq+zjMQ7SbPrTHaI8grT1IPtSM9 9anmQkDLJulg48sUBYIY+/8+wjT7T9Furh+qdo7ZMRCW1ZsqlNRyFjtojbhNb+UDgSiL sRPSyCg6VDfvFJBLwRT7HH2J2OsU7hi+XrUxJW5D1gz5KAZ68oix8XF3HLhVFYfDsj+P HpAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687374858; x=1689966858; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BdYtgHKZj+ELTXrWmyVhlIH7tFc3MvfFabglOK+p780=; b=f/MNNErde+ZBpvMSu04Pf3drb5FoSTqBf2llH8hPL84zxUNR3h6zZ9Xynr5hrjsy0y b1LZ7gSrFsAb7ZDBJNnpQBQDeS2/21P2HYjm940xBU+A3GjBI7sJP7qZo9Rbi3e1xC1i mcltblnrZUqcc42lYo5/NZ2tqtAl3j32z4vYU0Blx9bjgOAL6q5Bo7pp13+xGltnZiKI lAuk2OcEuB0zDSNaLW8PnvNXIjpCHp43spmfN/xOS6HqPm/AxqARrcUQEgiZ0TNh5wLy WTv+T6NLjFP/iE5/4h4ziEScCNs59MK9+zE3hD3aQOnBQmV1TJmVn8dvsldBWyrBU/F5 MDng== X-Gm-Message-State: AC+VfDwTFUAP2V0AuKkqrTDUu8xnfccPXKjWVyMn+UzUqo3Jee2WenhB 90abASRImu8ud4oHbgxKRlfU1b3G/qKIPg== X-Received: by 2002:a17:907:7d86:b0:978:8790:9103 with SMTP id oz6-20020a1709077d8600b0097887909103mr16038144ejc.70.1687374858324; Wed, 21 Jun 2023 12:14:18 -0700 (PDT) Received: from WBEC325.dom.local ([185.188.71.122]) by smtp.gmail.com with ESMTPSA id gu1-20020a170906f28100b009829a5ae8b3sm3539562ejb.64.2023.06.21.12.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 12:14:18 -0700 (PDT) From: Pawel Dembicki To: netdev@vger.kernel.org Cc: linus.walleij@linaro.org, Pawel Dembicki , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net-next 6/6] net: dsa: vsc73xx: fix MTU configuration Date: Wed, 21 Jun 2023 21:13:02 +0200 Message-Id: <20230621191302.1405623-6-paweldembicki@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230621191302.1405623-1-paweldembicki@gmail.com> References: <20230621191302.1405623-1-paweldembicki@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769341503438167734?= X-GMAIL-MSGID: =?utf-8?q?1769341503438167734?= Switch in MAXLEN register store maximum size of data frame. MTU size is 18 bytes smaller than frame size. Current settings causes problems with packet forwarding. This patch fix MTU settings to proper values. Fixes: fb77ffc6ec86 ("net: dsa: vsc73xx: make the MTU configurable") Signed-off-by: Pawel Dembicki Reviewed-by: Linus Walleij --- drivers/net/dsa/vitesse-vsc73xx-core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/dsa/vitesse-vsc73xx-core.c b/drivers/net/dsa/vitesse-vsc73xx-core.c index fcce47cf6da4..a806a263cf08 100644 --- a/drivers/net/dsa/vitesse-vsc73xx-core.c +++ b/drivers/net/dsa/vitesse-vsc73xx-core.c @@ -992,17 +992,18 @@ static int vsc73xx_change_mtu(struct dsa_switch *ds, int port, int new_mtu) struct vsc73xx *vsc = ds->priv; return vsc73xx_write(vsc, VSC73XX_BLOCK_MAC, port, - VSC73XX_MAXLEN, new_mtu); + VSC73XX_MAXLEN, new_mtu + ETH_HLEN + ETH_FCS_LEN); } /* According to application not "VSC7398 Jumbo Frames" setting - * up the MTU to 9.6 KB does not affect the performance on standard + * up the frame size to 9.6 KB does not affect the performance on standard * frames. It is clear from the application note that * "9.6 kilobytes" == 9600 bytes. */ static int vsc73xx_get_max_mtu(struct dsa_switch *ds, int port) { - return 9600; + /* max mtu = 9600 - ETH_HLEN - ETH_FCS_LEN */ + return 9582; } static void vsc73xx_port_stp_state_set(struct dsa_switch *ds, int port,