From patchwork Wed Jun 21 17:49:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 111237 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp4547445vqr; Wed, 21 Jun 2023 11:03:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4N+wxxzGOiycL9a2fnwfWgq/tC6sfOfhomKs1+aT9cfB4a1QvNE6wggkDyLzbinyjmBjLw X-Received: by 2002:a05:6a20:4288:b0:11f:4412:fc77 with SMTP id o8-20020a056a20428800b0011f4412fc77mr6576723pzj.17.1687370627863; Wed, 21 Jun 2023 11:03:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687370627; cv=none; d=google.com; s=arc-20160816; b=DcoWtlPolbmAkzhlXCfdLY7tL1ZWwK9jDKjV/auVymKxgDowxMZcPbxBC6I5Oyq+PB KQH+pbId3vTumVJ3gqYlwrr28vIMT90QSe6MNOeodd3U4sAIgwiCnYkR9TGvBTt4jqiz 7JAn+kmwYxpdfBiI/u/BMHANtK7KJe6ABHL7OwKhBqj+Btng3gR1/VUZwqEF582ICyb1 CKKwfEcp9NzFn/QSdb3I9If2EQUon1gccJsd4tZ219BV7dq8lDqKLhzu0PFOcJT7xrkx EjypM0FpAZbpeBGVraA9Rj88VxASS7TZCx4nr4Uyy9C0bbROB0DedgvQGQVcmh+ZY3Kk AOtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AcOoaKYWtnXVk0k+hK8RP3KkSMP7FlPHQIbKB3NJEDQ=; b=o1MBphFLFy/zXawrdWRND3tEzJALRpeLJvA0k3ZmdV+HPPlJ+h4fB9MlfIk026UfTi 4sEZ5lduXCWiBtFH7tkbEGc20VcpzHoCRQK7Y4znWqZUm5XZwcr0i+GZlm2uJ83Kxn7W 1XuOfSx2/pb1cMzWZ1bwIolhxzp4UpsoLG0ercMJUxuGGJMkJzJv/6s78qLlvhsNUuey ZEC5xF/DWYEqMvuV+sHE7QxI2fpCiAsycg5vgKn1cM/4SruPzsoLXyzQIi+SAfOdbkYk hCecN31Mmb0TiLh1KizVVDBD2y56wFk9cLYql1IngZopJSeUCf0YYyWY3rWVbAH/l39N DV5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XJObtDWv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bv64-20020a632e43000000b00553c2f59c1esi1098926pgb.193.2023.06.21.11.03.34; Wed, 21 Jun 2023 11:03:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XJObtDWv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231305AbjFURto (ORCPT + 99 others); Wed, 21 Jun 2023 13:49:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230371AbjFURtm (ORCPT ); Wed, 21 Jun 2023 13:49:42 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC3811718; Wed, 21 Jun 2023 10:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687369781; x=1718905781; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kdcUcjY6P739bulIvEkWeV/vSYtThvEuSEz95gNk9Zw=; b=XJObtDWvvw/ga0sMmuK91gESfw48jbl9XYWALd1P5jcGqzSXLngK03LW 3qV/PBFX3pFHXgi0WgBiasPutU8LwxfJb9gZWz4oMAu0oTYj4lAdzk2KT F1FzFELyxqWKydkKAyzX0DiNUyH6rN7f0gSwBX8tOARLjq6Bm1oQF1Xr7 jmzz38slUaPmuN1GhNUDUs1EXO+PTYf8sI8jaY2r0OI4rQX/JvTY+fRbL cuWUbjkmTfPcUJpRldllAVWW0gEfuVhJNfXyZyxCc5x+YEL7ZI85qJ/U2 4xIvof1bm37ag46Jmioh8d0IIooEMH4bp4OWKqHZ5CNzVJ3O2DK1L1qts g==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="389819283" X-IronPort-AV: E=Sophos;i="6.00,261,1681196400"; d="scan'208";a="389819283" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 10:49:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="691928082" X-IronPort-AV: E=Sophos;i="6.00,261,1681196400"; d="scan'208";a="691928082" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga006.jf.intel.com with ESMTP; 21 Jun 2023 10:49:39 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 7D689193; Wed, 21 Jun 2023 20:49:49 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko Subject: [PATCH v1 2/5] gpiolib: Factor out gpiochip_simple_create_domain() Date: Wed, 21 Jun 2023 20:49:40 +0300 Message-Id: <20230621174943.30302-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230621174943.30302-1-andriy.shevchenko@linux.intel.com> References: <20230621174943.30302-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769336343639237418?= X-GMAIL-MSGID: =?utf-8?q?1769336343639237418?= As a preparatory patch and for the sake of consistency, factor out gpiochip_simple_create_domain(). Signed-off-by: Andy Shevchenko Reviewed-by: Linus Walleij --- drivers/gpio/gpiolib.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 058deaa1aa36..fac1124d5016 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1444,6 +1444,19 @@ static const struct irq_domain_ops gpiochip_domain_ops = { .xlate = irq_domain_xlate_twocell, }; +static struct irq_domain *gpiochip_simple_create_domain(struct gpio_chip *gc) +{ + struct fwnode_handle *fwnode = dev_fwnode(&gc->gpiodev->dev); + struct irq_domain *domain; + + domain = irq_domain_create_simple(fwnode, gc->ngpio, gc->irq.first, + &gpiochip_domain_ops, gc); + if (!domain) + return ERR_PTR(-EINVAL); + + return domain; +} + /* * TODO: move these activate/deactivate in under the hierarchicial * irqchip implementation as static once SPMI and SSBI (all external @@ -1670,13 +1683,9 @@ static int gpiochip_add_irqchip(struct gpio_chip *gc, if (IS_ERR(gc->irq.domain)) return PTR_ERR(gc->irq.domain); } else { - gc->irq.domain = irq_domain_create_simple(fwnode, - gc->ngpio, - gc->irq.first, - &gpiochip_domain_ops, - gc); - if (!gc->irq.domain) - return -EINVAL; + gc->irq.domain = gpiochip_simple_create_domain(gc); + if (IS_ERR(gc->irq.domain)) + return PTR_ERR(gc->irq.domain); } if (gc->irq.parent_handler) {