Message ID | 20230621093103.3134655-2-msp@baylibre.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp4240692vqr; Wed, 21 Jun 2023 02:49:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6NOrN3EHO8AK/nMvpKkom3eKq5EFIpQHW2bH/dMyz1G75Rvv6HWqe1Xj9YEemiYgxDb94p X-Received: by 2002:a05:6a20:748d:b0:10c:89cc:bc5f with SMTP id p13-20020a056a20748d00b0010c89ccbc5fmr18644567pzd.20.1687340981333; Wed, 21 Jun 2023 02:49:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687340981; cv=none; d=google.com; s=arc-20160816; b=jhn4XhVAc5QJqYJqNy/K3ckLnp57qxJmlXVcbs5Y5/Xu8Dcnho1lhD2Fn142G8uYBb Rprbak0L3Ih/JbSdhgU44QZMCzEkDY8OjIUnLMqbWqlkxZYriR3aPoEU+o7jwFytTCQm y3eE7mJm/aiTy9tMHiGNorktDwZCsvHWrMKrKaM25UG8I0kGlSVVegVttJJbeInnnarK mfcTyBBIviYjGjveueLbCd8kbOEn40/JHtG0ZJVEbc4Y4eddFX/Fo7T80P9cj64jTOns Sjad1VeFVMURHhtueVt/sOM/FJcPx+Lf09KtCHtaSZIagk2Y+PeoGI82Nfw8CrmJ/Lcy Mfbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iUVZalfP6V27NAYz5kQTxrxcxQh7F8OqnR+1IuXKgno=; b=i6ckLqmUh9h6x+aEy8nBVU+rcOudHj26gDtb5ZzbIM2ySh0cGI9gwBBJbj0XmS01G/ anMK4SH+jOVjKCN/gDR5Lpxrw/8Tb0F2pkCDPc3UkYS+Xok6/ityYtiw9JW6gp207wrf eMIVCYbSglczZTydIsxqBK0RZH8a9++iWOgD3Vz4uWY4u8q7jqJZeH7QTA+oXNi5an2J rV+D5wJv4OVs1shj42cdIhzc1b9uqAadQxosPjuUiaJk8BlPZH9qTx/9XQdrRpH3BWya zriMzky0RQXzVQAZs1yvXBkXmLHxENo+4WQtCE7EnZ257WsM8G1mbqDUlDmXNkiuILNV 8onQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20221208.gappssmtp.com header.s=20221208 header.b=1NSCmre2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c187-20020a624ec4000000b006561e6f6603si3736317pfb.106.2023.06.21.02.49.24; Wed, 21 Jun 2023 02:49:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20221208.gappssmtp.com header.s=20221208 header.b=1NSCmre2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230339AbjFUJcb (ORCPT <rfc822;maxin.john@gmail.com> + 99 others); Wed, 21 Jun 2023 05:32:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231861AbjFUJbP (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 21 Jun 2023 05:31:15 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5683510F8 for <linux-kernel@vger.kernel.org>; Wed, 21 Jun 2023 02:31:11 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2b46a06c553so63823711fa.1 for <linux-kernel@vger.kernel.org>; Wed, 21 Jun 2023 02:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1687339869; x=1689931869; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iUVZalfP6V27NAYz5kQTxrxcxQh7F8OqnR+1IuXKgno=; b=1NSCmre2p7CtkNBkBJvdszJkRwwGaioXWZdO9EoPmJnoKNEGXXEu6EFvU6OgprI5xc tNLkv1dB9ERCHrEUpnTmLZDBzjMzhSVv4UdIs49WCyTKl8Kh/tuD9bFDYntp0pq77pkh rAo12jFi/yvwkjV6rGqstr6iqTzJgJ65dZl8q2XnC53Duoonqw3IhHvngOffXYqqEG3N Xm0SbOk8kbFQCK3y7GZwC8TlYnRblyaNUE2ptaLDzkOoXlopaD4qC8VTiVYh/iUbrdSJ Fp3M3vuvPtPIWQV/Hz+KWNLxB8jMJSZf0+6FxPzEv16pO8LfN7RRV2bpfV9JQl2eBTws 2q/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687339869; x=1689931869; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iUVZalfP6V27NAYz5kQTxrxcxQh7F8OqnR+1IuXKgno=; b=DaTOMGSk6WaKMnfmflxs0OmR1c7H04jqJjJjpeY/VYam+lqLfHCPLa7+o+pzps0rei CheiUZc4PlqTOoPj0Iju+p4lcnogPy0FHJ6f7vPHjojMyyCMj98hWRdaLWr8dyxd1Xqv gtXFzQ1FqPa9aCgmRAqBp6o6YInNClb03CgKiXN1lufgYrRJ9Z8Dj+4PQfC2ClKktkzr ZWu6paJuHSArmdpfB3tMjBc0ZUPCsaqhidgmAwNzQM+IIqZ+vgaURI985BQ6MQcDUJye 2FHgsoDiBVORW+Jj/OGIva7V9nIQAR0v5tTMiDnyTPSG/0YIzPeTNpCc/wleN8R89njY cSwA== X-Gm-Message-State: AC+VfDxekIfQirWz3bIlbrFh8FdOnybe09OnJBtaByvxZAyBsziY+zBt rbSldhdej1pV8CwLNq3M9OsevA== X-Received: by 2002:a19:5053:0:b0:4f9:5519:78b8 with SMTP id z19-20020a195053000000b004f9551978b8mr2520136lfj.63.1687339869403; Wed, 21 Jun 2023 02:31:09 -0700 (PDT) Received: from blmsp.fritz.box ([2001:4091:a247:82fa:b762:4f68:e1ed:5041]) by smtp.gmail.com with ESMTPSA id t10-20020a5d49ca000000b002fe96f0b3acsm3977344wrs.63.2023.06.21.02.31.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 02:31:08 -0700 (PDT) From: Markus Schneider-Pargmann <msp@baylibre.com> To: Wolfgang Grandegger <wg@grandegger.com>, Marc Kleine-Budde <mkl@pengutronix.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Conor Dooley <conor+dt@kernel.org>, Chandrasekar Ramakrishnan <rcsekar@samsung.com>, Michal Kubiak <michal.kubiak@intel.com>, Vivek Yadav <vivek.2311@samsung.com>, linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Simon Horman <simon.horman@corigine.com>, Markus Schneider-Pargmann <msp@baylibre.com> Subject: [PATCH v2 1/6] dt-bindings: can: tcan4x5x: Add tcan4552 and tcan4553 variants Date: Wed, 21 Jun 2023 11:30:58 +0200 Message-Id: <20230621093103.3134655-2-msp@baylibre.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230621093103.3134655-1-msp@baylibre.com> References: <20230621093103.3134655-1-msp@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769305256858835475?= X-GMAIL-MSGID: =?utf-8?q?1769305256858835475?= |
Series |
can: tcan4x5x: Introduce tcan4552/4553
|
|
Commit Message
Markus Schneider-Pargmann
June 21, 2023, 9:30 a.m. UTC
These two new chips do not have state or wake pins.
Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
---
.../devicetree/bindings/net/can/tcan4x5x.txt | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
Comments
On 21/06/2023 11:30, Markus Schneider-Pargmann wrote: > These two new chips do not have state or wake pins. > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> > --- > .../devicetree/bindings/net/can/tcan4x5x.txt | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt > index e3501bfa22e9..170e23f0610d 100644 > --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt > +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt > @@ -4,7 +4,10 @@ Texas Instruments TCAN4x5x CAN Controller > This file provides device node information for the TCAN4x5x interface contains. > > Required properties: > - - compatible: "ti,tcan4x5x" > + - compatible: > + "ti,tcan4552", "ti,tcan4x5x" > + "ti,tcan4553", "ti,tcan4x5x" or > + "ti,tcan4x5x" One more example why wildcards are not allowed. Ehh, Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 21/06/2023 11:30, Markus Schneider-Pargmann wrote: > These two new chips do not have state or wake pins. > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> BTW, why did you ignore the tag? This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
Hi Krzysztof, On Wed, Jun 21, 2023 at 12:29:40PM +0200, Krzysztof Kozlowski wrote: > On 21/06/2023 11:30, Markus Schneider-Pargmann wrote: > > These two new chips do not have state or wake pins. > > > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> > > BTW, why did you ignore the tag? Thanks for your Acked-by. I did not add it from v1 because: - We had a long discussion after you sent your tag - I changed the binding documentation according to the discussion on v1 as stated in the cover letter: "- Update the binding documentation to specify tcan4552 and tcan4553 with the tcan4x5x as fallback" Thanks, Markus
diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt index e3501bfa22e9..170e23f0610d 100644 --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt @@ -4,7 +4,10 @@ Texas Instruments TCAN4x5x CAN Controller This file provides device node information for the TCAN4x5x interface contains. Required properties: - - compatible: "ti,tcan4x5x" + - compatible: + "ti,tcan4552", "ti,tcan4x5x" + "ti,tcan4553", "ti,tcan4x5x" or + "ti,tcan4x5x" - reg: 0 - #address-cells: 1 - #size-cells: 0 @@ -21,8 +24,10 @@ Optional properties: - reset-gpios: Hardwired output GPIO. If not defined then software reset. - device-state-gpios: Input GPIO that indicates if the device is in - a sleep state or if the device is active. - - device-wake-gpios: Wake up GPIO to wake up the TCAN device. + a sleep state or if the device is active. Not + available with tcan4552/4553. + - device-wake-gpios: Wake up GPIO to wake up the TCAN device. Not + available with tcan4552/4553. Example: tcan4x5x: tcan4x5x@0 {