| Message ID | 20230620203915.141337-1-quic_bjorande@quicinc.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3943842vqr;
Tue, 20 Jun 2023 14:17:08 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ6X+jgM9zYNe3Zrp9HimqBrDlt2kpLtyCI+WRPIL7/2iVGW/5JaPq0gYeTcoYe82TGGdRpD
X-Received: by 2002:a05:6808:2a55:b0:39e:c4d7:655c with SMTP id
fa21-20020a0568082a5500b0039ec4d7655cmr10193452oib.4.1687295828111;
Tue, 20 Jun 2023 14:17:08 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1687295828; cv=none;
d=google.com; s=arc-20160816;
b=oT8e0Km+UcxULqT9SP9aZ2l1ab6BLg6xAGtCcHW/EUTXfTQ3pYODFGIJPMxmUQqT4F
A8wFqAUWHqEMWFic9H972WsnqbTI4HjADuGymNLun1g3WwFLy7y+O12BpbE9RXiiLOoM
F+cJbxE6rgJ7xVII+X1vUG+lErRBslpa+ivZzY6PowG1AIAJERxoC0kQ2mtYTKJpcU9Y
Cb753SeNY/mR954gCgqXAunndABAx1OPhd9CnABNlPyZNS5+wR24lB5vubKoGjILuG1a
1XfJGQX0+DyLbmpavd2zXWERgt+fKoD5p3dcZHMmcU6Vhqy/swImh9dE8NBRTOs+S6rs
ropg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=/GBt3/0+glJfPRKq9iSw/9YV3FQYo7+Ct/jAtWoWEik=;
b=CT3QlJTCsB54tC96iJPhFa3Spkc0o0vaNEG1RyfaY7a5MSB26+xs8VGDjA4yMKh4ma
pNCkTAMm8nWOn9iT8YSWSIzPj26vpb4jVfY7YMSn2vFQCqbDrajc5QPl+N7Imv3boIMm
ArVz/2i7uKsytPDyqeWwl8ei3+gTNR15FvK/yXceha4XMA4DUAxl2vgVgSLkGC0dGRf3
HtqqJWcBAt60yUepUr7pWAVH5mqEHFB3XILMuDStIs4Pw7wYte/mDoqTdSxI1YGIB75J
mVKAcXZ5R7Bf2kSwL9KcxdSPsCqiGLm5u/Aqmaiwae5hH8zZc5L6HRkLwtHtwe6Jbc/A
BMBw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="K/8GWu7V";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
24-20020a631258000000b0051b65f4d94asi1871987pgs.484.2023.06.20.14.16.51;
Tue, 20 Jun 2023 14:17:08 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="K/8GWu7V";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229818AbjFTUj0 (ORCPT <rfc822;maxin.john@gmail.com> + 99 others);
Tue, 20 Jun 2023 16:39:26 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37552 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229479AbjFTUjZ (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 20 Jun 2023 16:39:25 -0400
Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com
[205.220.168.131])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDF8A1706;
Tue, 20 Jun 2023 13:39:24 -0700 (PDT)
Received: from pps.filterd (m0279863.ppops.net [127.0.0.1])
by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
35KJdfNY006188;
Tue, 20 Jun 2023 20:39:22 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com;
h=from : to : cc :
subject : date : message-id : mime-version : content-transfer-encoding :
content-type; s=qcppdkim1;
bh=/GBt3/0+glJfPRKq9iSw/9YV3FQYo7+Ct/jAtWoWEik=;
b=K/8GWu7VTRgghPTyKhSrsk2ApOop3Vxdawo+MZYmxvTAit2KEkNa1JbgvpxqlhCtKr40
ad6kqjJWD0z4Gq4eGtfv3nOhYVbQM/uvM+hNMoQOkF8eHVMPoL2ZxMXsXb2oJZeLLeqB
pJIPU4Hse1M7hbAK4ZZlUK8IxAVG9a6GhFCTSFo8026JSEJ2FDHXs47OrlW82lttqi6o
OK5UY3qpSETh2F+mXQ87yz60MapB/4ES063bmrM/ftcwnSN9jz7WAncAAKEIbXA6Me00
mLLAvdukvuWbF+liqBLq5gIOyfp1lFoqP+xzexgXxdp/V7T/b4Zq6FmG4aKFjcP1932W Pw==
Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com
[129.46.96.20])
by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ramke3q5j-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Tue, 20 Jun 2023 20:39:21 +0000
Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com
[10.47.97.35])
by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id
35KKdKp7024380
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Tue, 20 Jun 2023 20:39:20 GMT
Received: from hu-bjorande-lv.qualcomm.com (10.49.16.6) by
nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.986.42; Tue, 20 Jun 2023 13:39:20 -0700
From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>
CC: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] arm64: dts: qcom: sc8280xp-crd: Correct vreg_misc_3p3
GPIO
Date: Tue, 20 Jun 2023 13:39:14 -0700
Message-ID: <20230620203915.141337-1-quic_bjorande@quicinc.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [10.49.16.6]
X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To
nalasex01c.na.qualcomm.com (10.47.97.35)
X-QCInternal: smtphost
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
signatures=585085
X-Proofpoint-ORIG-GUID: yJhdOd7C-or8mrAhqBdCRn1bMT3Vo9C_
X-Proofpoint-GUID: yJhdOd7C-or8mrAhqBdCRn1bMT3Vo9C_
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
definitions=2023-06-20_16,2023-06-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
malwarescore=0 phishscore=0
clxscore=1015 mlxscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0
priorityscore=1501 impostorscore=0 mlxlogscore=911 adultscore=0
suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2305260000 definitions=main-2306200187
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1769257910530593206?=
X-GMAIL-MSGID: =?utf-8?q?1769257910530593206?=
|
| Series |
[1/2] arm64: dts: qcom: sc8280xp-crd: Correct vreg_misc_3p3 GPIO
|
|
Commit Message
Bjorn Andersson
June 20, 2023, 8:39 p.m. UTC
The vreg_misc_3p3 regulator is controlled by PMC8280_1 GPIO 2, not 1, on
the CRD.
Fixes: ccd3517faf18 ("arm64: dts: qcom: sc8280xp: Add reference device")
Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 20.06.2023 22:39, Bjorn Andersson wrote: > The vreg_misc_3p3 regulator is controlled by PMC8280_1 GPIO 2, not 1, on > the CRD. > > Fixes: ccd3517faf18 ("arm64: dts: qcom: sc8280xp: Add reference device") > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > index b566e403d1db..b21b41a066b6 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > @@ -167,7 +167,7 @@ vreg_misc_3p3: regulator-misc-3p3 { > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > > - gpio = <&pmc8280_1_gpios 1 GPIO_ACTIVE_HIGH>; > + gpio = <&pmc8280_1_gpios 2 GPIO_ACTIVE_HIGH>; > enable-active-high; > > pinctrl-names = "default"; > @@ -757,7 +757,7 @@ edp_bl_reg_en: edp-bl-reg-en-state { > }; > > misc_3p3_reg_en: misc-3p3-reg-en-state { > - pins = "gpio1"; > + pins = "gpio2"; > function = "normal"; > }; > };
On Tue, Jun 20, 2023 at 01:39:14PM -0700, Bjorn Andersson wrote: > The vreg_misc_3p3 regulator is controlled by PMC8280_1 GPIO 2, not 1, on > the CRD. > > Fixes: ccd3517faf18 ("arm64: dts: qcom: sc8280xp: Add reference device") > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> The old off-by-one again. Both of these are apparently configured as outputs and driven high by the boot firmware. Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Johan
On Tue, 20 Jun 2023 13:39:14 -0700, Bjorn Andersson wrote: > The vreg_misc_3p3 regulator is controlled by PMC8280_1 GPIO 2, not 1, on > the CRD. > > Applied, thanks! [1/2] arm64: dts: qcom: sc8280xp-crd: Correct vreg_misc_3p3 GPIO commit: 9566b5271f68bdf6e69b7c511850e3fb75cd18be [2/2] arm64: dts: qcom: sc8280xp-crd: Fix naming of regulators commit: 8882ae076344f8b4e9f1e5a116e1a83c4292b790 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts index b566e403d1db..b21b41a066b6 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts @@ -167,7 +167,7 @@ vreg_misc_3p3: regulator-misc-3p3 { regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; - gpio = <&pmc8280_1_gpios 1 GPIO_ACTIVE_HIGH>; + gpio = <&pmc8280_1_gpios 2 GPIO_ACTIVE_HIGH>; enable-active-high; pinctrl-names = "default"; @@ -757,7 +757,7 @@ edp_bl_reg_en: edp-bl-reg-en-state { }; misc_3p3_reg_en: misc-3p3-reg-en-state { - pins = "gpio1"; + pins = "gpio2"; function = "normal"; }; };