Message ID | 20230620170159.556788-1-william.gray@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3824929vqr; Tue, 20 Jun 2023 10:27:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7zClf41H5o+8L1YtoQhKMBfuCDGJN84PaMiHMuDBR41B4/49xnDBcZJC2asZS1+8y1wvJq X-Received: by 2002:a17:902:d506:b0:1b6:6c32:59b3 with SMTP id b6-20020a170902d50600b001b66c3259b3mr6812126plg.19.1687282076254; Tue, 20 Jun 2023 10:27:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687282076; cv=none; d=google.com; s=arc-20160816; b=YwCNWd6i0OEUgcto7YVdLwS6tDOyGwysER9yuSGlAb299+QwQnObyK6nawZMaqujyl 9/NB+ZakB5OoTUEsquZTycELG4JNuO8XPPgCqX84taE4JbH9LvWKHru70YjGXnVV5SRL 4me+dtyQCDoZXcIfTU+zW1UoJDOW8PYILjV7Y8TG4wWULiE99s3hfjC8zw1Sa5dYsxUT tsPy7KJDXMQUqRaIbhYf/1jWy0o4ULIBjnnptbBNqASLe+95F3E+bHdqbe/CBG8dsuhF uDzMUkTeKcCAdx1JT/ra+vGlOm4x7l5WIlynNdqA41q/u486OUTTLQpiOQLD6la1FppL IYAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=FlKmKVASdoZBr1V8sa5UPB3N4JwT5N5y08CJyYmSlmQ=; b=U+fFm5Ywop3q7CgZUuxPolqpyz6WsLgcsinx4a5nWIsCrtDeu1YN99RDq9oEPt+rRD nZJxmJvKsRjPMQUDF2ac1XhQEAcx3j1hFqa19A1+jWD+wfqJvs8ZE1gMPfIDkMfhAZcr WCLXOixRZSdBV5fRC+zeMlqoBO7pmVxxUJJTv5EWrX9JcTD+PjRQy9Gwl++86VQgaYkY gRKdb+TJOO5VFY/NSjgEK1QixLttzorf32BJBYJWhH0mk2NOTrRud3zVoXSsybgJfTUp H36LARd/NIyoVUd3tc3fAss2Qu4O/8ZyiE5zf5ark2zWSHKu9aZg5LakYNrUPkFd5VJ5 f/VA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AygIvD2B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u18-20020a170902e81200b001b5219acbbfsi1737082plg.359.2023.06.20.10.27.41; Tue, 20 Jun 2023 10:27:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AygIvD2B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229927AbjFTRCZ (ORCPT <rfc822;maxin.john@gmail.com> + 99 others); Tue, 20 Jun 2023 13:02:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229909AbjFTRCW (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 20 Jun 2023 13:02:22 -0400 Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 684971726 for <linux-kernel@vger.kernel.org>; Tue, 20 Jun 2023 10:02:20 -0700 (PDT) Received: by mail-vs1-xe32.google.com with SMTP id ada2fe7eead31-440cff7870aso33837137.1 for <linux-kernel@vger.kernel.org>; Tue, 20 Jun 2023 10:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687280539; x=1689872539; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FlKmKVASdoZBr1V8sa5UPB3N4JwT5N5y08CJyYmSlmQ=; b=AygIvD2BOhImFB/UVypf6X4G6GBMKpKO89PyQaoELZe22PSId1ZX1gziEbTqJo4lxc al5QT0WD37lt16pJ5t8oKQxmajy2ug9vIyFbmxh3QQqusyt9Y+LxjxJrlNKEDzQAEsLR NUYQ9cpayZMRZBQJr8YaYCzs2TZwKsrU5j6gwxUm0I7didfoXxlt2hBv90OOad0zAqY1 k5uG2eJVbLJLmaIagq5DrM10ZYLp4LF3TuByqzjo4sBB1Hrih4VPW29rZLB857cxH6By EUeCuimjl93XkTAi8+SB5dIBroYJkfY1yUReIC9AxP3WDb6maLi+yFGqWtsJgzruVHv9 a+sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687280539; x=1689872539; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FlKmKVASdoZBr1V8sa5UPB3N4JwT5N5y08CJyYmSlmQ=; b=NQl9ydwRhNTfXATSqUfZnrlyE9VSUbrPzQHMCVXe+LSGjvclMds/cvoHuVK0NGSKbR nqmEQvuxHktr1+vJ/+asP5JwWjIxU1oRQJmdqO0PmBfOHSo2VzuWYUZOMqeSvifXnrbk KWAFhLb5lVhJA6+cXZRjpIQfMrlS7W/thLIg3/Cq1aI+rZEl6pYQ4zWt+Yu9MfM+Sqay C5REPy1vsYXDsIPtA4wbu6X0idMImSO12AbuXEPEzgnlZdRqDI48/Jht9RvV1o3jL7Bn inFLXMkf3yr42qiWV40LPsfJjIrAQC5aq0mEK7Rra8Uf8EQFJbiZc6KcoMlEaMl67adD Aq2g== X-Gm-Message-State: AC+VfDy2/x7mI31p2iYVIFB196Wha63xoUt6bw8iJZvDIzTCNyPuzAhQ Eagd0pymx4kXBfSOtEAOa9F+WA== X-Received: by 2002:a05:6102:1624:b0:43b:2d20:f364 with SMTP id cu36-20020a056102162400b0043b2d20f364mr3455693vsb.7.1687280539358; Tue, 20 Jun 2023 10:02:19 -0700 (PDT) Received: from fedora.. (072-189-067-006.res.spectrum.com. [72.189.67.6]) by smtp.gmail.com with ESMTPSA id n24-20020a9f3158000000b00789a6c15851sm358865uab.13.2023.06.20.10.02.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 10:02:18 -0700 (PDT) From: William Breathitt Gray <william.gray@linaro.org> To: linux-iio@vger.kernel.org, Jarkko Nikula <jarkko.nikula@linux.intel.com>, Jonathan Cameron <jic23@kernel.org>, Bartosz Golaszewski <brgl@bgdev.pl> Cc: Linus Walleij <linus.walleij@linaro.org>, Lars-Peter Clausen <lars@metafoo.de>, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, andy.shevchenko@gmail.com, William Breathitt Gray <william.gray@linaro.org> Subject: [PATCH] counter: Fix menuconfig "Counter support" submenu entries disappearance Date: Tue, 20 Jun 2023 13:01:59 -0400 Message-Id: <20230620170159.556788-1-william.gray@linaro.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769243490529587651?= X-GMAIL-MSGID: =?utf-8?q?1769243490529587651?= |
Series |
counter: Fix menuconfig "Counter support" submenu entries disappearance
|
|
Commit Message
William Breathitt Gray
June 20, 2023, 5:01 p.m. UTC
The current placement of the I8254 Kconfig entry results in the
disappearance of the "Counter support" submenu items in menuconfig. Move
the I8254 above the menuconfig COUNTER entry to restore the intended
submenu behavior.
Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")
Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/
Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
---
drivers/counter/Kconfig | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
base-commit: d428487471ba6640ee8bcdabaf830aec08b85400
Comments
Hi, On 6/20/23 10:01, William Breathitt Gray wrote: > The current placement of the I8254 Kconfig entry results in the > disappearance of the "Counter support" submenu items in menuconfig. Move > the I8254 above the menuconfig COUNTER entry to restore the intended > submenu behavior. > > Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module") > Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/ > Signed-off-by: William Breathitt Gray <william.gray@linaro.org> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> but why is I8254 here at all? Users cannot enable it and nothing selects it. Is it a WIP? Thanks. > --- > drivers/counter/Kconfig | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig > index a61a4b9b8ec6..86536c2cc531 100644 > --- a/drivers/counter/Kconfig > +++ b/drivers/counter/Kconfig > @@ -3,13 +3,6 @@ > # Counter devices > # > > -menuconfig COUNTER > - tristate "Counter support" > - help > - This enables counter device support through the Generic Counter > - interface. You only need to enable this, if you also want to enable > - one or more of the counter device drivers below. > - > config I8254 > tristate > select COUNTER > @@ -25,6 +18,13 @@ config I8254 > > If built as a module its name will be i8254. > > +menuconfig COUNTER > + tristate "Counter support" > + help > + This enables counter device support through the Generic Counter > + interface. You only need to enable this, if you also want to enable > + one or more of the counter device drivers below. > + > if COUNTER > > config 104_QUAD_8 > > base-commit: d428487471ba6640ee8bcdabaf830aec08b85400
On Tue, Jun 20, 2023 at 02:00:37PM -0700, Randy Dunlap wrote: > Hi, > > On 6/20/23 10:01, William Breathitt Gray wrote: > > The current placement of the I8254 Kconfig entry results in the > > disappearance of the "Counter support" submenu items in menuconfig. Move > > the I8254 above the menuconfig COUNTER entry to restore the intended > > submenu behavior. > > > > Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module") > > Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > > Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/ > > Signed-off-by: William Breathitt Gray <william.gray@linaro.org> > > Reviewed-by: Randy Dunlap <rdunlap@infradead.org> > > but why is I8254 here at all? Users cannot enable it > and nothing selects it. Is it a WIP? > > Thanks. There are pending patches for two drivers to use it: 104-dio-48e[^1] and stx104[^2]. Those will be picked up in their respective subsystem trees (by Bart and Jonathan I presume). William Breathitt Gray [^1]: https://lore.kernel.org/all/dc4d0d5ca6ea28eda18815df114ecb21226cb345.1681665189.git.william.gray@linaro.org/ [^2]: https://lore.kernel.org/all/45d35b6f6e8d51df788b2bc85c456bfd45476b1a.1681665189.git.william.gray@linaro.org/
On 6/21/23 00:12, William Breathitt Gray wrote: > On Tue, Jun 20, 2023 at 02:00:37PM -0700, Randy Dunlap wrote: >> Hi, >> >> On 6/20/23 10:01, William Breathitt Gray wrote: >>> The current placement of the I8254 Kconfig entry results in the >>> disappearance of the "Counter support" submenu items in menuconfig. Move >>> the I8254 above the menuconfig COUNTER entry to restore the intended >>> submenu behavior. >>> >>> Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module") >>> Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> >>> Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/ >>> Signed-off-by: William Breathitt Gray <william.gray@linaro.org> >> >> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> >> Thanks, this fixes it. Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
On Tue, Jun 20, 2023 at 01:01:59PM -0400, William Breathitt Gray wrote: > The current placement of the I8254 Kconfig entry results in the > disappearance of the "Counter support" submenu items in menuconfig. Move > the I8254 above the menuconfig COUNTER entry to restore the intended > submenu behavior. > > Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module") > Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/ > Signed-off-by: William Breathitt Gray <william.gray@linaro.org> Applied to counter-current. William Breathitt Gray
On Tue, 20 Jun 2023 17:12:13 -0400 William Breathitt Gray <william.gray@linaro.org> wrote: > On Tue, Jun 20, 2023 at 02:00:37PM -0700, Randy Dunlap wrote: > > Hi, > > > > On 6/20/23 10:01, William Breathitt Gray wrote: > > > The current placement of the I8254 Kconfig entry results in the > > > disappearance of the "Counter support" submenu items in menuconfig. Move > > > the I8254 above the menuconfig COUNTER entry to restore the intended > > > submenu behavior. > > > > > > Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module") > > > Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > > > Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/ > > > Signed-off-by: William Breathitt Gray <william.gray@linaro.org> > > > > Reviewed-by: Randy Dunlap <rdunlap@infradead.org> > > > > but why is I8254 here at all? Users cannot enable it > > and nothing selects it. Is it a WIP? > > > > Thanks. > > There are pending patches for two drivers to use it: 104-dio-48e[^1] and > stx104[^2]. Those will be picked up in their respective subsystem trees > (by Bart and Jonathan I presume). > I missed the IIO patch in that series. Could you resend please. Jonathan > William Breathitt Gray > > [^1]: https://lore.kernel.org/all/dc4d0d5ca6ea28eda18815df114ecb21226cb345.1681665189.git.william.gray@linaro.org/ > [^2]: https://lore.kernel.org/all/45d35b6f6e8d51df788b2bc85c456bfd45476b1a.1681665189.git.william.gray@linaro.org/
On Sun, Jun 25, 2023 at 12:11:08PM +0100, Jonathan Cameron wrote: > On Tue, 20 Jun 2023 17:12:13 -0400 > William Breathitt Gray <william.gray@linaro.org> wrote: > > > On Tue, Jun 20, 2023 at 02:00:37PM -0700, Randy Dunlap wrote: > > > Hi, > > > > > > On 6/20/23 10:01, William Breathitt Gray wrote: > > > > The current placement of the I8254 Kconfig entry results in the > > > > disappearance of the "Counter support" submenu items in menuconfig. Move > > > > the I8254 above the menuconfig COUNTER entry to restore the intended > > > > submenu behavior. > > > > > > > > Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module") > > > > Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > > > > Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/ > > > > Signed-off-by: William Breathitt Gray <william.gray@linaro.org> > > > > > > Reviewed-by: Randy Dunlap <rdunlap@infradead.org> > > > > > > but why is I8254 here at all? Users cannot enable it > > > and nothing selects it. Is it a WIP? > > > > > > Thanks. > > > > There are pending patches for two drivers to use it: 104-dio-48e[^1] and > > stx104[^2]. Those will be picked up in their respective subsystem trees > > (by Bart and Jonathan I presume). > > > > I missed the IIO patch in that series. Could you resend please. > > Jonathan > > > William Breathitt Gray > > > > [^1]: https://lore.kernel.org/all/dc4d0d5ca6ea28eda18815df114ecb21226cb345.1681665189.git.william.gray@linaro.org/ > > [^2]: https://lore.kernel.org/all/45d35b6f6e8d51df788b2bc85c456bfd45476b1a.1681665189.git.william.gray@linaro.org/ I8254 is expected to land in 6.5 so I'll wait and resend the IIO patch rebased on 6.5-rc1 once it's released in a couple weeks. That'll make things simple for you and avoid the need for an immutable branch. William Breathitt Gray
diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig index a61a4b9b8ec6..86536c2cc531 100644 --- a/drivers/counter/Kconfig +++ b/drivers/counter/Kconfig @@ -3,13 +3,6 @@ # Counter devices # -menuconfig COUNTER - tristate "Counter support" - help - This enables counter device support through the Generic Counter - interface. You only need to enable this, if you also want to enable - one or more of the counter device drivers below. - config I8254 tristate select COUNTER @@ -25,6 +18,13 @@ config I8254 If built as a module its name will be i8254. +menuconfig COUNTER + tristate "Counter support" + help + This enables counter device support through the Generic Counter + interface. You only need to enable this, if you also want to enable + one or more of the counter device drivers below. + if COUNTER config 104_QUAD_8