From patchwork Tue Jun 20 02:56:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luke Jones X-Patchwork-Id: 110240 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3390597vqr; Mon, 19 Jun 2023 20:10:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4R7z/bfMEYd/JpRlydY1tSh/5whA6zaLh4BUBENXoG3zLLMpv9BK6Xx9DcA/dyZEOLYz2X X-Received: by 2002:a17:90a:9bc6:b0:25e:abc1:6fd7 with SMTP id b6-20020a17090a9bc600b0025eabc16fd7mr15176537pjw.12.1687230629885; Mon, 19 Jun 2023 20:10:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687230629; cv=none; d=google.com; s=arc-20160816; b=mda3REftvLIVEzCmRExXGQk07Sz+Qang6UXMXQRWkpDlcAxFNis1iUUipuFwTLcNsN Bt3BEli/VZrpak9lmMEW57HScQEzHmmBiiN1scQ1DGO7/AGUY+d8li1sN4ft6UA7IWjO 5LRWHTXdtT1URjRWF89ql5eTSuSYRdapVW9ljy2ixXQ4r8i30lMBrt7f8tMUrFl8LYza ZzXFTUdroDtgZvdOusx42tHuGk6cNn6UTUup537xL8W8IUcdgsa7Qjsiqc9FDoT75g9b BROHJpooZ/MgC+EENJAER+DyNCZrMNVykKXCAB5gTrraVINxZBhzlrmEYVps2swEz9N7 UANg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :feedback-id:dkim-signature:dkim-signature; bh=XyYZavQtwXjIJqr+Wx4YS9kbDJ4aeW/qdYMdNX69/gU=; b=dn+Z53ftTr9SK+FlEgV2P43KObJt6k5X/JpzQlWvF9MH0fANVlD530r3ZdfvlxCEAb 5etOJ5fxHIVvfKWkVyDKoNKRyYi7+G/Iixt7YHl0j046NnzUbOhEqWgQloSBjV2IYVgc 1+g0JzRQQpMIXfh6qyY/BOcvB0obmMcsB8FyBZa7qD4n7c20/5pYVIYyFdq6P7uFhKEk gb44ah+qlYIlalX3DpIjBEdEC/XQgzaU1ZXcw45oaCYpcsGVpH6WCitJoVVDI5PnG/9G 67eK4zXUI4w0esYuG1YwtnCjrw2w8B8I9iDgh3sSCCkFAINTYBVsBCphkkpflxtu2PC3 TPLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ljones.dev header.s=fm3 header.b=GSF7Y3ah; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=ER7NpZCY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u7-20020a17090ae00700b0025bf848104fsi8376968pjy.155.2023.06.19.20.10.15; Mon, 19 Jun 2023 20:10:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ljones.dev header.s=fm3 header.b=GSF7Y3ah; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=ER7NpZCY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229710AbjFTC56 (ORCPT + 99 others); Mon, 19 Jun 2023 22:57:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230125AbjFTC5u (ORCPT ); Mon, 19 Jun 2023 22:57:50 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50B7A1994; Mon, 19 Jun 2023 19:57:31 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 6A0AA5C01F5; Mon, 19 Jun 2023 22:57:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 19 Jun 2023 22:57:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1687229850; x= 1687316250; bh=XyYZavQtwXjIJqr+Wx4YS9kbDJ4aeW/qdYMdNX69/gU=; b=G SF7Y3ahXA2YOb5KxbzirV312WbXX1deQzuyBAx80rTDQrSMYJblueSoN1tqTDDud 7dvhBMRof5umexvpQnl6B/aokr442nqEOyPnngmgDQNNGSN73PRBNUNkRVB+HIU8 TovT5nznPeMZJz3ZCnxhe/H1DQUgxkiNNV6ga6qyof+aT5ZrmxxV6D3GGDzAe6HF Tq0LF5e/dWjPiNbX3vGfD5RNT4X7B0Xd55xHJtACwKSm90TBgCRbOv4bgqxHV+b6 F9IchEknaqHlQzyCrzSoD68rADPJTfoDnH8LsZS6aVCUu7+dPh0KpuNSRX4SYyUI see9ZrGODS08j4Ch3yF+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1687229850; x= 1687316250; bh=XyYZavQtwXjIJqr+Wx4YS9kbDJ4aeW/qdYMdNX69/gU=; b=E R7NpZCYr9WzpS7ise/LsXSlBKFqMaKGpLSo8tUzqdKLe6qgyR2jFbWRKQY22P+O+ I04hjaRokXdt8YuxsSPyYavxUoJryADbrnYrP5rvCrxIBsm2b3Vvlc8OP/PJl6i+ DFdtD96sCCZf9+Ob+azTMkq+spYRpTMAsR8vo7NzslW7S1AhWkc2LEdBjFdTv98C M+QzjEw8qnxJ0UfJy/6/9YiOClCr1/Hsbn5CV5+NXy+vTMRTy0U7i7a43ye7FvST WHj5JCLML8Z61Dw9LRTIFq8SuRq9Q9JxpmLxcYyW+7Ja+WxTH5vuMcxkCzfyx/Oi 12EWGSS+348ydusXAWpLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeefgedgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpedfnfhukhgvucffrdculfhonhgvshdfuceolhhukhgvsehl jhhonhgvshdruggvvheqnecuggftrfgrthhtvghrnhepgfetfedugfetudeuheetjefhue fggfelleetvdevtefhueeujeefvdegleevhefgnecuvehluhhsthgvrhfuihiivgepuden ucfrrghrrghmpehmrghilhhfrhhomheplhhukhgvsehljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Jun 2023 22:57:27 -0400 (EDT) From: "Luke D. Jones" To: hdegoede@redhat.com Cc: corentin.chary@gmail.com, acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, markgross@kernel.org, jdelvare@suse.com, linux@roeck-us.net, "Luke D. Jones" Subject: [PATCH 7/8] platform/x86: asus-wmi: support setting mini-LED mode Date: Tue, 20 Jun 2023 14:56:40 +1200 Message-Id: <20230620025641.53197-8-luke@ljones.dev> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230620025641.53197-1-luke@ljones.dev> References: <20230620025641.53197-1-luke@ljones.dev> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769189544753315104?= X-GMAIL-MSGID: =?utf-8?q?1769189544753315104?= Support changing the mini-LED mode on some of the newer ASUS laptops. Signed-off-by: Luke D. Jones --- .../ABI/testing/sysfs-platform-asus-wmi | 9 ++++ drivers/platform/x86/asus-wmi.c | 53 +++++++++++++++++++ include/linux/platform_data/x86/asus-wmi.h | 1 + 3 files changed, 63 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi b/Documentation/ABI/testing/sysfs-platform-asus-wmi index 878daf7c2036..5624bdef49cb 100644 --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi @@ -117,3 +117,12 @@ Description: Show if the egpu (XG Mobile) is correctly connected: * 0 - False, * 1 - True + +What: /sys/devices/platform//mini_led_mode +Date: Jun 2023 +KernelVersion: 6.5 +Contact: "Luke Jones" +Description: + Change the mini-LED mode: + * 0 - Single-zone, + * 1 - Multi-zone diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index 602426a7fb41..1fc9e8afc2f3 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -265,6 +265,7 @@ struct asus_wmi { bool battery_rsoc_available; bool panel_overdrive_available; + bool mini_led_mode_available; struct hotplug_slot hotplug_slot; struct mutex hotplug_lock; @@ -1820,6 +1821,54 @@ static ssize_t panel_od_store(struct device *dev, } static DEVICE_ATTR_RW(panel_od); +/* Mini-LED mode **************************************************************/ +static ssize_t mini_led_mode_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct asus_wmi *asus = dev_get_drvdata(dev); + int result; + + result = asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_MINI_LED_MODE); + if (result < 0) + return result; + + return sysfs_emit(buf, "%d\n", result); +} + +static ssize_t mini_led_mode_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + int result, err; + u32 mode; + + struct asus_wmi *asus = dev_get_drvdata(dev); + + result = kstrtou32(buf, 10, &mode); + if (result) + return result; + + if (mode > 1) + return -EINVAL; + + err = asus_wmi_set_devstate(ASUS_WMI_DEVID_MINI_LED_MODE, mode, &result); + + if (err) { + pr_warn("Failed to set mini-LED: %d\n", err); + return err; + } + + if (result > 1) { + pr_warn("Failed to set mini-LED mode (result): 0x%x\n", result); + return -EIO; + } + + sysfs_notify(&asus->platform_device->dev.kobj, NULL, "mini_led_mode"); + + return count; +} +static DEVICE_ATTR_RW(mini_led_mode); + /* Quirks *********************************************************************/ static void asus_wmi_set_xusb2pr(struct asus_wmi *asus) @@ -3727,6 +3776,7 @@ static struct attribute *platform_attributes[] = { &dev_attr_fan_boost_mode.attr, &dev_attr_throttle_thermal_policy.attr, &dev_attr_panel_od.attr, + &dev_attr_mini_led_mode.attr, NULL }; @@ -3764,6 +3814,8 @@ static umode_t asus_sysfs_is_visible(struct kobject *kobj, ok = asus->throttle_thermal_policy_available; else if (attr == &dev_attr_panel_od.attr) ok = asus->panel_overdrive_available; + else if (attr == &dev_attr_mini_led_mode.attr) + ok = asus->mini_led_mode_available; if (devid != -1) ok = !(asus_wmi_get_devstate_simple(asus, devid) < 0); @@ -4026,6 +4078,7 @@ static int asus_wmi_add(struct platform_device *pdev) asus->kbd_rgb_mode_available = asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_TUF_RGB_MODE); asus->kbd_rgb_state_available = asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_TUF_RGB_STATE); asus->panel_overdrive_available = asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_PANEL_OD); + asus->mini_led_mode_available = asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MINI_LED_MODE); err = fan_boost_mode_check_present(asus); if (err) diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h index 2034648f8cdf..ea80361ac6c7 100644 --- a/include/linux/platform_data/x86/asus-wmi.h +++ b/include/linux/platform_data/x86/asus-wmi.h @@ -66,6 +66,7 @@ #define ASUS_WMI_DEVID_CAMERA 0x00060013 #define ASUS_WMI_DEVID_LID_FLIP 0x00060062 #define ASUS_WMI_DEVID_LID_FLIP_ROG 0x00060077 +#define ASUS_WMI_DEVID_MINI_LED_MODE 0x0005001E /* Storage */ #define ASUS_WMI_DEVID_CARDREADER 0x00080013