From patchwork Mon Jun 19 09:12:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 109854 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2873048vqr; Mon, 19 Jun 2023 02:32:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ42Vhx3vJmYjroVApVvrHD5h5TzgDWl7LxrNRHr0hvx/vVmx4p8IzIjbE6rwHJQY2XOeRms X-Received: by 2002:a17:902:f688:b0:1ac:8be5:8787 with SMTP id l8-20020a170902f68800b001ac8be58787mr5085361plg.21.1687167160384; Mon, 19 Jun 2023 02:32:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687167160; cv=none; d=google.com; s=arc-20160816; b=obiqw8pzw+MiCMehqGZWTtUcZtN3L9Q6jkyuXt0wcb4h/YSJHlxQKr4i2fsiEQlYEh EkGn8GtiozjVM+QwIpnqaZHiWKd41RSfVOrsIa9lpMv//7l+whRZz9VazREnTEkFF/C4 uggqCx0iZAsWWGDRTBDRWpR7vtz/OAE58Dae5TgVBZZStoQ947LJYlMk1dXIFs9rYBFG a3+hWPytiXvaMgA3XqL7FRJJdbbBx4Y0m7VSmG4tCvLls2sYnSlPUGPengu907sXI9oW /P8lwZIuaga98e8QgCUlYPWE9dThrXKilyxL5jWcGhC9olNV+5JmiseZG98JGOm0t7Aj ZebA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=+VIaGHEAMsS77amy4w2aMWBNS+kTc0Yx6SUw4EFYC2w=; b=VzUbk1yR9mJHIU/rFQ5p185ks7LgTjx8AMnamZHGpiJ3kt9xZ0um0A0nuMioxwI0gJ 8NDkGSeImx3anvSwvSlvGFh4WnOBADg7kvgXCwIVrVx8aUOXAxNsXK7K50mUoYobVKVN x/QflKjqA6gA/YkecZcsJX/cBQ+WLTWsKH3BBRrYfuG2/+u9NBFbLorKUbR5Sgpn+4XE 4FqXEPQ8uNYv7MxhFmrFli0L0cRiaxgmxmFlSzlU2BuPb+zY9R3k81E9ksR21W44yilF ObQi6dEh5AXTNRZTY/F/G5Ai4h5arcbaTtwjm1AwJOS6QZZwRJSzQqDVV69AcoJk4rZO +rMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QZNSuDHy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p16-20020a170902e75000b001b3f2ba0917si13122058plf.108.2023.06.19.02.32.27; Mon, 19 Jun 2023 02:32:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QZNSuDHy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229471AbjFSJM0 (ORCPT + 99 others); Mon, 19 Jun 2023 05:12:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231179AbjFSJMY (ORCPT ); Mon, 19 Jun 2023 05:12:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62CB9E0 for ; Mon, 19 Jun 2023 02:12:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E21D860B09 for ; Mon, 19 Jun 2023 09:12:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B276C433C0; Mon, 19 Jun 2023 09:12:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687165942; bh=nncO+JSw+gBGPePnGvsYe6987xslG26sNKILTCu8PE4=; h=From:To:Cc:Subject:Date:From; b=QZNSuDHyR+NEwIyN6E2jYjgAtNB48IQjhFe8x2s3pxhMNGzSGmsNTXyPd2gykDoPL sBqVtHd4Z/33TJ/t2Oywi2StoIJZh68DINrmETA5ac33mNmEexDL32E0ftRnf5EMJ5 3AX4uY5OVTCtAmN03yHzRiske2zy1xLKdXxqcd/UvzXz+ftWba/cxbedupBamO18D9 ddf27cJwmnYPVdYVCUwEttD+7fcUCo2GvFcDDfQOph48Mf61PC+oax3Uf5IVNtaBqX xIu00ZRJ83gFTBcUxDHL8wwJbAjSLEV0A97jx/PiMes/nzOy7qSINMSMa8VmzA2trP /AnnttSR2STeA== From: Arnd Bergmann To: Edward Cree , Martin Habets , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Pieter Jansen van Vuuren Cc: Arnd Bergmann , Jiri Pirko , Alejandro Lucero , netdev@vger.kernel.org, linux-net-drivers@amd.com, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] [v2] sfc: add CONFIG_INET dependency for TC offload Date: Mon, 19 Jun 2023 11:12:09 +0200 Message-Id: <20230619091215.2731541-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769122992386666174?= X-GMAIL-MSGID: =?utf-8?q?1769122992386666174?= From: Arnd Bergmann The driver now fails to link when CONFIG_INET is disabled, so add an explicit Kconfig dependency: ld.lld: error: undefined symbol: ip_route_output_flow >>> referenced by tc_encap_actions.c >>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_tc_flower_create_encap_md) in archive vmlinux.a ld.lld: error: undefined symbol: ip_send_check >>> referenced by tc_encap_actions.c >>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_gen_encap_header) in archive vmlinux.a >>> referenced by tc_encap_actions.c >>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_gen_encap_header) in archive vmlinux.a ld.lld: error: undefined symbol: arp_tbl >>> referenced by tc_encap_actions.c >>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_tc_netevent_event) in archive vmlinux.a >>> referenced by tc_encap_actions.c >>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_tc_netevent_event) in archive vmlinux.a Fixes: a1e82162af0b8 ("sfc: generate encap headers for TC offload") Reviewed-by: Edward Cree Reviewed-by: Simon Horman Closes: https://lore.kernel.org/oe-kbuild-all/202306151656.yttECVTP-lkp@intel.com/ Signed-off-by: Arnd Bergmann --- v2: add Fixes and Closes tags --- drivers/net/ethernet/sfc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/sfc/Kconfig b/drivers/net/ethernet/sfc/Kconfig index 4af36ba8906ba..3eb55dcfa8a61 100644 --- a/drivers/net/ethernet/sfc/Kconfig +++ b/drivers/net/ethernet/sfc/Kconfig @@ -50,6 +50,7 @@ config SFC_MCDI_MON config SFC_SRIOV bool "Solarflare SFC9100-family SR-IOV support" depends on SFC && PCI_IOV + depends on INET default y help This enables support for the Single Root I/O Virtualization