diff mbox series

[v14,16/18] media: i2c: ds90ub960: Allow FPD-Link async mode

Message ID 20230616135922.442979-17-tomi.valkeinen@ideasonboard.com
State New
Headers
Series i2c-atr and FPDLink |

Commit Message

Tomi Valkeinen June 16, 2023, 1:59 p.m. UTC 
  Allow using FPD-Link in async mode. The driver handles it correctly, but
the mode was blocked at probe time as there wasn't HW to test this with.
Now the mode has been tested, and it works.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
 drivers/media/i2c/ds90ub960.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andy Shevchenko June 16, 2023, 2:34 p.m. UTC | #1 
On Fri, Jun 16, 2023 at 04:59:20PM +0300, Tomi Valkeinen wrote:
> Allow using FPD-Link in async mode. The driver handles it correctly, but
> the mode was blocked at probe time as there wasn't HW to test this with.
> Now the mode has been tested, and it works.

Looks good, but I assume you will incorporate this into the original code.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tomi Valkeinen June 19, 2023, 9:04 a.m. UTC | #2 
On 16/06/2023 17:34, Andy Shevchenko wrote:
> On Fri, Jun 16, 2023 at 04:59:20PM +0300, Tomi Valkeinen wrote:
>> Allow using FPD-Link in async mode. The driver handles it correctly, but
>> the mode was blocked at probe time as there wasn't HW to test this with.
>> Now the mode has been tested, and it works.
> 
> Looks good, but I assume you will incorporate this into the original code.

Perhaps, but to be honest, I just want to get the basic set merged, as 
it's been circulating for so many years. So, as I mentioned in the 
earlier email, it was perhaps a mistake to include these additional 
changes...

If the reviews for the new commits are quick and easy, I can squash them 
and send a v15. But if there's anything that needs more discussions, I'd 
like to leave the rest for later.

  Tomi
diff mbox series

Patch

diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
index 6b70fa5bb22f..b0ffca51ee62 100644
--- a/drivers/media/i2c/ds90ub960.c
+++ b/drivers/media/i2c/ds90ub960.c
@@ -3240,7 +3240,6 @@  ub960_parse_dt_rxport_link_properties(struct ub960_data *priv,
 	switch (rx_mode) {
 	case RXPORT_MODE_RAW12_HF:
 	case RXPORT_MODE_RAW12_LF:
-	case RXPORT_MODE_CSI2_ASYNC:
 		dev_err(dev, "rx%u: unsupported 'ti,rx-mode' %u\n", nport,
 			rx_mode);
 		return -EINVAL;