From patchwork Fri Jun 16 09:29:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 108984 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1197994vqr; Fri, 16 Jun 2023 02:31:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6mxZ7qpfRpYv4hQI6gH4Gv18+n6KnThesWjOdSsfBIBun6m+IPBydHJXtLWrEWD6LKYtXT X-Received: by 2002:a05:6a00:2411:b0:64f:7a9c:cb15 with SMTP id z17-20020a056a00241100b0064f7a9ccb15mr1688107pfh.11.1686907910902; Fri, 16 Jun 2023 02:31:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686907910; cv=none; d=google.com; s=arc-20160816; b=qLXJGnXTXinOams5Vu60wODeb63xKqjYJzLkytEQHWEC3Yu1kWoVVYMKnhmhdB0duW ZRquDjWxisGXHc2zvGaF1YJygB7wFN6djFv+P+Z1QapDFtflfMdJX0ZipxHhy9+fnmVK fWOjTY1k+7b2puhrtu0ImWkrSVzTTRXVgKNc1tcCxmqUcqR9V6hMTe2A0zX1AMuo0jlr HTT2l9GgLgiiR+FxdBxZoCejAFBco9QVc5037NzL/DYjohNJMbL506UlHoQDOeVqnULM 7jdZX7u+r+FwaRXU2uYnLu/FPoUqLAXPGKy6ytqCH2TJLeDBJNUtryQx0vuIgp/oL/0x 8GEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=C3qgMfktc6pmEGosmZr7TQbV9WnGTOsTAHAh/a5XqlQ=; b=HwOCcscenNcjtzCfs22ek5peUwm/xLBwQFVa4wZyiqniARDGSSUmJTFSDIXfY2VT5U NMF2GAf9HpWdDhcpRqtZiI/0k2TWqhXLYsKqtmm8wA4f9Wj7+c7etdLKHds98BCio1WQ gyfakkfyqaBJr8vaSjEGWTnser/3J30bqbTNHVjKbNjQcKwm6NoK+Wi6giV5dCJZW+va hU8zu8bz90RDqIWTe0KrDLDqL1XDbCcGoHPJCudsa9JAKP3pzzsQEb2i3cJPjMroXeUo KA40mXHU+Uxixa6cIhBABL/hec3thWBqYTuh19p7d3xJOqYesaZKw5mbcHQNbtE3kPZw n+8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RFV0xw4r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x27-20020aa79a5b000000b0065e445224e5si10763969pfj.332.2023.06.16.02.31.29; Fri, 16 Jun 2023 02:31:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RFV0xw4r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244996AbjFPJai (ORCPT + 99 others); Fri, 16 Jun 2023 05:30:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344785AbjFPJaT (ORCPT ); Fri, 16 Jun 2023 05:30:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBCFFEA for ; Fri, 16 Jun 2023 02:30:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4AB4D6229E for ; Fri, 16 Jun 2023 09:30:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF97EC433CA; Fri, 16 Jun 2023 09:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686907817; bh=0LCiNW47vz9emKUNT6ghLeNK5ZkmMsQ8k9618ObBVAY=; h=From:To:Cc:Subject:Date:From; b=RFV0xw4rvVEg653MXihwltNfQZDxkpwhr2f/xjdVLCt8vLzv0j2Kx7BJQZBcCMew8 jpi1fc4WiXoZMdDVhDV2ZA6zF2ybZxYKtrWyRnOYuG11gj8ojIUoul6c+BaIcDN5ed 2CSLn8KDPvgytauycmr4EiD7bUB4gxFYyvc02Yij5ROssojdhQh0tReT+o0Cu8gV6Z 7xOLWD64XznEkiOolp5NfjxqQ6PgaLIGR+/hIzc6TLd/k3rQ5G7+lCYBrfX/AFcKbj AhqtzTzv1a+pwziGilkVzyk+WQN9knrCIUdprSrdstxLQX4EoW8LZWf7GJV5gRfKih STgq8ZDc0xN5A== From: Arnd Bergmann To: Andrew Lunn , Heiner Kallweit Cc: Arnd Bergmann , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , =?utf-8?q?Ram=C3=B3n_Nordin_Rodriguez?= , Parthiban Veerasooran , Frank Sae , Michael Walle , Daniel Golle , Piergiorgio Beruto , Vladimir Oltean , Jonathan Lemon , Randy Dunlap , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] net: phy: mediatek: fix compile-test dependencies Date: Fri, 16 Jun 2023 11:29:54 +0200 Message-Id: <20230616093009.3511692-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768851149476476927?= X-GMAIL-MSGID: =?utf-8?q?1768851149476476927?= From: Arnd Bergmann The new phy driver attempts to select a driver from another subsystem, but that fails when the NVMEM subsystem is disabled: WARNING: unmet direct dependencies detected for NVMEM_MTK_EFUSE Depends on [n]: NVMEM [=n] && (ARCH_MEDIATEK [=n] || COMPILE_TEST [=y]) && HAS_IOMEM [=y] Selected by [y]: - MEDIATEK_GE_SOC_PHY [=y] && NETDEVICES [=y] && PHYLIB [=y] && (ARM64 && ARCH_MEDIATEK [=n] || COMPILE_TEST [=y]) I could not see an actual compile time dependency, so presumably this is only needed for for working correctly but not technically a dependency on that particular nvmem driver implementation, so it would likely be safe to remove the select for compile testing. To keep the spirit of the original 'select', just replace this with a 'depends on' that ensures that the driver will work but does not get in the way of build testing. Fixes: 98c485eaf509b ("net: phy: add driver for MediaTek SoC built-in GE PHYs") Signed-off-by: Arnd Bergmann Reviewed-by: Simon Horman Acked-by: Randy Dunlap Tested-by: Randy Dunlap # build-tested Reviewed-by: Daniel Golle --- drivers/net/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index a40269c175974..78e6981650d94 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -239,7 +239,7 @@ config MEDIATEK_GE_PHY config MEDIATEK_GE_SOC_PHY tristate "MediaTek SoC Ethernet PHYs" depends on (ARM64 && ARCH_MEDIATEK) || COMPILE_TEST - select NVMEM_MTK_EFUSE + depends on NVMEM_MTK_EFUSE help Supports MediaTek SoC built-in Gigabit Ethernet PHYs.