From patchwork Thu Jun 15 13:05:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 108554 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp678058vqr; Thu, 15 Jun 2023 07:29:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4QovMl8bjhtWSTL08jbtivtDeXkQBOOL92nqLy5eMvuM3Q5B8aPLXbQ09BbxpTxZ8Xlm5v X-Received: by 2002:aa7:d44e:0:b0:519:9b17:6938 with SMTP id q14-20020aa7d44e000000b005199b176938mr3301116edr.4.1686839349986; Thu, 15 Jun 2023 07:29:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686839349; cv=none; d=google.com; s=arc-20160816; b=nKyfyCQPn0g7fT03Pofm0/KuVZ/IeWYPhqtyRq75ZBOaL7+z9d0ZLiKHCtISxfB85X WgPzzcpIWzjKdnrs5hpESYjlEPL+QZ2V5qhTBMAOq96tIN6+Zp0HAP3MbG6vymD2v/5y jbB54g886h0wElAStOafUsb/DY0HRPFZdcS2DeOwGqV9e8tVd+95vbf69X26fjqGhZ+U H5g2DzyBsOT6nh00QXh0OYG3xwYAMDyXgbcKtPLR85x9mGgBInbjxTrvSAZ2wHOB2hh5 oNkD6ev4gMiRAfH+LH7pgaSb9RX7U5FjCstE9xaN2CfxRbw67RVbUWfZjnqA0YMq3Buo 8Vlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=STReUXLsvfStNDKEbOiovkKamKKgPKg9PVenROvLuUA=; b=C1S2CcTpLCIAraRclvJiMj0CBPT/Xm1eI06sjXIDpC0eHSwYSQpY+uNIkKjMaxsqFq Vgryx0w5N8W9qWREsqTzokIe5eodhgd4RFniGfMVF439hB+iWIhIeYFoJMnlsK+w6Z3q ItAdGB2ZikgA5jQXl1SlLfFGvCZT/7d6YbsZqbefuTJy9pZ9h6Z6QfKX9jBQt7eHrHIg xEphw9Av0cEbLYO22Fm0H3N84S0knq8yCGMFYl7dUo4sE4Weazt9Q7MQzDjQs4h+Sii7 uCodecXIup/obfqzjvQ8vk5qbDpS7IQWJ8S9TIKaTp1URmrRj+4xHsCHzcBJOTI/yi7O wioQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i18-20020a50fc12000000b005188259bbe0si648391edr.369.2023.06.15.07.28.43; Thu, 15 Jun 2023 07:29:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344472AbjFONhH (ORCPT + 99 others); Thu, 15 Jun 2023 09:37:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344388AbjFONgX (ORCPT ); Thu, 15 Jun 2023 09:36:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DE002D5F for ; Thu, 15 Jun 2023 06:35:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F026C63904 for ; Thu, 15 Jun 2023 13:34:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 646BBC433CB; Thu, 15 Jun 2023 13:34:17 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1q9n7A-000TpB-1W; Thu, 15 Jun 2023 09:34:16 -0400 Message-ID: <20230615133416.288344909@goodmis.org> User-Agent: quilt/0.66 Date: Thu, 15 Jun 2023 09:05:39 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , Beau Belgrave , sunliming Subject: [for-linus][PATCH 08/15] selftests/user_events: Add perf self-test for empty arguments events References: <20230615130531.200384328@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768779258086015959?= X-GMAIL-MSGID: =?utf-8?q?1768779258086015959?= From: sunliming Tests to ensure events that has empty arguments can input trace record correctly when using perf. Link: https://lkml.kernel.org/r/20230606062027.1008398-5-sunliming@kylinos.cn Acked-by: Beau Belgrave Acked-by: Masami Hiramatsu (Google) Signed-off-by: sunliming Signed-off-by: Steven Rostedt (Google) --- .../testing/selftests/user_events/perf_test.c | 53 +++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/tools/testing/selftests/user_events/perf_test.c b/tools/testing/selftests/user_events/perf_test.c index e97f24ab6e2f..8b09be566fa2 100644 --- a/tools/testing/selftests/user_events/perf_test.c +++ b/tools/testing/selftests/user_events/perf_test.c @@ -189,6 +189,59 @@ TEST_F(user, perf_write) { ASSERT_EQ(0, self->check); } +TEST_F(user, perf_empty_events) { + struct perf_event_attr pe = {0}; + struct user_reg reg = {0}; + struct perf_event_mmap_page *perf_page; + int page_size = sysconf(_SC_PAGESIZE); + int id, fd; + __u32 *val; + + reg.size = sizeof(reg); + reg.name_args = (__u64)"__test_event"; + reg.enable_bit = 31; + reg.enable_addr = (__u64)&self->check; + reg.enable_size = sizeof(self->check); + + /* Register should work */ + ASSERT_EQ(0, ioctl(self->data_fd, DIAG_IOCSREG, ®)); + ASSERT_EQ(0, reg.write_index); + ASSERT_EQ(0, self->check); + + /* Id should be there */ + id = get_id(); + ASSERT_NE(-1, id); + + pe.type = PERF_TYPE_TRACEPOINT; + pe.size = sizeof(pe); + pe.config = id; + pe.sample_type = PERF_SAMPLE_RAW; + pe.sample_period = 1; + pe.wakeup_events = 1; + + /* Tracepoint attach should work */ + fd = perf_event_open(&pe, 0, -1, -1, 0); + ASSERT_NE(-1, fd); + + perf_page = mmap(NULL, page_size * 2, PROT_READ, MAP_SHARED, fd, 0); + ASSERT_NE(MAP_FAILED, perf_page); + + /* Status should be updated */ + ASSERT_EQ(1 << reg.enable_bit, self->check); + + /* Ensure write shows up at correct offset */ + ASSERT_NE(-1, write(self->data_fd, ®.write_index, + sizeof(reg.write_index))); + val = (void *)(((char *)perf_page) + perf_page->data_offset); + ASSERT_EQ(PERF_RECORD_SAMPLE, *val); + + munmap(perf_page, page_size * 2); + close(fd); + + /* Status should be updated */ + ASSERT_EQ(0, self->check); +} + int main(int argc, char **argv) { return test_harness_run(argc, argv);