From patchwork Thu Jun 15 13:05:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 108556 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp679379vqr; Thu, 15 Jun 2023 07:30:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4wGAxaadCfTXUYacrYdmog6f572rQGD3p3JkoQP1YdnW3EhQdh92r3h6XTOFHlHPMwzPe1 X-Received: by 2002:a2e:9a88:0:b0:2b4:3faf:c3de with SMTP id p8-20020a2e9a88000000b002b43fafc3demr1672057lji.49.1686839454803; Thu, 15 Jun 2023 07:30:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686839454; cv=none; d=google.com; s=arc-20160816; b=N4fmLVUTfMARGhwhkDxSl6UVUhTZDR6f7P2NT9g6p84oKiiDwcftK1ghJ/EAERiwOH 6vAshjUTxOO0+pVOzPHf3Cp01+VDAX/3cueGCxFKwkvcQ/Fk7RGKzE1uKGwGB/Pv9DZU REKXbK+IjXiJPh1tI6fJFwHK+vP4uW0rCLY449fdu0dwuO4fdINA+63t74lAtn3DZkwz k1YbIzXvjj0ev9oPWprTbHn2/vT/RiAzXn9E9j/4H2tXBfEt0+aGTwdY+39ezdjZisu3 qJQq3FBcqnBYYFB2HldLtH7IFTj/vzzvcqeB8jSV3ToePliVGNhEmmXVPuMv+KtiE1xH D95g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=2iG0qcLEWG38z1uY69hvkDWP3oV8HxWRBJVG9HlEvhI=; b=CDGNLP6GF4wc/G5cwAUmPTA4QLIh5S6Bvx62FwDCwU/DSNn8gDhZbTr0Qfqspey+LP Xaw6m5zOYRyeeb5cOZ0WS+RQJP2TZ7v2YsWtVvx6N9jbPrlqjpb4ADorayIT25UDPjby 37y5JTvx61lVqwSHpXDOGvOrfJTSsNF80kIWCoSQ3PM9vOmpCdDAP+vuXaVY23iq+Qs/ ekoVC5EsOF4fPcuR5UTwlEh3Vsxn9WhNQ1X2v4udWW2QFw+kGd+QIlGAogSKTyBe/y/x kl5qL5tf+I1QcOLoU2ySmPdGTxfIopUEZJ2KTJP+4CEEQMEonhoMegW4EU1PRrPZ+XwH Vcuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s8-20020aa7d788000000b0051643861867si9679412edq.226.2023.06.15.07.30.24; Thu, 15 Jun 2023 07:30:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344291AbjFONft (ORCPT + 99 others); Thu, 15 Jun 2023 09:35:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344574AbjFONfL (ORCPT ); Thu, 15 Jun 2023 09:35:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A38C2960 for ; Thu, 15 Jun 2023 06:34:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3F5E4637EE for ; Thu, 15 Jun 2023 13:34:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A30F5C43395; Thu, 15 Jun 2023 13:34:16 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1q9n79-000Tmx-28; Thu, 15 Jun 2023 09:34:15 -0400 Message-ID: <20230615133415.478015212@goodmis.org> User-Agent: quilt/0.66 Date: Thu, 15 Jun 2023 09:05:35 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , sunliming Subject: [for-linus][PATCH 04/15] tracing: Modify print_fields() for fields output order References: <20230615130531.200384328@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768779368461597479?= X-GMAIL-MSGID: =?utf-8?q?1768779368461597479?= From: sunliming Now the print_fields() print trace event fields in reverse order. Modify it to the positive sequence. Example outputs for a user event: test0 u32 count1; u32 count2 Output before: example-2547 [000] ..... 325.666387: test0: count2=0x2 (2) count1=0x1 (1) Output after: example-2742 [002] ..... 429.769370: test0: count1=0x1 (1) count2=0x2 (2) Link: https://lore.kernel.org/linux-trace-kernel/20230525085232.5096-1-sunliming@kylinos.cn Fixes: 80a76994b2d88 ("tracing: Add "fields" option to show raw trace event fields") Signed-off-by: sunliming Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_output.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c index 15f05faaae44..1e33f367783e 100644 --- a/kernel/trace/trace_output.c +++ b/kernel/trace/trace_output.c @@ -847,7 +847,7 @@ static void print_fields(struct trace_iterator *iter, struct trace_event_call *c int ret; void *pos; - list_for_each_entry(field, head, link) { + list_for_each_entry_reverse(field, head, link) { trace_seq_printf(&iter->seq, " %s=", field->name); if (field->offset + field->size > iter->ent_size) { trace_seq_puts(&iter->seq, "");