From patchwork Thu Jun 15 10:56:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 108438 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp557653vqr; Thu, 15 Jun 2023 04:24:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4p+ra+z5v4MFKQtTeTRhGFlGgYohncdvWNJ4UvU2e49MFa+gdu+/PtQ4urkSSEQFYGeZlZ X-Received: by 2002:a2e:8ec8:0:b0:2b3:4acd:8477 with SMTP id e8-20020a2e8ec8000000b002b34acd8477mr3449876ljl.10.1686828255079; Thu, 15 Jun 2023 04:24:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686828255; cv=none; d=google.com; s=arc-20160816; b=C5dwyIPZb293y38pwcZh73VaAHRHwGUUOSX2xAoebZkQ3dfmi9R6fUQELbAu7BMKNB UgFiVeeNd7FpkX8TTRyD7jTDuK40Acw3lY8Zg068yH7aui6RW+FUi0f5xF9oQjMHeAxe igZ/zjGsyZPuID9nsPiNMDXVSW3KSQ6MQoPN4vnkR1I4Oj4Tv6UV/hNSp8r+7Q56Jlho cPWgTzU7Ydj8gwY77rF/jjkLvz8Sa+2DbGG/X9stSOpGsBTydpTEFJVXjAW64pmXYFJM +msPekHo3b0AR1RLenV26zp9NlxLf4x+JyB+vdz0IVNk5CWxKSNEJQqrVJfQs6DFZBhm 2TkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :dkim-signature:from; bh=I/QLlkP12aZg2OG62D74WUAk4h5OegU8e3v3LQUZTFk=; b=V4T4+pCYgZW2k8NAIfofZVcIQBY7yFvW2sJfFz7q1fm3oWZ9QbGCDWhlQgeCyEWkVb +qjtPOuLx8x7j5J947ykdxYUNKTAmor4ATF3725FhzWdRaMDbRfGMBu2EJ9Sl9CNjCT+ SBHGOxjnXwua1b5uTfLjgPuP5kxj8B7lqGzgzkkbmJII9XHATQGeATdLDnldTj9yKao6 gALMblI4ZVa65hpV9pGtSZ9adh/P0LMwZot7+PNqb9UFwwEGEkqu1iEJQxASercCRYDG pfqprDzEo20ILxXG7YGpP4SmASGj8cROxHH7cWCsg436SFjn9u0SCLRQt7Zs24cDu0bR bp5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=ZUbs71h1; dkim=neutral (no key) header.i=@linutronix.de header.b=ggyL+eW0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n2-20020aa7c442000000b0051a2cc8c485si412317edr.295.2023.06.15.04.23.50; Thu, 15 Jun 2023 04:24:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=ZUbs71h1; dkim=neutral (no key) header.i=@linutronix.de header.b=ggyL+eW0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240340AbjFOK4v (ORCPT + 99 others); Thu, 15 Jun 2023 06:56:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238074AbjFOK4p (ORCPT ); Thu, 15 Jun 2023 06:56:45 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EF381A2 for ; Thu, 15 Jun 2023 03:56:43 -0700 (PDT) From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1686826600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I/QLlkP12aZg2OG62D74WUAk4h5OegU8e3v3LQUZTFk=; b=ZUbs71h1JxlcirLnjh96NF0dj08tpsOtNdYeN750JN+DnI94kftP24X6Ei1sYjMuCvdbbW SlaP7MRfaAWkqAxqxqKKWOagPkcxtHWl0icsRhJUnUwhBdE2VmWkhND9lO0I+HfLog5Aki L8dL303ixRxZ7sFPaxPsxHoEkRj+yIWt037CFnS0ng0Cr31Rs7SHJ+OGnBTg+e55ron1Oi Fd04WmRxo8H4CN+8hLRhfzzIFoy+3lba7XUqzCRVayZ4tFYodz+7Gmgg0AE51t8Xr6xA+y 2TAKNT42biJ7NLEHi5NyC6VJ3jky8/TOji47halPux/b0Z47Asf1vxZzzFdPLQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1686826600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I/QLlkP12aZg2OG62D74WUAk4h5OegU8e3v3LQUZTFk=; b=ggyL+eW02COW//bhBK3KlTKd60ubVbq/Q6p4lXVX1rIuoTmVll0DeBr+qgdLI/EBxtSX3T btBb0YyjAqniYTAA== To: linux-kernel@vger.kernel.org Cc: "Eric W. Biederman" , Oleg Nesterov , Peter Zijlstra , Thomas Gleixner , Sebastian Andrzej Siewior Subject: [PATCH v3 2/2] signal: Don't disable preemption in ptrace_stop() on PREEMPT_RT. Date: Thu, 15 Jun 2023 12:56:27 +0200 Message-Id: <20230615105627.1311437-3-bigeasy@linutronix.de> In-Reply-To: <20230615105627.1311437-1-bigeasy@linutronix.de> References: <20230615105627.1311437-1-bigeasy@linutronix.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768767624549486381?= X-GMAIL-MSGID: =?utf-8?q?1768767624549486381?= On PREEMPT_RT keeping preemption disabled during the invocation of cgroup_enter_frozen() is a problem because the function acquires css_set_lock which is a sleeping lock on PREEMPT_RT and must not be acquired with disabled preemption. The preempt-disabled section is only for performance optimisation reasons and can be avoided. Extend the comment and don't disable preemption before scheduling on PREEMPT_RT. Acked-by: Oleg Nesterov Signed-off-by: Sebastian Andrzej Siewior --- kernel/signal.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/kernel/signal.c b/kernel/signal.c index da017a5461163..e887cd684d17a 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -2328,11 +2328,20 @@ static int ptrace_stop(int exit_code, int why, unsigned long message, * The preempt-disable section ensures that there will be no preemption * between unlock and schedule() and so improving the performance since * the ptracer has no reason to sleep. + * + * On PREEMPT_RT locking tasklist_lock does not disable preemption. + * Therefore the task can be preempted (after + * do_notify_parent_cldstop()) before unlocking tasklist_lock so there + * is no benefit in doing this. The optimisation is harmful on + * PEEMPT_RT because the spinlock_t (in cgroup_enter_frozen()) must not + * be acquired with disabled preemption. */ - preempt_disable(); + if (!IS_ENABLED(CONFIG_PREEMPT_RT)) + preempt_disable(); read_unlock(&tasklist_lock); cgroup_enter_frozen(); - preempt_enable_no_resched(); + if (!IS_ENABLED(CONFIG_PREEMPT_RT)) + preempt_enable_no_resched(); schedule(); cgroup_leave_frozen(true);