Message ID | 20230615105333.585304-2-claudiu.beznea@microchip.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp560455vqr; Thu, 15 Jun 2023 04:29:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6k/Hq53cZJNb3UOwsTjfEcl493B9ffwPrSvqV7coVoOgLSzO0/79VZpuIGWqv0OsWr37ri X-Received: by 2002:a05:6830:1684:b0:6b3:b54b:3647 with SMTP id k4-20020a056830168400b006b3b54b3647mr6688766otr.17.1686828587846; Thu, 15 Jun 2023 04:29:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686828587; cv=none; d=google.com; s=arc-20160816; b=dBZI7/3ZIFeE1TDAqS/+FySqYBYLN5goy2H8nEunB1fQWiSsGd0UeDrF59T3aXxMOs O3tF1ac1t7RKrRP7uOrgHTxqMstvaA2khaT7+w75+HTmsrBDf0Bk8SUQDXN95cqOKvZ7 o3rID1Iuu6SW1hIEWmfnI4CUwjtqBC7jTaoVi4Pg/+cz9jrvHXSYHCPsvXQHTaS1rJIV ZEM2kFymyyeSqp/DMracBDOzkwL2UcZuFMRT3JrgbHvqzsXrycai7uLK+w3rIjpLLjVQ d36QY0ZeV1ook+CIkaxM6EyJtY4cmkS+oLISiuxCL1i0sp3wOTMNo7TL+jT4krM6s1Bq a/lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ccfd6HP/rR8+fr/9984lF6hvcBFGy8oy9QTDbsX0CxY=; b=ip1Uw1udlCLYatEAJtXSPE0XBcsoXbRWvuQ0B1OWcCefdMiPaEezqO3QQVrbqGSuIB PrNqvhw0b4QRWj2QZKnkWSR2b4Px6HBQrDcH1BXaL+S9AkPljDAMcd9YfuQS0Qtg803F sR0uszs2f5ZlxGXk/U95T5+GPaVaPZ8X6lwkdLZOw0E8rt4pe6sZb2eGcm8GLWD/zGLI GWXCgQMJXMeA3xYQRCQi+MMzHsSUoPEd0jno5Ti0ObK2S1J5nG4CJGIwJD7g+4ZQVh2T aL2bwNssbhdt4kJz3aAKGo9CZAxp9kraR9CrNLnxJiqEOU0XsZlQYx52JXjc1IRb3H8m dbXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=QGXBWTJN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b27-20020a63931b000000b00524b2358ffcsi13246317pge.574.2023.06.15.04.29.34; Thu, 15 Jun 2023 04:29:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=QGXBWTJN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343668AbjFOKyH (ORCPT <rfc822;n2h9z4@gmail.com> + 99 others); Thu, 15 Jun 2023 06:54:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241757AbjFOKyE (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 15 Jun 2023 06:54:04 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 144611FE4; Thu, 15 Jun 2023 03:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1686826443; x=1718362443; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=roTYgP3DrDdWNlW0RbVAYG9eUbAOFUhPXtFqT0roqYE=; b=QGXBWTJN3NnAwnzlZmydxZ55aNem8kNme9gcb8Y+vihK/UNWvTdxiIfO zv0B5xEDBH/I/A/yG8VwRAqd5oczxBdMr94MMxmau3t6UdS2k56fwFyBI SeGW23E034zme+8bzGlTV2A67G5WSt1Paco834dFNB57sCbStvZgDo+Qo uBR4t/pmJTQTBI/vHhwu4k/6n1De+2k4Qc3h/Grzx1IAp74YdYz8kqU53 AIM9Bn8ZTIhAJbC73klVmYIZC1APDPqwUAEUwgCA0nFwBypbQwGBgYZUP FqubZQeE7mExKJ07yyIMy+qsgGp6bjnBckh5OmT9JiZDMItqT5ytejBfn w==; X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="218006732" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 15 Jun 2023 03:54:03 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 15 Jun 2023 03:53:56 -0700 Received: from m18063-ThinkPad-T460p.mchp-main.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Thu, 15 Jun 2023 03:53:51 -0700 From: Claudiu Beznea <claudiu.beznea@microchip.com> To: <ludovic.desroches@microchip.com>, <linus.walleij@linaro.org>, <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <lars.povlsen@microchip.com>, <Steen.Hegelund@microchip.com>, <daniel.machon@microchip.com>, <UNGLinuxDriver@microchip.com>, <andriy.shevchenko@linux.intel.com> CC: <linux-arm-kernel@lists.infradead.org>, <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Claudiu Beznea <claudiu.beznea@microchip.com> Subject: [PATCH 1/3] pinctrl: mcp23s08: check return value of devm_kasprintf() Date: Thu, 15 Jun 2023 13:53:31 +0300 Message-ID: <20230615105333.585304-2-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230615105333.585304-1-claudiu.beznea@microchip.com> References: <20230615105333.585304-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768767631935459700?= X-GMAIL-MSGID: =?utf-8?q?1768767973484722509?= |
Series |
pinctrl: check memory returned by devm_kasprintf()
|
|
Commit Message
Claudiu Beznea
June 15, 2023, 10:53 a.m. UTC
devm_kasprintf() returns a pointer to dynamically allocated memory.
Pointer could be NULL in case allocation fails. Check pointer validity.
Identified with coccinelle (kmerr.cocci script).
Fixes: 0f04a81784fe ("pinctrl: mcp23s08: Split to three parts: core, I²C, SPI")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
drivers/pinctrl/pinctrl-mcp23s08_spi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-mcp23s08_spi.c b/drivers/pinctrl/pinctrl-mcp23s08_spi.c index 9ae10318f6f3..4013ffbfa282 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08_spi.c +++ b/drivers/pinctrl/pinctrl-mcp23s08_spi.c @@ -119,6 +119,9 @@ static int mcp23s08_spi_regmap_init(struct mcp23s08 *mcp, struct device *dev, return -EINVAL; } + if (!name || !mcp->chip.label) + return -ENOMEM; + copy = devm_kmemdup(dev, config, sizeof(*config), GFP_KERNEL); if (!copy) return -ENOMEM;