From patchwork Wed Jun 14 21:06:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 108154 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp242811vqr; Wed, 14 Jun 2023 14:42:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4bFTOh5bdK+V3hFqMXLPDuuBDWXbh5BtC8wsZp/l4lQQDo2FRtNSjSnzDggnVUk0Z5t4Al X-Received: by 2002:a05:6a20:158f:b0:101:1e75:78e with SMTP id h15-20020a056a20158f00b001011e75078emr3671285pzj.14.1686778929720; Wed, 14 Jun 2023 14:42:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686778929; cv=none; d=google.com; s=arc-20160816; b=awonjRyX0a4r6FUN8abCZD+NMtJ9BDQyoAcZS/rxKGqfkatGnzatzmh+0tZjgMpQyx jCcV8FLUCBcm+6SclBPXXPt6MgswUoHNSc+8JMvv0xcMxnkNQaR8GZyzAuKWhrrCbcXk VirnCDUwOcX4QLrMOKzYITr6ie0nwngRVTkYcYJ6W6Wz6IIixpwAFx67kh1h8faVq1m+ xzhGvb6kMq/pQguiWtcElEG/kg96LBxs7EeD6U2NuKDcSHfl4iUBYfkiK/9U1TFjIA15 7iRwQLXDL8ITE4JSx2XkWqKxr193Zi3Cl8g59hfEY8pXiBwuIen/qws3VFfIPkamSrH4 JL+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:ui-outboundreport:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from; bh=J8lpj9+V7kKduJBRvs2x90ri0X0wLjZBx9IgpkvzLNE=; b=uz/K9bbHUgiJRmkUTF+ncllEB9wLNzldkxJ1yEGxDsGvW0XPtHXL+cMrL0/u1YCeil 9vVhsxICi4SiFYCD2tiXvMuWrTY7+HxjoEriDYg67uieGOn546eeMA+xK+wVz/TbGnkf khKp0/YqS7M4yFpK/BBuyEMkmW3uLFO5YEYMyUGcp4nJ7W15wxGgfsBOLSDnBo/XbSO/ PXi4i065mfX2xUV2BRHwxnJ/3SY9oOiYKPRwsRJV/Lg3fVtvh/USSaid1lDFzaCwIRYa 08TfsPggLFdn30L+auQYdxio8DY+fDBc8Q0/Ha+9l9PibiweoR49aYnb077yAgbemO9S GJiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m29-20020a63711d000000b00502f4fd0c16si8299809pgc.653.2023.06.14.14.41.55; Wed, 14 Jun 2023 14:42:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234019AbjFNVHl (ORCPT + 99 others); Wed, 14 Jun 2023 17:07:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230301AbjFNVHj (ORCPT ); Wed, 14 Jun 2023 17:07:39 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF3521FD4; Wed, 14 Jun 2023 14:07:37 -0700 (PDT) Received: from stefanw-SCHENKER ([37.4.248.58]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MWAjC-1qbdWV3db0-00Xe0s; Wed, 14 Jun 2023 23:07:21 +0200 From: Stefan Wahren To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Stefan Wahren , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH V2 net] net: qca_spi: Avoid high load if QCA7000 is not available Date: Wed, 14 Jun 2023 23:06:56 +0200 Message-Id: <20230614210656.6264-1-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:gO0kR5BythBG+gWfTdyOGzZGoT+88Kz1d2/8tmsYxwYPp/AGmSB lPmZeAZOMTsB6i4hRI0Rv35Nha3NCnf6yLKVp7ZWWCBN9YGIWCxQNGk6RRo7icpb3TjxMQh msBr09eUxpiq6yEHNZHTPvksWml+PF5pOUJXPk2338HjUNe2J+9cdNMxYnvWRq7u5hQEdkj VdMLqT8P2NZS/aHGbGlQA== UI-OutboundReport: notjunk:1;M01:P0:JfalXIoL/cE=;KFZvrtSmWNt3/u0HYOPGGwocAa5 CApBh1ONIAfzahlLOysMw2eclK5c0HSckMkhHZqO23CKDW3saahriVbDpq/xaKmaCMtFCCuaj 6inrelcrTyWk9JEI0uJbxNGevFSD2hyoXOPcU/l+BxU4BcT4J3xvMKdiNqUCjwmVNMmRgp7A+ RDK5nqaKvrRaS+NrUtrCR1Ce1Cid0dqVyT7Awd8JjIyxJlhePzlf0D2eea2Kr6f1v+an46owq kjjmPs+i4UEgW7wHiOLxGOc1tbvCgIXc3lKg4+mmMrqYw4zyhPsLG5Njt4Yq27U7IfMPvetYG oo4eqpTYhDw/Rx0E2LcCki2i1D5OhUD9uteMdaI6qZlDtDSZjoiNxb1vCo11m+SfMS9sUjlz8 7cq7e1YND5hjCwU1gsKOWClMQd9RXreRGcud7uzYnafsZP+pQ2iXWf/Uwyu5alsNTP0w3N5U2 aRzADYIlMEBRfmO+Tdp8yeemB1zkQynoGMb2QJjtEJZuRhq7U0tud3fzXUQ4qhudZHwxM85sD j0Hpw1oP5cbYI9N0d4r9IOB0dApnusNePC40tp6SZyE9tnAZzbMbD6c9+pAZdwMaIklgdUkbz 7DedsYolqeb9bvjZlEHryWPUapEYQXkHESVb1Jzac7g4hwvonq73qnO0o3usvHyuwC/306ZjY L7m6pftMtrAfcpWLOrZJJocMEDlfOjektd2XQhPjvw== X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768677811476336353?= X-GMAIL-MSGID: =?utf-8?q?1768715903304135806?= In case the QCA7000 is not available via SPI (e.g. in reset), the driver will cause a high load. The reason for this is that the synchronization is never finished and schedule() is never called. Since the synchronization is not timing critical, it's safe to drop this from the scheduling condition. Signed-off-by: Stefan Wahren Fixes: 291ab06ecf67 ("net: qualcomm: new Ethernet over SPI driver for QCA7000") --- Changes in V2: - send from different account which doesn't break the patch drivers/net/ethernet/qualcomm/qca_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index bba1947792ea16..90f18ea4c28ba1 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -582,8 +582,7 @@ qcaspi_spi_thread(void *data) while (!kthread_should_stop()) { set_current_state(TASK_INTERRUPTIBLE); if ((qca->intr_req == qca->intr_svc) && - (qca->txr.skb[qca->txr.head] == NULL) && - (qca->sync == QCASPI_SYNC_READY)) + !qca->txr.skb[qca->txr.head]) schedule(); set_current_state(TASK_RUNNING);