From patchwork Wed Jun 14 17:46:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Safonov X-Patchwork-Id: 108099 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp153685vqr; Wed, 14 Jun 2023 11:40:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6vsdyIuUI7U44vvfzFjeRY4V7DM2ro9rDecKFSrp4stbhG2wARZDOOl0bLVL9V1tMcLIvP X-Received: by 2002:a05:6a21:339f:b0:101:5192:18a9 with SMTP id yy31-20020a056a21339f00b00101519218a9mr2464571pzb.21.1686768023859; Wed, 14 Jun 2023 11:40:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686768023; cv=none; d=google.com; s=arc-20160816; b=pQCvykm5eLpvinusa8pQP/X3Bf5y9YcMzIhQSrhyHc5snswB4Aj+e+ZJH2z/LYCuFO pmpnTsO0AVHp9PqjrAmFovVFuPOqEFIZG2ar0O7WPVxDeeyajDLDWpcMFsiON+EveCIf EuZRU1CwN30E69mh74RAWT4vvntHZsKmluEfn0cT+7nOnN8St+LHRZTRCVm3b4BcTeYP qSV5lG2G5VAki+SFaxil7Q/+1DOPijoYHZYLYl5cTFSJs0zOgXvldnkmSQe5tUsiXrp8 cHFFzx+IYU3DT3yminD7yHPtqRTWyUycptcwezPscFjp1LVXd93r0DlG4H5eAHr4UYdC NpGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FnQy3LIARieYREiW9Ccv3J1qltaXMlHsSeiVItoMb4w=; b=BNRzbViXo34y2qY0hd0aOl2DsIpyjge0zT9CbT9jJyoQvbv/CXSf7rgDcsmI0EP47+ G7WoFn9NgdEzJPgpUy8r3Wf/dEWhfeVSyCFqfI6onkeSJyQU+9lgn/SFSr8h07ilA24R BZWoYzdELYp1vBIoV2T/3tKwGwEjYq8gGbmfHSS2JCOyb85eVC0qLWKfmmd/RtuLWHZZ XaY8BCtzGoxXC7H2msCEtxunzF5SxuU+hvbbnier/Sau0zKTpOtfKtiJ8d+/Mejfm739 jDaeuksXawLnXmiosUmWbce+0eB4AlxMrAnwnk33z7MB48LHNC2/Bl2+KZi2w7ruojkq 4Eag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arista.com header.s=google header.b=LRJDEUf4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=arista.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v10-20020a63610a000000b0054fd8d57b1esi1556240pgb.668.2023.06.14.11.40.10; Wed, 14 Jun 2023 11:40:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@arista.com header.s=google header.b=LRJDEUf4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=arista.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239585AbjFNRrT (ORCPT + 99 others); Wed, 14 Jun 2023 13:47:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239175AbjFNRq4 (ORCPT ); Wed, 14 Jun 2023 13:46:56 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED6141BF0 for ; Wed, 14 Jun 2023 10:46:55 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-30fbf253dc7so3018986f8f.0 for ; Wed, 14 Jun 2023 10:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; t=1686764814; x=1689356814; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FnQy3LIARieYREiW9Ccv3J1qltaXMlHsSeiVItoMb4w=; b=LRJDEUf43vD8BUpN2Fp0vlm+aErjd9CjmJlwiQ/YjQy6BKRuPVNQIgSNQi1+YuB+vO pgOyDjXLIF6vIpolxt5KmQyvKUenboC+4M2q9t6WWIoImIzBnQ8i7DwLWicSDGP+qOOy Fpy8n42VosWUf40ZI/JujL4mhgQTTKdwBl9m0XzkhWLfhZvgD9F/SRMB5yjGADiXhkJM uF1BuELXWyUsXeV/FscPUwT5Y4jfiMbLxD5exUVQFnfOj3nut/MMWqWUGXcStxT1OvJo BeIe1bbJf8Veu5s77lEciJ1NAMlx+dmRbZArR5Y+GL8ZMLUOlvuT+jACPNznVNIs2EQJ AyYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686764814; x=1689356814; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FnQy3LIARieYREiW9Ccv3J1qltaXMlHsSeiVItoMb4w=; b=lq4h4hM6arLFQusAMSgcc0UY/O3J8glJgRE/C3tD1q0Wvj17g8crQ32GmY2fNXoCel 21KT6CJYcUdrFlfOdvFEdp0Op5GDKYGb66W0oR5o/JLf0aIQYRs3HfYlbNgTtP/aaB/P oTIPUaGZOPX4e3Sv5IEkUeDqVx0GBxPaOKdgugC+FHTw7gvNK4R0HzpXwFXTNtPWY3K1 cVouKjRbmsTdftyFvj9OhBJxNn4+MLHlTbIR/HEmecnYSbw9ogWcYcl6mlWrWKHA2quQ zqS/1OF5lgdw8d8BvHDHWr20mz+4JgJEhROVumbYfUn7LpZpD11CrzGGy87Oqo5Sa63K b4lw== X-Gm-Message-State: AC+VfDxrOBWNlUdoMTZAVF+ui1IUR6qTnQbtBc83s6IeazyZLYCXZQMi Vxo3yhQzPi7R1odt2bwtmM1Jmw== X-Received: by 2002:a5d:440c:0:b0:30f:c56c:b5a8 with SMTP id z12-20020a5d440c000000b0030fc56cb5a8mr2262496wrq.2.1686764814527; Wed, 14 Jun 2023 10:46:54 -0700 (PDT) Received: from Mindolluin.ire.aristanetworks.com ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id m4-20020a056000180400b0030633152664sm18738740wrh.87.2023.06.14.10.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 10:46:54 -0700 (PDT) From: Dmitry Safonov To: Herbert Xu , linux-kernel@vger.kernel.org Cc: Dmitry Safonov , Bob Gilligan , David Ahern , "David S. Miller" , Dmitry Safonov <0x7f454c46@gmail.com>, Eric Dumazet , "Eric W. Biederman" , Francesco Ruggeri , Jakub Kicinski , Paolo Abeni , Salam Noureddine , linux-crypto@vger.kernel.org Subject: [PATCH-next 3/3] crypto: cipher - On clone do crypto_mod_get() Date: Wed, 14 Jun 2023 18:46:43 +0100 Message-Id: <20230614174643.3836590-4-dima@arista.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230614174643.3836590-1-dima@arista.com> References: <20230614174643.3836590-1-dima@arista.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768704467445632800?= X-GMAIL-MSGID: =?utf-8?q?1768704467445632800?= The refcounter of underlying algorithm should be incremented, otherwise it'll be destroyed with the cloned cipher, wrecking the original cipher. Signed-off-by: Dmitry Safonov --- crypto/cipher.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/crypto/cipher.c b/crypto/cipher.c index 184188339a4a..b53bf3cda826 100644 --- a/crypto/cipher.c +++ b/crypto/cipher.c @@ -101,10 +101,15 @@ struct crypto_cipher *crypto_clone_cipher(struct crypto_cipher *cipher) if (alg->cra_init) return ERR_PTR(-ENOSYS); + if (unlikely(!crypto_mod_get(alg))) + return ERR_PTR(-ESTALE); + ntfm = __crypto_alloc_tfm(alg, CRYPTO_ALG_TYPE_CIPHER, CRYPTO_ALG_TYPE_MASK, GFP_ATOMIC); - if (IS_ERR(ntfm)) + if (IS_ERR(ntfm)) { + crypto_mod_put(alg); return ERR_CAST(ntfm); + } ntfm->crt_flags = tfm->crt_flags;