Message ID | 20230614073125.17958-4-shawn.sung@mediatek.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1077718vqr; Wed, 14 Jun 2023 01:16:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5A1WMaj7yuKPhDXBqTBqsue+20BKopU9R02I6+zsK53tRfwaUV6hWybPxKsMjqPdaVH9AE X-Received: by 2002:a17:902:b416:b0:1b2:2c0c:d400 with SMTP id x22-20020a170902b41600b001b22c0cd400mr9417128plr.52.1686730597339; Wed, 14 Jun 2023 01:16:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686730597; cv=none; d=google.com; s=arc-20160816; b=z4OJYA4aiHA3ZsPxnw15ZxQ3MbcOz6r5qEK3jzSn3szdmrCAWLI+LhrrRSjyQLTACd CuWdwiEXSgpjqdUANra/y/4WArhBEttqXO40RC8fl/RRmGW2nrmacrh3HSdCS7UE4RyO dXGqAbTL8CbUzTBm55lzrkF4vFlPXA/l9hVzhc4TICS7dN2bD5xyeUXhBPYrFymHZRZA sMQbASmyfeWs9O82KGw2+88Tk9wsFTMi5tmntQ9QeQ8sXrtoaxyCRVjnAsPsBT5O2rYu GwxLMh4vL853AEzk7z/FLCY1eLQloRdwo8eFhuMEncZOOh49TUPA5wvCFvjOJdnksKRW LdMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=OVVWiQdAhDsoVl7MPahx1qZhjGtpKxL5lhbVi8FSpWw=; b=ZQlGLe2CHYOF/RBzzG79Dal5Q6y7IAp1LDX2/BGRv9IyO2LWA39H8JpIbI5kF31GVq HJvIpkoChTDkDEZPYCzUnklCo9OlXl0ZrFZ5Lyny4cEJfVMiGA20VDqfm0BWjzcq1mUE O7skAFS0AXCVP4RKBFOCj6K4R7CYjFf5qsJTbEuFyqtseaqUFjgy3wyh6IhqaGg1YTGI wfKC+E1uEC6psBHgF/HCpY3t3lLgzo78Xs6NW/gnavERHPVcC7HMD+tc7gsjxNFoHSHg Rh/vV7XoAar1QZEsxuv8082Q7bLm12lAyoVzkT+OjrXzXGPJLipuXLSvHM5CFGSiK0zv Dt8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=AEGkzgsq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s6-20020a170902ea0600b001afada38c64si6714614plg.302.2023.06.14.01.16.24; Wed, 14 Jun 2023 01:16:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=AEGkzgsq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243381AbjFNIGd (ORCPT <rfc822;jesperjuhl76@gmail.com> + 99 others); Wed, 14 Jun 2023 04:06:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243332AbjFNIGK (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 14 Jun 2023 04:06:10 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 974FE10DA; Wed, 14 Jun 2023 01:06:08 -0700 (PDT) X-UUID: 83f905da0a8511eeb20a276fd37b9834-20230614 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=OVVWiQdAhDsoVl7MPahx1qZhjGtpKxL5lhbVi8FSpWw=; b=AEGkzgsq7t0p1zyAxrbbo7oEMROf4tJG9YGpzkfFZMSeH4LU69NCaIPFqR9SKmrne2I+q4usZ199QodnDPHx3H++pM5F+gLOgDXBqMHFfZWSpjNVU7pXruS+jAuhkWoxItrjI5D9XOQLj+1evkQjM5rwQ55N/GKW8xuBAin8M74=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.26,REQID:4a467178-280a-486e-93a3-d9a95d2dd9ce,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:cb9a4e1,CLOUDID:3f09076f-2f20-4998-991c-3b78627e4938,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 83f905da0a8511eeb20a276fd37b9834-20230614 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw02.mediatek.com (envelope-from <shawn.sung@mediatek.com>) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1342180984; Wed, 14 Jun 2023 15:31:45 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 14 Jun 2023 15:31:44 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 14 Jun 2023 15:31:44 +0800 From: Hsiao Chien Sung <shawn.sung@mediatek.com> To: Chun-Kuang Hu <chunkuang.hu@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Philipp Zabel <p.zabel@pengutronix.de>, Rob Herring <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org> CC: <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, <devicetree@vger.kernel.org>, <Project_Global_Chrome_Upstream_Group@mediatek.com>, Singo Chang <singo.chang@mediatek.com>, Nancy Lin <nancy.lin@mediatek.com>, Jason-JH Lin <jason-jh.lin@mediatek.com>, Shawn Sung <shawn.sung@mediatek.com> Subject: [PATCH v2 03/15] dt-bindings: display: mediatek: merge: Add compatible for MT8188 Date: Wed, 14 Jun 2023 15:31:13 +0800 Message-ID: <20230614073125.17958-4-shawn.sung@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20230614073125.17958-1-shawn.sung@mediatek.com> References: <20230614073125.17958-1-shawn.sung@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768665222873334542?= X-GMAIL-MSGID: =?utf-8?q?1768665222873334542?= |
Series |
Add display driver for MT8188 VDOSYS1
|
|
Commit Message
Shawn Sung (宋孝謙)
June 14, 2023, 7:31 a.m. UTC
Add compatible name for MediaTek MT8188 MERGE.
Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
---
.../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 3 +++
1 file changed, 3 insertions(+)
--
2.18.0
Comments
Il 14/06/23 09:31, Hsiao Chien Sung ha scritto: > Add compatible name for MediaTek MT8188 MERGE. > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On 14/06/2023 09:31, Hsiao Chien Sung wrote: > Add compatible name for MediaTek MT8188 MERGE. > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> > --- > .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml > index eead5cb8636e..5c678695162e 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml > @@ -27,6 +27,9 @@ properties: > - items: > - const: mediatek,mt6795-disp-merge > - const: mediatek,mt8173-disp-merge > + - items: > + - const: mediatek,mt8188-disp-merge > + - const: mediatek,mt8195-disp-merge Linux next has something entirely different. I don't know the base here, but it's really, really different and it suggests you should add mt8188 to an enum with mt8173. Best regards, Krzysztof
Hi Krzysztof, Thanks for the reminder, because MT8188 is not related to MT8173, I’ll keep it as it is for now, however, I do find that MT8195 doesn’t exist in this dt-bindings which it should be, so there may be conflicts when this series is going to be merged. Best regards, Hsiao Chien Sung On Thu, 2023-06-15 at 10:28 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 14/06/2023 09:31, Hsiao Chien Sung wrote: > > Add compatible name for MediaTek MT8188 MERGE. > > > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> > > --- > > .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 3 > +++ > > 1 file changed, 3 insertions(+) > > > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.y > aml > b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.y > aml > > index eead5cb8636e..5c678695162e 100644 > > --- > a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.y > aml > > +++ > b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.y > aml > > @@ -27,6 +27,9 @@ properties: > > - items: > > - const: mediatek,mt6795-disp-merge > > - const: mediatek,mt8173-disp-merge > > + - items: > > + - const: mediatek,mt8188-disp-merge > > + - const: mediatek,mt8195-disp-merge > > Linux next has something entirely different. I don't know the base > here, > but it's really, really different and it suggests you should add > mt8188 > to an enum with mt8173. > > Best regards, > Krzysztof >
On 16/06/2023 07:29, Shawn Sung (宋孝謙) wrote: > Hi Krzysztof, > > Thanks for the reminder, because MT8188 is not related to MT8173, How does it matter? > I’ll > keep it as it is for now, however, I do find that MT8195 doesn’t exist > in this dt-bindings which it should be, so there may be conflicts when > this series is going to be merged. Don't top post. No, rebase on current next and implement my comment. Best regards, Krzysztof
On Fri, 2023-06-16 at 10:07 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 16/06/2023 07:29, Shawn Sung (宋孝謙) wrote: > > Hi Krzysztof, > > > > Thanks for the reminder, because MT8188 is not related to MT8173, > > How does it matter? Because MT8188 Merge is fully compatible with MT8195, we didn't add its compatible name to the driver, but just list it in dt-bindings, and use MT8195's compatible name to match the ID in device table. For example, in mt8188.dtsi: merge1: merge@1c10c000 { compatible = "mediatek,mt8188-disp-merge", "mediatek,mt8195- disp-merge"; ... }; If we add MT8188 Merge as an enum with MT8173, then our device tree must be as below, and nothing will match in Merge driver. merge1: merge@1c10c000 { compatible = "mediatek,mt8188-disp- merge"; ... }; > > > I’ll > > keep it as it is for now, however, I do find that MT8195 doesn’t > exist > > in this dt-bindings which it should be, so there may be conflicts > when > > this series is going to be merged. > > Don't top post. > > No, rebase on current next and implement my comment. Will rebase linux-next in the next version. > > Best regards, > Krzysztof > Best regards, Hsiao Chien Sung
On 16/06/2023 10:40, Shawn Sung (宋孝謙) wrote: > On Fri, 2023-06-16 at 10:07 +0200, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> On 16/06/2023 07:29, Shawn Sung (宋孝謙) wrote: >>> Hi Krzysztof, >>> >>> Thanks for the reminder, because MT8188 is not related to MT8173, >> >> How does it matter? > > Because MT8188 Merge is fully compatible with MT8195, we didn't add its > compatible name to the driver, but just list it in dt-bindings, and use > MT8195's compatible name to match the ID in device table. For example, > in mt8188.dtsi: > > merge1: merge@1c10c000 { > compatible = "mediatek,mt8188-disp-merge", "mediatek,mt8195- > disp-merge"; > ... > }; > > If we add MT8188 Merge as an enum with MT8173, then our device tree > must be as below, and nothing will match in Merge driver. > > merge1: merge@1c10c000 { > compatible = "mediatek,mt8188-disp- > merge"; > ... > }; No, why? It would be incorrect with existing bindings. Again, on what tree are you working? > >> >>> I’ll >>> keep it as it is for now, however, I do find that MT8195 doesn’t >> exist >>> in this dt-bindings which it should be, so there may be conflicts >> when >>> this series is going to be merged. >> >> Don't top post. >> >> No, rebase on current next and implement my comment. > > Will rebase linux-next in the next version. Rebase now - for this discussion. Best regards, Krzysztof
On Fri, 2023-06-16 at 11:31 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 16/06/2023 10:40, Shawn Sung (宋孝謙) wrote: > > On Fri, 2023-06-16 at 10:07 +0200, Krzysztof Kozlowski wrote: > >> > >> External email : Please do not click links or open attachments > until > >> you have verified the sender or the content. > >> On 16/06/2023 07:29, Shawn Sung (宋孝謙) wrote: > >>> Hi Krzysztof, > >>> > >>> Thanks for the reminder, because MT8188 is not related to MT8173, > >> > >> How does it matter? > > > > Because MT8188 Merge is fully compatible with MT8195, we didn't add > its > > compatible name to the driver, but just list it in dt-bindings, and > use > > MT8195's compatible name to match the ID in device table. For > example, > > in mt8188.dtsi: > > > > merge1: merge@1c10c000 { > > compatible = "mediatek,mt8188-disp-merge", > "mediatek,mt8195- > > disp-merge"; > > ... > > }; > > > > If we add MT8188 Merge as an enum with MT8173, then our device tree > > must be as below, and nothing will match in Merge driver. > > > > merge1: merge@1c10c000 { > > compatible = "mediatek,mt8188-disp- > > merge"; > > ... > > }; > > No, why? It would be incorrect with existing bindings. Again, on what > tree are you working? Just sent a v3 that is based on next-20230616 tag of linux-next/master branch. After checking, still not sure what is the difference between this modification and the others in mdp-rdma and ethdr. Could you share more information please? > > > > >> > >>> I’ll > >>> keep it as it is for now, however, I do find that MT8195 doesn’t > >> exist > >>> in this dt-bindings which it should be, so there may be conflicts > >> when > >>> this series is going to be merged. > >> > >> Don't top post. > >> > >> No, rebase on current next and implement my comment. > > > > Will rebase linux-next in the next version. > > Rebase now - for this discussion. Done. Please refer to v3. > > Best regards, > Krzysztof > Thanks, Hsiao Chien Sung
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml index eead5cb8636e..5c678695162e 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml @@ -27,6 +27,9 @@ properties: - items: - const: mediatek,mt6795-disp-merge - const: mediatek,mt8173-disp-merge + - items: + - const: mediatek,mt8188-disp-merge + - const: mediatek,mt8195-disp-merge reg: maxItems: 1