From patchwork Tue Jun 13 22:07:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 107586 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp853818vqr; Tue, 13 Jun 2023 15:11:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4ILa4cNbUINFGpd6H5Wt226EYES5eTdGGiyeImRRs9jJmNrcqm/1rTjQtmC0GyNXga0Qmm X-Received: by 2002:a05:6808:d49:b0:39c:6a30:cc88 with SMTP id w9-20020a0568080d4900b0039c6a30cc88mr10703564oik.23.1686694315123; Tue, 13 Jun 2023 15:11:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686694315; cv=none; d=google.com; s=arc-20160816; b=hmUTPddozQe5/hRrUmlou1Jkde1mwFWl4GgRvi7XTqZiKJ5s1EMdobMj1mw2YIZDD0 MhNTGqYnsFNmun5UdE8bTDsVTkmWJZkemCH9/Pmzsed12RokGnKze5aKmqV+ZZv06Mhq ywg1EkfCVOhiMb6AWhDtEnHbJwPLSGFT+2d4KQS2CPkVJcE+UyP3iLAoPJTamxNK2kjd 3MbDQUJGSLZ//jeF3QCFF9AqBOLCNBnuAnopBFJVK7sgf9rTvpayY1oqoQAKlvjCKDg/ RzRYX0XfO1lbniFLInNZdtoLFnMVAiC4612CSbWyQJqlQtW/8crK07Ai1qvjWZuGGKrV 0Bcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=H7OaegDH/bR1SfcqwCBcShH42GCdV+e1aK5VNxSH82Q=; b=amr3AipGa0sS1hyrFWrJMKzrsgyv2XudeaflYbGC1+j0CwWFoUkB8OqZluYTG1u7JR SicGQSyjpuvUZN8+SLWRSQR9/jORBcL+VcH/VQZL7SbVb8lPWTHEhaL6KmaOG6FpsiSi sZgXcm4EB4F+hO0mlGER5oWEeatIZ3gG1xKXVjwCJlqjNtyFLjqnwW0QonXiGB6J6DWf TP0rcBS0qvW7i1AHFtpuNJ6abXq3EO2Mv0TVcrG7UXUtgihHbuZGMs+iTOA2qGMYMj4+ QZ2+v80YFwVM3p06lQjaBfWFjrgMNbKOJBXXghSrWcH+PpdLnbcxQSfK0+h5leHEO9ua eebA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id md4-20020a17090b23c400b0025d54872955si575067pjb.183.2023.06.13.15.11.33; Tue, 13 Jun 2023 15:11:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238972AbjFMWIo (ORCPT + 99 others); Tue, 13 Jun 2023 18:08:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233282AbjFMWIb (ORCPT ); Tue, 13 Jun 2023 18:08:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B4001BCA for ; Tue, 13 Jun 2023 15:08:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9C3F663B88 for ; Tue, 13 Jun 2023 22:08:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13C6CC433CA; Tue, 13 Jun 2023 22:08:26 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1q9CBc-000EFo-3C; Tue, 13 Jun 2023 18:08:24 -0400 Message-ID: <20230613220824.813403175@goodmis.org> User-Agent: quilt/0.66 Date: Tue, 13 Jun 2023 18:07:58 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Daniel Bristot de Oliveira , William White , Jonathan Corbet , Juri Lelli Subject: [for-next][PATCH 08/11] rtla/hwnoise: Reduce runtime to 75% References: <20230613220750.330146797@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768627178189139470?= X-GMAIL-MSGID: =?utf-8?q?1768627178189139470?= From: Daniel Bristot de Oliveira osnoise runs 100% of time by default. It makes sense because osnoise is preemptive. hwnoise checks preemption once a second, so it reduces system progress. Reduce runtime to 75% to avoid problems by default. I added a Fixes as it might avoid problems for first time users as it lands on distros. Link: https://lkml.kernel.org/r/af0b7113ffc00031b9af4bb40ef5889a27dadf8c.1686066600.git.bristot@kernel.org Cc: William White Cc: Jonathan Corbet Tested-by: Juri Lelli Fixes: 1f428356c38d ("rtla: Add hwnoise tool") Signed-off-by: Daniel Bristot de Oliveira Signed-off-by: Steven Rostedt (Google) --- tools/tracing/rtla/src/osnoise_top.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/tracing/rtla/src/osnoise_top.c b/tools/tracing/rtla/src/osnoise_top.c index 85abba568faf..f7c959be8677 100644 --- a/tools/tracing/rtla/src/osnoise_top.c +++ b/tools/tracing/rtla/src/osnoise_top.c @@ -348,8 +348,14 @@ struct osnoise_top_params *osnoise_top_parse_args(int argc, char **argv) if (!params) exit(1); - if (strcmp(argv[0], "hwnoise") == 0) + if (strcmp(argv[0], "hwnoise") == 0) { params->mode = MODE_HWNOISE; + /* + * Reduce CPU usage for 75% to avoid killing the system. + */ + params->runtime = 750000; + params->period = 1000000; + } while (1) { static struct option long_options[] = {