From patchwork Tue Jun 13 20:39:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaegeuk Kim X-Patchwork-Id: 107548 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp836001vqr; Tue, 13 Jun 2023 14:32:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5lxBrAjBbl1w3A0LmuEkGCEsXgGU5cpGQp1NbM3BjKk37Cz61RKmefa9jLdMJIVrQZwmin X-Received: by 2002:a17:907:705:b0:974:56aa:6dce with SMTP id xb5-20020a170907070500b0097456aa6dcemr10466139ejb.46.1686691963415; Tue, 13 Jun 2023 14:32:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686691963; cv=none; d=google.com; s=arc-20160816; b=M9WPGSoe5+rghqdOtqXjx0Wjnf783d/TzlQ3+16lM3EudmLMDGy1NXOsS7YqcTVLUs zUh6yoj+oifvVaC5IYCjdHH/1R6WMzLD+mBbTaQybzuPHMso3jMymT5K/98NYj+zfT3p 41ORXq7ETy6A0W8axNdqVpBlzQLqrBd1fqryYwtx1Ix17uSWRLWeEcvnqr7h9LWUKoju 7RdIWoTcKNlruVow4bZuWllOIrx3Bm33TxeNTRPYjMc5+pQ1c5NhGFkVHVg0FW7x8bzo K7XvtGmIBZ0cypVLO682eBGBajyT1VciHX1kycBDbqfefT6J5gh2IHayt0kOqI+vr4Rf MY6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=HYEPHnKJZJwBllOOaE+wWwPcndapSn+SEdVnQ29R52I=; b=CZOShWpr0uDGcdLlRRYN/UZt1whLgPBOfsUuLt3anN2MN0erd6ItNgmbTglSaHfL2a 6DXu2z0bPOaemxAIwNT7hxf0qrraB3c9itMMg4kkisutvsCQZHdFQuXsg1WGK0Dk/n+S Hdsr2fpu4YnQhkq0xK7ROAlvS/GijM7m9O1m78Gwtj40I4pJnZGJZwGKe3IPIiwGhtbn VpbmWypxG5QWIZdQoxGfF7OLDDUTl6ZeJclca66+ofdZZXt6LooyKR5FtXXzfQ1/RlF1 1TxkR5EX0wsPVh5jS4v59AeQZAem5xbxdIW8sUsnfo4y0s+2XtThSvY8wR2LHGV8p4xd ixrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nZ9YV6tj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h21-20020a1709063c1500b00977cc7cec71si3379921ejg.285.2023.06.13.14.32.19; Tue, 13 Jun 2023 14:32:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nZ9YV6tj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233857AbjFMUkR (ORCPT + 99 others); Tue, 13 Jun 2023 16:40:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233864AbjFMUjv (ORCPT ); Tue, 13 Jun 2023 16:39:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A392EB8 for ; Tue, 13 Jun 2023 13:39:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 383D061337 for ; Tue, 13 Jun 2023 20:39:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 910F0C433C0; Tue, 13 Jun 2023 20:39:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686688789; bh=sLZ+P360Imf7bwyICslM2xpcRXFrq+wunkzXqiYuC6c=; h=From:To:Cc:Subject:Date:From; b=nZ9YV6tj3Y7La98xNEpw85oJMLL0gU6jsgf/cp7ApkpVAIGvgK6noVqsGG3xyy9Gu qcoPD2tHLvUPYABIyRfS7fHlQU9EEILPo0vYwdBWx2sCCWEkQIZjcMJNFeO9eqj2sP 73Qo3VEL0dr2ed1HPLZUgIVLNeAkLCRKj6dvVtchxtkHTNfnyn/IcY4u0gsI8qel8k mS5CKjoi8WAUQYkx8m7mDD1zIOMl6B8vDuaCeRRLrF38IBPr/da4aC7HQuA16C5rtS CkWfC0E0PkN0djNLLccF3WAUuZXccRiDUJ05GJ4hhRaHyhA3miYfEQE1/sg5rX/Vsi smDV0j5ZU5Vxw== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH] f2fs: do not issue small discard commands during checkpoint Date: Tue, 13 Jun 2023 13:39:47 -0700 Message-ID: <20230613203947.2745943-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.41.0.162.gfafddb0af9-goog MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768624712492201042?= X-GMAIL-MSGID: =?utf-8?q?1768624712492201042?= If there're huge # of small discards, this will increase checkpoint latency insanely. Let's issue small discards only by trim. Signed-off-by: Jaegeuk Kim Signed-off-by: Jaegeuk Kim Signed-off-by: Chao Yu --- fs/f2fs/segment.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 0c0c033c4bdd..ef46bb085385 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -2178,7 +2178,7 @@ void f2fs_clear_prefree_segments(struct f2fs_sb_info *sbi, } mutex_unlock(&dirty_i->seglist_lock); - if (!f2fs_block_unit_discard(sbi)) + if (!f2fs_block_unit_discard(sbi) || !force) goto wakeup; /* send small discards */ @@ -2192,8 +2192,7 @@ void f2fs_clear_prefree_segments(struct f2fs_sb_info *sbi, sbi->blocks_per_seg, cur_pos); len = next_pos - cur_pos; - if (f2fs_sb_has_blkzoned(sbi) || - (force && len < cpc->trim_minlen)) + if (f2fs_sb_has_blkzoned(sbi) || len < cpc->trim_minlen) goto skip; f2fs_issue_discard(sbi, entry->start_blkaddr + cur_pos,