From patchwork Tue Jun 13 07:45:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Iwai X-Patchwork-Id: 107169 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp376094vqr; Tue, 13 Jun 2023 01:05:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5hYOr/GjCOvZR1lqfDfkUrF2IS4yzzAG0XgKBTNqKtIlFp0SWAOie3EzLw0DLFGgtOkev+ X-Received: by 2002:a05:6a00:15d6:b0:63b:8afe:a4dc with SMTP id o22-20020a056a0015d600b0063b8afea4dcmr12155420pfu.30.1686643526460; Tue, 13 Jun 2023 01:05:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686643526; cv=none; d=google.com; s=arc-20160816; b=BUioc7SUMmBk/c3Gzc1kyI7Vueb+UZJx2o5ueqfDLO4pJqtnM6e55VLE/EvY3/M1DH /7207rLBUlWMZzW1ERPJzHEzStUuAEJjKqxzTtnIRAgZFGQBKEXcE7pxRjVRPqBhivq8 meZwA7JkqfqbrLdX/Bvt/XXzSwH0JDou7UJax0Ih0198WFuXZ4N6Sxw0t6JqlGBajp54 VC054xAOiA2z6TUdsQqkhkYJ+5iCyRZIFnAZNEc5CO6oJb32Ttm+x9F4hyj3RYnzw8cx OVMyvrE4FWTLhKv+/ZhwKkGpjGpBhFmyB2CirVHtmIfx1zLR3W3BAKZD4IEqnS8cnfCX YhnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=dJgC7IJsRwZThDR+MXRBPyItHeIWZPAve8xzVWCL4AA=; b=FsWjiVqHKKZUlqF9LAsxV7vCi9qM29810FIGqvdU8WFoqSKvXH6Bkknw+cKzg56YX2 cHDa6h/EcMkBW0qSUtYzSQ+qTNpqIEQsMViaDJaTbbHlJAD/dhEkC8FZYCjEZZMxrMQT s3VpHfiCM4BlHvGwLWb3UGQKb3L2B/toJdxMIafwW/YwcYh4lAAqTo9IEFs1cxdTpUZ2 ejloCsYa+0G15WKaR9oYpMNsJxb47E5exsiGBrAasIF6BDi/C8/HbmkfQrk+IQqHVRHp aIh4u/ir81QXBRU1EalERcAes2faBAgIDG8AydLrywJROs1M9Iat+Aik3/obEE+VEp1/ M4vQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=nofkgr7W; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=jQdDjp3X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h26-20020a056a00001a00b00659145ce601si4712637pfk.401.2023.06.13.01.05.13; Tue, 13 Jun 2023 01:05:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=nofkgr7W; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=jQdDjp3X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240670AbjFMHqJ (ORCPT + 99 others); Tue, 13 Jun 2023 03:46:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240723AbjFMHqA (ORCPT ); Tue, 13 Jun 2023 03:46:00 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7804119AE for ; Tue, 13 Jun 2023 00:45:25 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0BC4A1FD76; Tue, 13 Jun 2023 07:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686642324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=dJgC7IJsRwZThDR+MXRBPyItHeIWZPAve8xzVWCL4AA=; b=nofkgr7WVYo44MkQhB5D/5stT35GW4ushSOXVFwIwRQcDHwKvjAOuUQeVnwN4aB7FNo8+n zOn8MnM+pC6eMxX+nkc0xNi0t3jMwdfDOihU1P9QlzvPGy5IkfcziFXOJb5jTAyg6Kpp7u EiuRwJQScu78OWYcvozCSSkg8+vkoqw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686642324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=dJgC7IJsRwZThDR+MXRBPyItHeIWZPAve8xzVWCL4AA=; b=jQdDjp3X+OOoVnKP18S7Wq7otNDIDcV8t+BCIpB9v7+Y6rDausZKiY3Pw2z0q5wUi576Gk pXKHhtoTm8imgxAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CC58C13345; Tue, 13 Jun 2023 07:45:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id j2niMJMeiGTbHAAAMHmgww (envelope-from ); Tue, 13 Jun 2023 07:45:23 +0000 From: Takashi Iwai To: Mark Brown Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: [PATCH] regmap: maple: Don't sync read-only registers Date: Tue, 13 Jun 2023 09:45:11 +0200 Message-Id: <20230613074511.4476-1-tiwai@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768573922077024723?= X-GMAIL-MSGID: =?utf-8?q?1768573922077024723?= regcache_maple_sync() tries to sync all cached values no matter whether it's writable or not. OTOH, regache_sync_val() does care the wrtability and returns -EIO for a read-only register. This results in an error message like: snd_hda_codec_realtek hdaudioC0D0: Unable to sync register 0x2f0009. -5 and the sync loop is aborted incompletely. This patch adds the writable register check in the loop for addressing the bug. Fixes: f033c26de5a5 ("regmap: Add maple tree based register cache") Link: https://lore.kernel.org/r/877cs7g6f1.wl-tiwai@suse.de Signed-off-by: Takashi Iwai --- drivers/base/regmap/regcache-maple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/regmap/regcache-maple.c b/drivers/base/regmap/regcache-maple.c index c2e3a0f6c218..d2dad32dd399 100644 --- a/drivers/base/regmap/regcache-maple.c +++ b/drivers/base/regmap/regcache-maple.c @@ -203,6 +203,8 @@ static int regcache_maple_sync(struct regmap *map, unsigned int min, mas_for_each(&mas, entry, max) { for (r = max(mas.index, lmin); r <= min(mas.last, lmax); r++) { + if (!regmap_writeable(map, r)) + continue; mas_pause(&mas); rcu_read_unlock(); ret = regcache_sync_val(map, r, entry[r - mas.index]);