diff mbox series

[RESEND,v4,1/4] perf trace-event-info: Add tracepoint_id_to_name() helper

Message ID 20230613033946.103515-2-yangjihong1@huawei.com
State New
Headers
Series perf tools: Add printing perf_event_attr `config` and `id` symbol in perf_event_attr__fprintf() |

Commit Message

Yang Jihong June 13, 2023, 3:39 a.m. UTC 
  Add tracepoint_id_to_name() helper to search for the trace events directory
by given event id and return the corresponding tracepoint.

Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
---
 tools/perf/util/trace-event-info.c | 11 +++++++++++
 tools/perf/util/trace-event.h      |  6 ++++++
 2 files changed, 17 insertions(+)

Comments

Namhyung Kim June 20, 2023, 10:35 p.m. UTC | #1 
Hello,

On Mon, Jun 12, 2023 at 8:41 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>
> Add tracepoint_id_to_name() helper to search for the trace events directory
> by given event id and return the corresponding tracepoint.
>
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>  tools/perf/util/trace-event-info.c | 11 +++++++++++
>  tools/perf/util/trace-event.h      |  6 ++++++
>  2 files changed, 17 insertions(+)
>
> diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
> index c24b3a15e319..a7901f4a6654 100644
> --- a/tools/perf/util/trace-event-info.c
> +++ b/tools/perf/util/trace-event-info.c
> @@ -466,6 +466,17 @@ static struct tracepoint_path *tracepoint_id_to_path(u64 config)
>         return NULL;
>  }
>
> +char *tracepoint_id_to_name(u64 config)
> +{
> +       struct tracepoint_path *path = tracepoint_id_to_path(config);
> +       char *buf = NULL;
> +
> +       if (path && asprintf(&buf, "%s:%s", path->system, path->name) > 0)
> +               return buf;

I think we need to call put_tracepoints_path() before return.

Thanks,
Namhyung


> +
> +       return NULL;
> +}
> +
>  static struct tracepoint_path *tracepoint_name_to_path(const char *name)
>  {
>         struct tracepoint_path *path = zalloc(sizeof(*path));
> diff --git a/tools/perf/util/trace-event.h b/tools/perf/util/trace-event.h
> index a0cff184b1cd..a69ee29419f3 100644
> --- a/tools/perf/util/trace-event.h
> +++ b/tools/perf/util/trace-event.h
> @@ -62,6 +62,12 @@ unsigned long long eval_flag(const char *flag);
>
>  int read_tracing_data(int fd, struct list_head *pattrs);
>
> +/*
> + * Return the tracepoint name in the format "subsystem:event_name",
> + * callers should free the returned string.
> + */
> +char *tracepoint_id_to_name(u64 config);
> +
>  struct tracing_data {
>         /* size is only valid if temp is 'true' */
>         ssize_t size;
> --
> 2.30.GIT
>
Yang Jihong June 23, 2023, 5:27 a.m. UTC | #2 
Hello,

On 2023/6/21 6:35, Namhyung Kim wrote:
> Hello,
> 
> On Mon, Jun 12, 2023 at 8:41 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>>
>> Add tracepoint_id_to_name() helper to search for the trace events directory
>> by given event id and return the corresponding tracepoint.
>>
>> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>> ---
>>   tools/perf/util/trace-event-info.c | 11 +++++++++++
>>   tools/perf/util/trace-event.h      |  6 ++++++
>>   2 files changed, 17 insertions(+)
>>
>> diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
>> index c24b3a15e319..a7901f4a6654 100644
>> --- a/tools/perf/util/trace-event-info.c
>> +++ b/tools/perf/util/trace-event-info.c
>> @@ -466,6 +466,17 @@ static struct tracepoint_path *tracepoint_id_to_path(u64 config)
>>          return NULL;
>>   }
>>
>> +char *tracepoint_id_to_name(u64 config)
>> +{
>> +       struct tracepoint_path *path = tracepoint_id_to_path(config);
>> +       char *buf = NULL;
>> +
>> +       if (path && asprintf(&buf, "%s:%s", path->system, path->name) > 0)
>> +               return buf;
> 
> I think we need to call put_tracepoints_path() before return.

Yes, here need to free tracepoints path, will fix in next version.

Thanks,
Yang
diff mbox series

Patch

diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
index c24b3a15e319..a7901f4a6654 100644
--- a/tools/perf/util/trace-event-info.c
+++ b/tools/perf/util/trace-event-info.c
@@ -466,6 +466,17 @@  static struct tracepoint_path *tracepoint_id_to_path(u64 config)
 	return NULL;
 }
 
+char *tracepoint_id_to_name(u64 config)
+{
+	struct tracepoint_path *path = tracepoint_id_to_path(config);
+	char *buf = NULL;
+
+	if (path && asprintf(&buf, "%s:%s", path->system, path->name) > 0)
+		return buf;
+
+	return NULL;
+}
+
 static struct tracepoint_path *tracepoint_name_to_path(const char *name)
 {
 	struct tracepoint_path *path = zalloc(sizeof(*path));
diff --git a/tools/perf/util/trace-event.h b/tools/perf/util/trace-event.h
index a0cff184b1cd..a69ee29419f3 100644
--- a/tools/perf/util/trace-event.h
+++ b/tools/perf/util/trace-event.h
@@ -62,6 +62,12 @@  unsigned long long eval_flag(const char *flag);
 
 int read_tracing_data(int fd, struct list_head *pattrs);
 
+/*
+ * Return the tracepoint name in the format "subsystem:event_name",
+ * callers should free the returned string.
+ */
+char *tracepoint_id_to_name(u64 config);
+
 struct tracing_data {
 	/* size is only valid if temp is 'true' */
 	ssize_t size;