From patchwork Tue Jun 13 20:17:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 107538 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp807472vqr; Tue, 13 Jun 2023 13:31:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7TvNs5wP2i2zWrqupRF5ulKj8AIZO1MESn+o1lwPlournHHL/Gj5/mSWxokS7s4J5/Yzj3 X-Received: by 2002:a17:907:3f09:b0:982:46cc:6200 with SMTP id hq9-20020a1709073f0900b0098246cc6200mr1673351ejc.58.1686688306685; Tue, 13 Jun 2023 13:31:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686688306; cv=none; d=google.com; s=arc-20160816; b=BBsxZe3OG4gyHjmPwwu65dHIIpmBQInFODFpdDCG1S3s23nngq37RZht5vpY489sG7 T50sON31eeh2HCLvCP15nT+hy9asiorASdCPo6z2L3NmopArv0r0T/RPcq/vmYfKL5Bm l7TLlZLtnUetv3u26Qu8dwxNhNl9Mj+Tob9ki+sW7uDY8vbSNsadoy5We0chR94qtqco /SHaqfhIbnh8sGtb3+K9pTtug19Li06KT22paik8Vpnp2Xn6E9p1djkKjr1vMjQlqvwo pSZWwqsScl+TuzfQ+ZmG1acXsNZIeA/f5ABA8g316ziWUiNGGljrl6QvicJJi/5R1dca zf3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=tAC/y+uQ5V2oU+5vQ9kjky22bFdiCc3/kFBYk/kGN64=; b=zFDbFEBwMs34CiVu4Ptzhu5dC7OMIGD+GcoVuETRBVWTVRUUh+R5WaRyrlvTxmlFes h6HfuGmo1uCwuYXWN5HkJoUWndYC1Zi4qUcsBX1F8cWojGtdLVmWXWNjdFOOS/H0g9Ww Fo3wq8qGz0levX99gu2yt9/QqS8bJikJOl4PiIl5c29P1r+pbfPtW2x76XjZ1/WkpPgQ CIyaRUvDH6J4Ar3dgqjQjZIFRap/VBHrAn3NLEUai4A50KXiFuvrYQYLcPq2QA3j5Tbg oIApv0ATk1jWA1Xh8tww72ccWNYPLMsfUVKDDqq6/8ZgiLE3K+wAtYpFuaPbbnYmLapN o31Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WEpeg+qL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d27-20020a170906371b00b00974605cdff7si6882003ejc.605.2023.06.13.13.31.17; Tue, 13 Jun 2023 13:31:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WEpeg+qL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237893AbjFMUSL (ORCPT + 99 others); Tue, 13 Jun 2023 16:18:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234319AbjFMUSF (ORCPT ); Tue, 13 Jun 2023 16:18:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F7681980 for ; Tue, 13 Jun 2023 13:18:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1C63D63AA4 for ; Tue, 13 Jun 2023 20:18:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06020C433D9; Tue, 13 Jun 2023 20:18:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686687482; bh=WhDf+kiOS5aGuKfQUW/eJ+QBuABHGrCyRWVCjRn2dDA=; h=From:Date:Subject:References:In-Reply-To:To:From; b=WEpeg+qLFzsDtXVmweut5W1DguWjehSf3IVBlfEEC5VI5yCC+12DC1OIMLJpvzugu zQ+QOjBvRt/sL5P0xUXmAfCficmth4XFEJIAc1yTakGgc/VlndgTtyHrZMPxwrFOGx ch268kG7bRClsE+yKzXGKOIvz9NEvo2XD6wYAzr5/Pj/a5HVo7egDKLgjpsLuiCuU+ a3NLWdZQ+13qk3LkpNzbWXn7W7Vqha1lMp1b3ODLIynZtC685EtQ9pJuvYQPXchTWQ OoJCZONoESW4VeXShMOPGzJJdyFYL6nxpe1OMw+7soeW56HdkXZk1Q6/MLweeJvVPA uKuZmZF2kV9xA== From: Mark Brown Date: Tue, 13 Jun 2023 21:17:43 +0100 Subject: [PATCH 2/3] regmap: Add a test case for write only registers MIME-Version: 1.0 Message-Id: <20230613-regmap-kunit-read-write-v1-2-2db337c52827@kernel.org> References: <20230613-regmap-kunit-read-write-v1-0-2db337c52827@kernel.org> In-Reply-To: <20230613-regmap-kunit-read-write-v1-0-2db337c52827@kernel.org> To: linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.13-dev-c6835 X-Developer-Signature: v=1; a=openpgp-sha256; l=2087; i=broonie@kernel.org; h=from:subject:message-id; bh=WhDf+kiOS5aGuKfQUW/eJ+QBuABHGrCyRWVCjRn2dDA=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBkiM72N5yZTsPaXZCipx/1IPP5jFg2fekvhIb4EhIi TUR/LEqJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZIjO9gAKCRAk1otyXVSH0P9WB/ 93dMF8vQ5978ILOWs6dF215F8uwWjXb1gympEWm8GVV7VLqkzHMMZ+gJqcyWLKvCOkBLTEH9+oLSYV 8ANTje7h6yLATbj7puUUSFpSX+wTb4Qr29lW+EbDUBjZlglV6LeyhjJpS0JqU367KQtuMCOmKjzeUG GhR8eVyfVGRVnd3L8T6gqWoS8usrjqd+fAMlUlTE404zEp9kAxXp7zKJ+rPE8b3ivuO77w7rKAwNb+ WXf8oWy0d5EgBvOVvONVP2ZED5Hl9CQJ5JTUgAOStgZzrQByCFuZo++lcQrmnVuoP13ii76zuqSgPE YQtBkGy6TOOzZHRVZNegc7EguYulL/ X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768620877563567158?= X-GMAIL-MSGID: =?utf-8?q?1768620877563567158?= Validate that attempts to read from write only registers fail and don't somehow trigger spurious hardware accesses. Signed-off-by: Mark Brown --- drivers/base/regmap/regmap-kunit.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/drivers/base/regmap/regmap-kunit.c b/drivers/base/regmap/regmap-kunit.c index f5c175022a47..a1a1a9ce2e13 100644 --- a/drivers/base/regmap/regmap-kunit.c +++ b/drivers/base/regmap/regmap-kunit.c @@ -231,6 +231,37 @@ static void write_readonly(struct kunit *test) regmap_exit(map); } +static void read_writeonly(struct kunit *test) +{ + struct regcache_types *t = (struct regcache_types *)test->param_value; + struct regmap *map; + struct regmap_config config; + struct regmap_ram_data *data; + unsigned int val; + int i; + + config = test_regmap_config; + config.cache_type = t->type; + config.readable_reg = reg_5_false; + + map = gen_regmap(&config, &data); + KUNIT_ASSERT_FALSE(test, IS_ERR(map)); + if (IS_ERR(map)) + return; + + for (i = 0; i < BLOCK_TEST_SIZE; i++) + data->read[i] = false; + + /* Try to read all the registers, the writeonly one should fail */ + for (i = 0; i < BLOCK_TEST_SIZE; i++) + KUNIT_EXPECT_EQ(test, i != 5, regmap_read(map, i, &val) == 0); + + /* Did we trigger a hardware access? */ + KUNIT_EXPECT_FALSE(test, data->read[5]); + + regmap_exit(map); +} + static void reg_defaults(struct kunit *test) { struct regcache_types *t = (struct regcache_types *)test->param_value; @@ -1078,6 +1109,7 @@ static struct kunit_case regmap_test_cases[] = { KUNIT_CASE_PARAM(bulk_write, regcache_types_gen_params), KUNIT_CASE_PARAM(bulk_read, regcache_types_gen_params), KUNIT_CASE_PARAM(write_readonly, regcache_types_gen_params), + KUNIT_CASE_PARAM(read_writeonly, regcache_types_gen_params), KUNIT_CASE_PARAM(reg_defaults, regcache_types_gen_params), KUNIT_CASE_PARAM(reg_defaults_read_dev, regcache_types_gen_params), KUNIT_CASE_PARAM(register_patch, regcache_types_gen_params),