From patchwork Mon Jun 12 20:50:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 106877 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp134107vqr; Mon, 12 Jun 2023 14:09:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4JtR/q1Lcsbf8SSaeRFAFOg2rEUN8KbnSsx9PO4QL6Np1n+BcwliFeW8SmmEZvjb5ecQU9 X-Received: by 2002:a17:906:c150:b0:96f:f807:6af5 with SMTP id dp16-20020a170906c15000b0096ff8076af5mr9875314ejc.39.1686604165245; Mon, 12 Jun 2023 14:09:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686604165; cv=none; d=google.com; s=arc-20160816; b=XeOwicWcpLnZVfRGfQB3vJXLIab1j6rl1LRMVYRr+u86xg2tkEZeIpZrBWnoHIuOLu xgIn9xqlIiU6/t/NxfumIuTxfYpDtTGlDYQfJUzpTmR49grpFDpezN7oCxjx3jITa8bA cVROkxrRg36qH9CXyY6MteP5lMJeBUcBb1FmVvd8Qa6Vv04MqFE7d36ai/RI587nD2+j QxFr7d5ZHug546ordLQu5mKHMgGWXeXMXO5rySIRoOuDzwTSofH4FF6thLhN2welaZDY WD7EqV02+ScPn4j84btraPXcVkvDGuWKXpBaTIyupyfZKoLavi2HTiFUj9MD6r5GNQ90 rXMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VIfFepwKCald0+2zuro6TaFHeOPWtpPL0HPdGLcfrH4=; b=ysxsr2ZRCqI4uNIlucQVIOrXg/bcq7u90NABF6r3gLwWgppuRi4eM9k5Et0QVpkn0g r2yHBWsUVN9t7z8efWKTe2oOdK/waRbD3aUCCvR13CsnScARvT+4PxKgirXB3YlBQ2GL xqYPJgkrInDtNd4fjpM4qa/t3lrM2l7WIOkaGwuBJxub9PMen2fLllHFoQCzdwafGKmK DIXMJXqzYM24t9mhJTUPkQfGjnIO9YEJeZ6agCCmx5vEQ/ODzRuscYrbQ+4Gcbj381NC 096UU3EOUvSB0TclGO0DRV1lAyUmu3KvraJ4BMK/kxnBALXo3ZPtkyXL0++816hfxcpE GL/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bItv31sJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e15-20020a170906504f00b009784f00c5besi5449263ejk.263.2023.06.12.14.08.58; Mon, 12 Jun 2023 14:09:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bItv31sJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238589AbjFLU5K (ORCPT + 99 others); Mon, 12 Jun 2023 16:57:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238583AbjFLU4u (ORCPT ); Mon, 12 Jun 2023 16:56:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B331E54 for ; Mon, 12 Jun 2023 13:52:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5B02A62150 for ; Mon, 12 Jun 2023 20:50:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF844C433D2; Mon, 12 Jun 2023 20:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686603037; bh=+6bWbNlMMY6DSoL9TFRSEX0OALiJJGb4tKRRiWQ49+c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bItv31sJeirjsOFKBsE1dogUy5MHsWfB0+vvt2xRVGFKCPiCIXIgwpCMg7WjwxvzB 2eKvPoQ3X4RbxTdwdexd1N1i7GefSZNsPqf5yOBe/qtqeD3Trgli4BrYVR8fMdboi/ sWe/SED+XUtjw2EhHbM0rdMjqU9+gi9eMvIfamtECeAaxkEPx73mlhyIXGxWKP7G77 2azpPIoNEy42mvgL97b7Zom19DDqX8hpYT40t6dYatHUdBUOqUjr7AlbW+Bpz/LRZd Vp527MQpZNNVIDVBYYHBiY0BahikGz8PMwyXBJS/0/dePSlAQj/8OyUdGg4eV3y9tJ kLoWBlT1ceTfw== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 6C1BBCE09E7; Mon, 12 Jun 2023 13:50:37 -0700 (PDT) From: "Paul E. McKenney" To: peterz@infradead.org, jgross@suse.com, vschneid@redhat.com, yury.norov@gmail.com Cc: linux-kernel@vger.kernel.org, imran.f.khan@oracle.com, kernel-team@meta.com, "Paul E . McKenney" Subject: [PATCH csd-lock 1/2] smp: Reduce logging due to dump_stack of CSD waiters Date: Mon, 12 Jun 2023 13:50:35 -0700 Message-Id: <20230612205036.292542-1-paulmck@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <3ee27fe5-cbea-46b6-adb0-48c4dde92b4f@paulmck-laptop> References: <3ee27fe5-cbea-46b6-adb0-48c4dde92b4f@paulmck-laptop> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768532649377613138?= X-GMAIL-MSGID: =?utf-8?q?1768532649377613138?= From: Imran Khan If a waiter is waiting for CSD lock, its call stack will not change between first and subsequent hang detection for the same CSD lock. Therefore, do dump_stack only for first-time detection for a given waiter. This avoids excessive logging on systems with hundreds of CPUs where repetitive dump_stack from hundreds of CPUs would otherwise flood the console. Signed-off-by: Imran Khan Cc: Peter Zijlstra Cc: Juergen Gross Cc: Valentin Schneider Cc: Yury Norov Signed-off-by: Paul E. McKenney --- kernel/smp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/smp.c b/kernel/smp.c index ab3e5dad6cfe..b7ccba677a0a 100644 --- a/kernel/smp.c +++ b/kernel/smp.c @@ -248,7 +248,8 @@ static bool csd_lock_wait_toolong(struct __call_single_data *csd, u64 ts0, u64 * arch_send_call_function_single_ipi(cpu); } } - dump_stack(); + if (firsttime) + dump_stack(); *ts1 = ts2; return false;