From patchwork Mon Jun 12 19:56:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eddie James X-Patchwork-Id: 106798 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp110721vqr; Mon, 12 Jun 2023 13:16:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4nz3LRmsHOw3poIkMRA9X11H4m3yaMoq0amsuiBbgHiZWE3hiyEPb8ftwEkrl5YZkVjuUO X-Received: by 2002:a17:902:e842:b0:1b2:436b:931c with SMTP id t2-20020a170902e84200b001b2436b931cmr8875897plg.43.1686601003901; Mon, 12 Jun 2023 13:16:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686601003; cv=none; d=google.com; s=arc-20160816; b=GoEcMcsIoohpOjnGVzaTIz7+nczc6fTuIp4SQ/eN2pHG1zAEsGYP1jgZ338YZeQu2U ceokVHxmkfp3PfU8pPZyss/JoIKP0xjFW0zdLGTpJy9GuiKKJ/L7Xnyi9cNN/9uOd/Wo R6zBfYeNXhmkZVLNc7waW38XCLivY99GDQtqT4RVpsEkOPlXd5tHBFaRKOXLr5hVjmk5 83NJvVAIY8pZAN/QhoK/sESZaJuZYUkyPEmEdiaA5wMV2VdGTN88H1sYE8TgmelHQRfs V3/+Pdx+DZnr/3wHxg2YdnOD0OmhchduRuEgH1QGvLUnjQ8i26pJ5VmhDJHRXggzkoM+ Z7Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KJc0ydFTUgIwjCtrGuXVj0xPsA/uMLi0FjiGPI0kMbA=; b=baUnzdeJ/k5eFR/cFFAZFNyDU3hIo7EJFxQFC8FQxU7gcromnbA8zm7kuPmW7eHAnQ VfyuvPjS8v3EkbJNcEsZ/LqBSdiARiF9QQSaIP5AYAXi48UPIk9V+Q86OyVE1ESTHbdz ZnEo6DZHMOKma52wsGeKdAmwqcZ/XHUSpNbspET/jLcGGooKlxxZdB+W4KshXwKmwh+Y un7McTwPCbjIuv8JiOnawF0EywbVXAVJgaBUKVUBUfFSjrhI5DB0246WftoYuljuH9+6 skaxKCcYU9KfBoF1HOM+EaKJZeWOGD7yHWdiaQO5AZS+cLZZdI5vA8h1iU3RXbrmNLZi KrRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=Tfl4LEx5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a7-20020a170902ecc700b001b184b4bb75si7699097plh.381.2023.06.12.13.16.31; Mon, 12 Jun 2023 13:16:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=Tfl4LEx5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237901AbjFLT5X (ORCPT + 99 others); Mon, 12 Jun 2023 15:57:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230335AbjFLT5S (ORCPT ); Mon, 12 Jun 2023 15:57:18 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 843CEE73; Mon, 12 Jun 2023 12:57:16 -0700 (PDT) Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35CJohBC008964; Mon, 12 Jun 2023 19:57:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=KJc0ydFTUgIwjCtrGuXVj0xPsA/uMLi0FjiGPI0kMbA=; b=Tfl4LEx5WJPFrF8v3RmsR0L7Ibdu6uybHsxlWvkc0aKGApOX4iKVIjfqO41qtfd0gUCX g3heRBuyohwyUCQkiyTEnnK9jQ40p5zlR4B0tapHImtgTltK6wxpO5/FvhzgGW/MVaBI s4crqgJyD/DNeu2hZoRJAk6RFx9vvC0t5bkLjp0UDZjq0PRJ6s2cw0CAwfVfZRFKRwWa 0XLqLsjvlMWysibeHIU+v/Hg5l1Gufr7gY3fZyEWf15MT17jiZ82XTrufv7HfdK1Zb3m gxDkAwOoBIXeL7+infxifiDJ7duK8Z0LINv12wGks3i7DJwISxjRkmF9umjA1WHB8029 3g== Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r69vjr4a0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Jun 2023 19:57:02 +0000 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35CHmAC3014264; Mon, 12 Jun 2023 19:57:00 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([9.208.129.120]) by ppma05wdc.us.ibm.com (PPS) with ESMTPS id 3r4gt5cnbm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Jun 2023 19:57:00 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35CJuxkW65077646 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Jun 2023 19:56:59 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4CF0958059; Mon, 12 Jun 2023 19:56:59 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F1D5258055; Mon, 12 Jun 2023 19:56:58 +0000 (GMT) Received: from slate16.aus.stglabs.ibm.com (unknown [9.61.148.226]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 12 Jun 2023 19:56:58 +0000 (GMT) From: Eddie James To: linux-fsi@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org, jk@ozlabs.org, joel@jms.id.au, alistair@popple.id.au, andrew@aj.id.au, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org Subject: [PATCH 04/14] fsi: sbefifo: Don't check status during probe Date: Mon, 12 Jun 2023 14:56:47 -0500 Message-Id: <20230612195657.245125-5-eajames@linux.ibm.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230612195657.245125-1-eajames@linux.ibm.com> References: <20230612195657.245125-1-eajames@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 4lxnktf1tHCr6ncAOsF_YqNDseKc0u0D X-Proofpoint-ORIG-GUID: 4lxnktf1tHCr6ncAOsF_YqNDseKc0u0D X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-12_14,2023-06-12_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 mlxscore=0 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306120169 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768529334159021209?= X-GMAIL-MSGID: =?utf-8?q?1768529334159021209?= The status check during probe doesn't serve any purpose. Any attempt to use the SBEFIFO will result in the same check and cleanup. Signed-off-by: Eddie James --- drivers/fsi/fsi-sbefifo.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c index 9912b7a6a4b9..42d7c95528d1 100644 --- a/drivers/fsi/fsi-sbefifo.c +++ b/drivers/fsi/fsi-sbefifo.c @@ -1027,14 +1027,6 @@ static int sbefifo_probe(struct device *dev) mutex_init(&sbefifo->lock); sbefifo->timeout_start_rsp_ms = SBEFIFO_TIMEOUT_START_RSP; - /* - * Try cleaning up the FIFO. If this fails, we still register the - * driver and will try cleaning things up again on the next access. - */ - rc = sbefifo_cleanup_hw(sbefifo); - if (rc && rc != -ESHUTDOWN) - dev_err(dev, "Initial HW cleanup failed, will retry later\n"); - /* Create chardev for userspace access */ sbefifo->dev.type = &fsi_cdev_type; sbefifo->dev.parent = dev;