Message ID | 20230612182332.371003-1-sboyd@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp56826vqr; Mon, 12 Jun 2023 11:27:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6dk9kkkGxIb4sX5bBmJSnNPw/CnqYKuSlagmQLL3PTJfw8FS6T6k5CSWLgBBXx5kB7bKM2 X-Received: by 2002:a17:90a:8809:b0:253:4f8f:52fb with SMTP id s9-20020a17090a880900b002534f8f52fbmr16881133pjn.10.1686594474897; Mon, 12 Jun 2023 11:27:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686594474; cv=none; d=google.com; s=arc-20160816; b=rfeUXfSPHmOm0AkS519q9Vgc90fdOdfCDBnEy5A7gnK+H4vK8rZ+vAF03Sv1k5cE8F 8roLuvxifjpTAt9rkfuz8d1+OiiwkgtpacUzS8Oi7UNBdIlpQqxFAsmFWzXAfRmAKC3l ZZmSgYUt+F5R9Gx0KFNa84e1ApUO/dg9VHjFY754rwPKcAqJzPnvAKZqppyW90uOLDYi vzGfGZorhSvXSW9S32gHFk9bfAIqu0Up3a/GTc9Kj0UjJxskpbTU+dNDZU3A9gJzKw0U GlgS0V4BdgBhOGbbsBMkIBxuEdsu//mfC6OdKgq0Xlladqw3FMQ5Jexlwg2SiHtv3aKA KPWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=FhJ5Blhaa7E58UThPLLHHPHCzmw4IU7MI7HXSrPpdOc=; b=kLyHnLfp2tz1hoKoRADT/ev/IkXeL7iDV9ogYhQ0RQybdd30trHlDvQeaeYFi3laAz DBSPSPMrHmEnf2omVsihMnD7arpQXzfZ2WziohybtlV5OY8V6HatppU4hflEgA1BdS/V ItUxge/60n9qNlUDTJd5d3ct/AX0f7q5qlygvosMXENBWHWoTeferwp8dwFoeFbhHabr W0pm3PYfrNyV+kiqXS+gGZSlIx/dk3EUqNGUXhQvlka0OeeAq/1vq1p6+8z3BaTzeb/0 sJ1BT87qNMhQyQmHz+NcBGnM8zKavv/yASKBbd1/yLcjAKc8bCZWKWTyeNGEYk0lvDSq +cOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="iQqK/iw2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ji13-20020a170903324d00b001ac6b926624si7092735plb.122.2023.06.12.11.27.42; Mon, 12 Jun 2023 11:27:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="iQqK/iw2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237557AbjFLSXi (ORCPT <rfc822;rust.linux@gmail.com> + 99 others); Mon, 12 Jun 2023 14:23:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237551AbjFLSXg (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 12 Jun 2023 14:23:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 156E5E0; Mon, 12 Jun 2023 11:23:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8B86862CC9; Mon, 12 Jun 2023 18:23:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5B7CC433D2; Mon, 12 Jun 2023 18:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686594214; bh=0ia4DOXRQlpxbsvixuJZP92w3Mu5z3zc9q4s1AOUnDc=; h=From:To:Cc:Subject:Date:From; b=iQqK/iw2pw+Igfn7d9j8xQ8+HbK07/0/uCJLT6erT9jqHOqpdOn9NLk+g8CuYNCIp zRILIyb9jt7Um7NA0jf1/018qJ4cHKP1K1XrZ0Bkgo/LsXFh9e0Uvq+r19R+DXvCup Dlcnn1YvVWcA2gELwVl+8UOR4Ha3nbFT1G5z2KMXTcqYdypN1w06bu4jkz/HXT+8bh UbUnn6HR8NBceZEsdxxBIOr06jf6DxbTAUE8ggsN3wHzYYBRY8mvHuHSLYB1DjqtDf 9qxjQrPiAmiq+t55MDSRr7UVJm2Yew0Zu7NhzEaNSwwz5YDeWt5UcMFZZNcKZCMIIH 5lpIh0hQ4acuA== From: Stephen Boyd <sboyd@kernel.org> To: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org> Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, Jian Hu <jian.hu@amlogic.com>, Dmitry Rokosov <ddrokosov@sberdevices.ru>, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, Jerome Brunet <jbrunet@baylibre.com> Subject: [PATCH] clk: meson: a1: Staticize rtc clk Date: Mon, 12 Jun 2023 11:23:32 -0700 Message-ID: <20230612182332.371003-1-sboyd@kernel.org> X-Mailer: git-send-email 2.41.0.162.gfafddb0af9-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768522487795831670?= X-GMAIL-MSGID: =?utf-8?q?1768522487795831670?= |
Series |
clk: meson: a1: Staticize rtc clk
|
|
Commit Message
Stephen Boyd
June 12, 2023, 6:23 p.m. UTC
Sparse rightly complains that this symbol is supposed to be static.
Cc: Jian Hu <jian.hu@amlogic.com>
Cc: Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
drivers/clk/meson/a1-peripherals.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon 12 Jun 2023 at 11:23, Stephen Boyd <sboyd@kernel.org> wrote: > Sparse rightly complains that this symbol is supposed to be static. > > Cc: Jian Hu <jian.hu@amlogic.com> > Cc: Dmitry Rokosov <ddrokosov@sberdevices.ru> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Jerome Brunet <jbrunet@baylibre.com> > Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver") > Signed-off-by: Stephen Boyd <sboyd@kernel.org> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com> Sorry this got through. > --- > drivers/clk/meson/a1-peripherals.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/meson/a1-peripherals.c b/drivers/clk/meson/a1-peripherals.c > index b320134fefeb..75dfae210fe5 100644 > --- a/drivers/clk/meson/a1-peripherals.c > +++ b/drivers/clk/meson/a1-peripherals.c > @@ -218,7 +218,7 @@ static struct clk_regmap rtc_32k_sel = { > }, > }; > > -struct clk_regmap rtc = { > +static struct clk_regmap rtc = { > .data = &(struct clk_regmap_gate_data){ > .offset = RTC_BY_OSCIN_CTRL0, > .bit_idx = 30,
On Mon, Jun 12, 2023 at 8:23 PM Stephen Boyd <sboyd@kernel.org> wrote: > > Sparse rightly complains that this symbol is supposed to be static. > > Cc: Jian Hu <jian.hu@amlogic.com> > Cc: Dmitry Rokosov <ddrokosov@sberdevices.ru> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Jerome Brunet <jbrunet@baylibre.com> > Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver") > Signed-off-by: Stephen Boyd <sboyd@kernel.org> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Thanks for providing a fix so quickly! Jerome, I think it's easiest for Stephen to apply this patch directly to the clock tree. In my opinion there's no reason against this since our own patch queue is empty. Best regards, Martin
Quoting Stephen Boyd (2023-06-12 11:23:32) > Sparse rightly complains that this symbol is supposed to be static. > > Cc: Jian Hu <jian.hu@amlogic.com> > Cc: Dmitry Rokosov <ddrokosov@sberdevices.ru> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Jerome Brunet <jbrunet@baylibre.com> > Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver") > Signed-off-by: Stephen Boyd <sboyd@kernel.org> > --- Applied to clk-next
diff --git a/drivers/clk/meson/a1-peripherals.c b/drivers/clk/meson/a1-peripherals.c index b320134fefeb..75dfae210fe5 100644 --- a/drivers/clk/meson/a1-peripherals.c +++ b/drivers/clk/meson/a1-peripherals.c @@ -218,7 +218,7 @@ static struct clk_regmap rtc_32k_sel = { }, }; -struct clk_regmap rtc = { +static struct clk_regmap rtc = { .data = &(struct clk_regmap_gate_data){ .offset = RTC_BY_OSCIN_CTRL0, .bit_idx = 30,