diff mbox series

power: supply: rk817: Add missing module alias

Message ID 20230612143651.959646-2-frattaroli.nicolas@gmail.com
State New
Headers
Series power: supply: rk817: Add missing module alias |

Commit Message

Nicolas Frattaroli June 12, 2023, 2:36 p.m. UTC 
  Similar to the rk817 codec alias that was missing, the rk817 charger
driver is missing a module alias as well. This absence prevents the
driver from autoprobing on OF systems when it is built as a module.

Add the right MODULE_ALIAS to fix this.

Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817")
Cc: stable@vger.kernel.org
Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
---
 drivers/power/supply/rk817_charger.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Chris Morgan June 27, 2023, 5:39 p.m. UTC | #1 
On Mon, Jun 12, 2023 at 04:36:52PM +0200, Nicolas Frattaroli wrote:
> Similar to the rk817 codec alias that was missing, the rk817 charger
> driver is missing a module alias as well. This absence prevents the
> driver from autoprobing on OF systems when it is built as a module.
> 
> Add the right MODULE_ALIAS to fix this.
> 

Good catch, thank you.

Reviewed-by: Chris Morgan <macromorgan@hotmail.com>

> Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817")
> Cc: stable@vger.kernel.org
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> ---
>  drivers/power/supply/rk817_charger.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
> index 1a2143641e66..76b991e112da 100644
> --- a/drivers/power/supply/rk817_charger.c
> +++ b/drivers/power/supply/rk817_charger.c
> @@ -1211,3 +1211,4 @@ MODULE_DESCRIPTION("Battery power supply driver for RK817 PMIC");
>  MODULE_AUTHOR("Maya Matuszczyk <maccraft123mc@gmail.com>");
>  MODULE_AUTHOR("Chris Morgan <macromorgan@hotmail.com>");
>  MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:rk817-charger");
> -- 
> 2.41.0
>
Sebastian Reichel Sept. 14, 2023, 4:03 p.m. UTC | #2 
On Mon, 12 Jun 2023 16:36:52 +0200, Nicolas Frattaroli wrote:
> Similar to the rk817 codec alias that was missing, the rk817 charger
> driver is missing a module alias as well. This absence prevents the
> driver from autoprobing on OF systems when it is built as a module.
> 
> Add the right MODULE_ALIAS to fix this.
> 
> 
> [...]

Applied, thanks!

[1/1] power: supply: rk817: Add missing module alias
      commit: cbcdfbf5a6cd66e47e5ee5d49c4c5a27a07ba082

Best regards,
diff mbox series

Patch

diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
index 1a2143641e66..76b991e112da 100644
--- a/drivers/power/supply/rk817_charger.c
+++ b/drivers/power/supply/rk817_charger.c
@@ -1211,3 +1211,4 @@  MODULE_DESCRIPTION("Battery power supply driver for RK817 PMIC");
 MODULE_AUTHOR("Maya Matuszczyk <maccraft123mc@gmail.com>");
 MODULE_AUTHOR("Chris Morgan <macromorgan@hotmail.com>");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:rk817-charger");