From patchwork Mon Jun 12 14:29:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Wagner X-Patchwork-Id: 106667 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2662703vqr; Mon, 12 Jun 2023 08:19:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ601QQ1dHokhqXBPxepQ0qO3kkP1a7Yjwz5oHD/nvfh6MvGkQA1Pbp6GGmMuXGLaZDTertI X-Received: by 2002:a2e:9889:0:b0:2b1:e668:30c6 with SMTP id b9-20020a2e9889000000b002b1e66830c6mr3200812ljj.34.1686583180577; Mon, 12 Jun 2023 08:19:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686583180; cv=none; d=google.com; s=arc-20160816; b=XH1WwRbtVsRih4jsYKRW6v6hlrfgD9a9tPtbRnGqbJPEcJqdR/uAKFYdVDN/C+2N8L TYOqPioQ1gTQlV5KkUhKUnUvyngLgC044laLgtDcj0LunqeY74Cwz/gByv5qxiCuP3kZ ShzfwpZ5CrJEgsG5i3XjGuwZQMkZOobUmoeXUYe3GbRTTB7nhm07QBaebOy1n6SKabkY 9BcoKv+OC2kROG2n+dsFgP6fQsz232gDYhBQ3n32b9RvbzoMzeo3yxGdRtAV78IjRH0J 3BUYKFr5IMPWNzTuT1UhN8iBYAErMwCezDDi84e+v1Ud193L8rSjpb33uWwMsBTX9L1T l0rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=ez66F1snArM9P0uDmhUnqyiFlGNOsdEpoDZ1RavyOTI=; b=NZPtSWq2UgEQyx5LKYfvN2PKTCth4EFAQjsdriYTrjgNwqPToZk2g9uqybum5T81sy jSiS/mo0mdvhfHnWBtO4Ae1HSf3nPbI7gP2RutelwD6KaNVP9dt6/k+NH1OeQ8d5zggY g1VeJ7ljStH+0BBeMs3sQNV5JL2q1DVXo5WIyFQiYdBNzA8Tqyvcr8pO3JdKGXpeLQRn dggRBVc5e2VQhOUc6kaPQp88dPU3Drm75LopNFTHALQtIcqPLzH2lSwI9eQVKJt0N20P iIDrU3qmzEu2XYYDX/liwYvM2NYu95vlvw2XZ1gKaiwNydtOg+msWs7kqfxb4ZOa+hqo yeGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=uMCG4NIp; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=JiMidvkX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t16-20020a170906949000b0096f7b49dad1si6064810ejx.358.2023.06.12.08.19.16; Mon, 12 Jun 2023 08:19:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=uMCG4NIp; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=JiMidvkX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238641AbjFLOcp (ORCPT + 99 others); Mon, 12 Jun 2023 10:32:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238291AbjFLOcZ (ORCPT ); Mon, 12 Jun 2023 10:32:25 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACB4A420B; Mon, 12 Jun 2023 07:31:05 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 089F72030A; Mon, 12 Jun 2023 14:30:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686580216; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ez66F1snArM9P0uDmhUnqyiFlGNOsdEpoDZ1RavyOTI=; b=uMCG4NIphRz5S9uoYRnrCKvCoLcECjXLKwv/y+2qRIDSRCUEZB/s3XnMysKHqh1rorDplR o6uoD5y4crk/iS3qWSpk0cohTfUEv5zH2L6lm+KHby8xOeA3LwnkK6QJFg2MAl6Z4RmZON gBo5wTc0XPDLbeO0n4SFCKd/6r71Dv0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686580216; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ez66F1snArM9P0uDmhUnqyiFlGNOsdEpoDZ1RavyOTI=; b=JiMidvkXJ3mEhkDjsK2YlVtA/LX5S4jU+WNFUTcO6nJnPx0/wh8pvt9y4ZKBHQUU+dsZ7r N301rxdG4Tsiw9Bw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ED40B1357F; Mon, 12 Jun 2023 14:30:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id p6GzOfcrh2RrIQAAMHmgww (envelope-from ); Mon, 12 Jun 2023 14:30:15 +0000 From: Daniel Wagner To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Chaitanya Kulkarni , Shin'ichiro Kawasaki , Sagi Grimberg , Hannes Reinecke , Daniel Wagner Subject: [PATCH blktests v1] nvme/040: Free loop back resources Date: Mon, 12 Jun 2023 16:29:45 +0200 Message-Id: <20230612142945.10969-1-dwagner@suse.de> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768510644973190580?= X-GMAIL-MSGID: =?utf-8?q?1768510644973190580?= The tests does not cleanup all resources after it has finished. This leads to rm not being able to remove the TMPDIR cleanly: + rm -rf blktests/results/tmpdir.nvme.040.m2J rm: cannot remove 'blktests/results/tmpdir.nvme.040.m2J': Directory not empty Signed-off-by: Daniel Wagner --- tests/nvme/040 | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/nvme/040 b/tests/nvme/040 index b6ab34d611ba..688a0939a376 100755 --- a/tests/nvme/040 +++ b/tests/nvme/040 @@ -18,6 +18,7 @@ requires() { test() { local subsys="blktests-subsystem-1" + local file_path="${TMPDIR}/img" local port local loop_dev local nvmedev @@ -26,8 +27,8 @@ test() { echo "Running ${TEST_NAME}" _setup_nvmet - truncate -s "${nvme_img_size}" "$TMPDIR/img" - loop_dev="$(losetup -f --show "$TMPDIR/img")" + truncate -s "${nvme_img_size}" "${file_path}" + loop_dev="$(losetup -f --show "${file_path}")" port="$(_create_nvmet_port "${nvme_trtype}")" _create_nvmet_subsystem "${subsys}" "${loop_dev}" @@ -57,5 +58,9 @@ test() { _remove_nvmet_subsystem "${subsys}" _remove_nvmet_port "${port}" + losetup -d "${loop_dev}" + + rm -f "${file_path}" + echo "Test complete" }