From patchwork Mon Jun 12 14:07:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 106606 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2620025vqr; Mon, 12 Jun 2023 07:15:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ53/LcnRa0bDt2MStxQPhr0rhDmi7kJFv3Tw4mP+8ywMpsg8YTQYOqSdbJ3J3G5jBoztmvj X-Received: by 2002:a19:d612:0:b0:4f7:4446:c333 with SMTP id n18-20020a19d612000000b004f74446c333mr1892433lfg.62.1686579322462; Mon, 12 Jun 2023 07:15:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686579322; cv=none; d=google.com; s=arc-20160816; b=t2MQZjz2LhPPplH4cBOaixjj/4kWm4FvfOAQCpV1vGrZuRe7SLJlw0vRNIVpGpauzT 7G1mO4X/+esU7W0vsJD23HAgUmpw8hVKjqyij0jUkiGhDB31QxNeSZjjeZeFdJmzROEj Yn242f4bD2ifpf/xJRkRvZZDp+iJKqEIB7D0tCiK+cdpDco6G3/OhFcxSWHFoDkVoivn rnXVVKzSIwNzCsvAaWz7BksDlWAFeSdhhRh9Os9daDsKdbLocKcuqip3DDYS2LtLjCJ7 4DcMM2OLGLvtBnP1jPex9u9FoPI7iKkYcLAlmZ2E26o1rc/QRhpPi0fYW2Ss9EN75PM0 smZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=3sJSCjaVrA7kDwsrSwIFOa10blfEXLpB2Uw9gtvLkjg=; b=KYgJpZ8YOXb/430ZegNU1ZT8SAxbcleiUowEHz5eeRFMWNDxCUELnjR8mWfGmPGfK4 jMx6s4qsAKqB7K2F1ylJcl3/CA0XX2UzaIrOlMsz/EbmAX8n8OJx8o6PIGfBh/JaD/m4 3B88OrHE5binhlGvKk7Xz7eZIaNJlLNGkC/kvg2EMOtrAZc+pbzTXTcTmoMXUDvvm+wA kyD1tCPWVY2T6r4tmffFZbvaLzSVVuEQcONgkcnB8klByGUNUf3MJ4VGwVm03GUJxYNJ f7AyHHAQUIz+5m1az2k61vrAJXKo6/4gCo3pwF82Z8uyN7luk29emPbkQNCfSE1c6Dpu yrtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=hSBd0hsG; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bo7-20020a0564020b2700b00514ad913e9csi6143185edb.99.2023.06.12.07.14.57; Mon, 12 Jun 2023 07:15:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=hSBd0hsG; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237426AbjFLOOL (ORCPT + 99 others); Mon, 12 Jun 2023 10:14:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237238AbjFLON5 (ORCPT ); Mon, 12 Jun 2023 10:13:57 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D3DA19C; Mon, 12 Jun 2023 07:13:56 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E923D2271D; Mon, 12 Jun 2023 14:13:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686579234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3sJSCjaVrA7kDwsrSwIFOa10blfEXLpB2Uw9gtvLkjg=; b=hSBd0hsGveWAwWxApwvgqEoJMAbiHbtdo6ToeFC9hidvZd4Dj3dh9eMWiZ9HXxb6304RoF qm+dmkUJq5oihn7VHddM/vf0lwkeUfkKEzMPJvCv6rJkewBDlvJlNBIEPVO/axkFuF5P9/ SlpLfIpSmocHahtOoniSdFfgRnK02Lw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686579234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3sJSCjaVrA7kDwsrSwIFOa10blfEXLpB2Uw9gtvLkjg=; b=S1Jgo2ktxPghsHrzmX5ucnsVoDw+3nWTiUxOOv9/3vDPBmzJHmE070HuxLR1cReJdfmdMM tC1mAtvhCy6U1dBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7A36A13A67; Mon, 12 Jun 2023 14:13:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kLPCHCIoh2RwGQAAMHmgww (envelope-from ); Mon, 12 Jun 2023 14:13:54 +0000 From: Thomas Zimmermann To: daniel@ffwll.ch, javierm@redhat.com, sam@ravnborg.org, deller@gmx.de, geert+renesas@glider.be, lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, dan.carpenter@linaro.org, michael.j.ruhl@intel.com Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Thomas Zimmermann , Laurent Pinchart , stable@vger.kernel.org Subject: [PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device Date: Mon, 12 Jun 2023 16:07:39 +0200 Message-ID: <20230612141352.29939-2-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230612141352.29939-1-tzimmermann@suse.de> References: <20230612141352.29939-1-tzimmermann@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768506599958287641?= X-GMAIL-MSGID: =?utf-8?q?1768506599958287641?= Struct bd6107_platform_data refers to a platform device within the Linux device hierarchy. The test in bd6107_backlight_check_fb() compares it against the fbdev device in struct fb_info.dev, which is different. Fix the test by comparing to struct fb_info.device. Fixes a bug in the backlight driver and prepares fbdev for making struct fb_info.dev optional. v2: * move renames into separate patch (Javier, Sam, Michael) Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver") Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Cc: dri-devel@lists.freedesktop.org Cc: # v3.12+ Reviewed-by: Javier Martinez Canillas Reviewed-by: Daniel Thompson --- drivers/video/backlight/bd6107.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/bd6107.c b/drivers/video/backlight/bd6107.c index f4db6c064635b..e3410444ea235 100644 --- a/drivers/video/backlight/bd6107.c +++ b/drivers/video/backlight/bd6107.c @@ -104,7 +104,7 @@ static int bd6107_backlight_check_fb(struct backlight_device *backlight, { struct bd6107 *bd = bl_get_data(backlight); - return bd->pdata->fbdev == NULL || bd->pdata->fbdev == info->dev; + return bd->pdata->fbdev == NULL || bd->pdata->fbdev == info->device; } static const struct backlight_ops bd6107_backlight_ops = {