[3/7] ASoC: mediatek: mt79xx: add platform driver
Commit Message
From: Maso Huang <maso.huang@mediatek.com>
Add mt79xx platform driver.
Signed-off-by: Maso Huang <maso.huang@mediatek.com>
---
sound/soc/mediatek/Kconfig | 10 +
sound/soc/mediatek/Makefile | 1 +
sound/soc/mediatek/mt79xx/Makefile | 9 +
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c | 608 +++++++++++++++++++++
4 files changed, 628 insertions(+)
create mode 100644 sound/soc/mediatek/mt79xx/Makefile
create mode 100644 sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c
Comments
Il 12/06/23 12:52, Maso Hunag ha scritto:
> From: Maso Huang <maso.huang@mediatek.com>
>
> Add mt79xx platform driver.
>
> Signed-off-by: Maso Huang <maso.huang@mediatek.com>
> ---
> sound/soc/mediatek/Kconfig | 10 +
> sound/soc/mediatek/Makefile | 1 +
> sound/soc/mediatek/mt79xx/Makefile | 9 +
> sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c | 608 +++++++++++++++++++++
> 4 files changed, 628 insertions(+)
> create mode 100644 sound/soc/mediatek/mt79xx/Makefile
> create mode 100644 sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c
>
..snip..
> diff --git a/sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c b/sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c
> new file mode 100644
> index 000000000000..69c5f3f3f84b
> --- /dev/null
> +++ b/sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c
> @@ -0,0 +1,608 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * MediaTek ALSA SoC AFE platform driver for MT79xx
> + *
> + * Copyright (c) 2021 MediaTek Inc.
> + * Author: Vic Wu <vic.wu@mediatek.com>
> + * Maso Huang <maso.huang@mediatek.com>
> + */
> +
> +#include <linux/delay.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/of_address.h>
> +#include <linux/pm_runtime.h>
> +
> +#include "mt79xx-afe-common.h"
> +#include "mt79xx-afe-clk.h"
> +#include "mt79xx-reg.h"
> +#include "../common/mtk-afe-platform-driver.h"
> +#include "../common/mtk-afe-fe-dai.h"
> +
> +enum {
> + MTK_AFE_RATE_8K = 0,
> + MTK_AFE_RATE_11K = 1,
> + MTK_AFE_RATE_12K = 2,
> + MTK_AFE_RATE_16K = 4,
> + MTK_AFE_RATE_22K = 5,
> + MTK_AFE_RATE_24K = 6,
> + MTK_AFE_RATE_32K = 8,
> + MTK_AFE_RATE_44K = 9,
> + MTK_AFE_RATE_48K = 10,
> + MTK_AFE_RATE_88K = 13,
> + MTK_AFE_RATE_96K = 14,
> + MTK_AFE_RATE_176K = 17,
> + MTK_AFE_RATE_192K = 18,
> +};
> +
> +unsigned int mt79xx_afe_rate_transform(struct device *dev,
> + unsigned int rate)
> +{
> + switch (rate) {
> + case 8000:
> + return MTK_AFE_RATE_8K;
> + case 11025:
> + return MTK_AFE_RATE_11K;
> + case 12000:
> + return MTK_AFE_RATE_12K;
> + case 16000:
> + return MTK_AFE_RATE_16K;
> + case 22050:
> + return MTK_AFE_RATE_22K;
> + case 24000:
> + return MTK_AFE_RATE_24K;
> + case 32000:
> + return MTK_AFE_RATE_32K;
> + case 44100:
> + return MTK_AFE_RATE_44K;
> + case 48000:
> + return MTK_AFE_RATE_48K;
> + case 88200:
> + return MTK_AFE_RATE_88K;
> + case 96000:
> + return MTK_AFE_RATE_96K;
> + case 176400:
> + return MTK_AFE_RATE_176K;
> + case 192000:
> + return MTK_AFE_RATE_192K;
> + default:
> + dev_warn(dev, "%s(), rate %u invalid, use %d!!!\n",
> + __func__, rate, MTK_AFE_RATE_48K);
> + return MTK_AFE_RATE_48K;
> + }
> +}
> +
> +static const struct snd_pcm_hardware mt79xx_afe_hardware = {
> + .info = SNDRV_PCM_INFO_MMAP |
> + SNDRV_PCM_INFO_INTERLEAVED |
> + SNDRV_PCM_INFO_MMAP_VALID,
> + .formats = SNDRV_PCM_FMTBIT_S16_LE |
> + SNDRV_PCM_FMTBIT_S24_LE |
> + SNDRV_PCM_FMTBIT_S32_LE,
> + .period_bytes_min = 256,
> + .period_bytes_max = 4 * 48 * 1024,
> + .periods_min = 2,
> + .periods_max = 256,
> + .buffer_bytes_max = 8 * 48 * 1024,
> + .fifo_size = 0,
> +};
> +
> +static int mt79xx_memif_fs(struct snd_pcm_substream *substream,
> + unsigned int rate)
> +{
> + struct snd_soc_pcm_runtime *rtd = substream->private_data;
> + struct snd_soc_component *component =
> + snd_soc_rtdcom_lookup(rtd, AFE_PCM_NAME);
Fits in one line.
> + struct mtk_base_afe *afe = snd_soc_component_get_drvdata(component);
> +
> + return mt79xx_afe_rate_transform(afe->dev, rate);
> +}
> +
> +static int mt79xx_irq_fs(struct snd_pcm_substream *substream,
> + unsigned int rate)
> +{
> + struct snd_soc_pcm_runtime *rtd = substream->private_data;
> + struct snd_soc_component *component =
> + snd_soc_rtdcom_lookup(rtd, AFE_PCM_NAME);
Fits in one line.
> + struct mtk_base_afe *afe = snd_soc_component_get_drvdata(component);
> +
> + return mt79xx_afe_rate_transform(afe->dev, rate);
> +}
> +
..snip..
> +
> +static irqreturn_t mt79xx_afe_irq_handler(int irq_id, void *dev)
> +{
> + struct mtk_base_afe *afe = dev;
> + struct mtk_base_afe_irq *irq;
> + unsigned int status;
> + unsigned int status_mcu;
> + unsigned int mcu_en;
u32 mcu_en, status, status_mcu;
int i, ret;
irqreturn_t irq_ret = IRQ_HANDLED;
> + int ret;
> + int i;
> + irqreturn_t irq_ret = IRQ_HANDLED;
> +
> + /* get irq that is sent to MCU */
> + regmap_read(afe->regmap, AFE_IRQ_MCU_EN, &mcu_en);
> +
> + ret = regmap_read(afe->regmap, AFE_IRQ_MCU_STATUS, &status);
> + /* only care IRQ which is sent to MCU */
> + status_mcu = status & mcu_en & AFE_IRQ_STATUS_BITS;
> +
> + if (ret || status_mcu == 0) {
> + dev_err(afe->dev, "%s(), irq status err, ret %d, status 0x%x,
> + mcu_en 0x%x\n", __func__, ret, status, mcu_en);
> +
> + irq_ret = IRQ_NONE;
> + goto err_irq;
> + }
> +
> + for (i = 0; i < MT79XX_MEMIF_NUM; i++) {
> + struct mtk_base_afe_memif *memif = &afe->memif[i];
> +
> + if (!memif->substream)
> + continue;
> +
> + if (memif->irq_usage < 0)
> + continue;
> +
> + irq = &afe->irqs[memif->irq_usage];
> +
> + if (status_mcu & (1 << irq->irq_data->irq_en_shift))
> + snd_pcm_period_elapsed(memif->substream);
> + }
> +
> +err_irq:
> + /* clear irq */
> + regmap_write(afe->regmap, AFE_IRQ_MCU_CLR, status_mcu);
> +
> + return irq_ret;
> +}
> +
> +static int mt79xx_afe_runtime_suspend(struct device *dev)
> +{
> + struct mtk_base_afe *afe = dev_get_drvdata(dev);
> + struct mt79xx_afe_private *afe_priv = afe->platform_priv;
> +
> + if (!afe->regmap || afe_priv->pm_runtime_bypass_reg_ctl)
> + goto skip_regmap;
> +
> + /* disable clk*/
> + regmap_update_bits(afe->regmap, AUDIO_TOP_CON4, 0x3fff, 0x3fff);
> + regmap_update_bits(afe->regmap, AUDIO_ENGEN_CON0, AUD_APLL2_EN_MASK,
> + 0);
> + regmap_update_bits(afe->regmap, AUDIO_ENGEN_CON0, AUD_26M_EN_MASK,
> + 0);
Each regmap_update_bits() call fits in one line.
> +
> + /* make sure all irq status are cleared, twice intended */
> + regmap_update_bits(afe->regmap, AFE_IRQ_MCU_CLR, 0xffff, 0xffff);
> +
> +skip_regmap:
> + return mt79xx_afe_disable_clock(afe);
> +}
> +
> +static int mt79xx_afe_runtime_resume(struct device *dev)
> +{
> + struct mtk_base_afe *afe = dev_get_drvdata(dev);
> + struct mt79xx_afe_private *afe_priv = afe->platform_priv;
> + int ret;
> +
> + ret = mt79xx_afe_enable_clock(afe);
> + if (ret)
> + return ret;
> +
> + if (!afe->regmap || afe_priv->pm_runtime_bypass_reg_ctl)
> + goto skip_regmap;
Just return 0 here instead of jumping.
> +
> + /* enable clk*/
> + regmap_update_bits(afe->regmap, AUDIO_TOP_CON4, 0x3fff, 0);
> + regmap_update_bits(afe->regmap, AUDIO_ENGEN_CON0, AUD_APLL2_EN_MASK,
> + AUD_APLL2_EN);
> + regmap_update_bits(afe->regmap, AUDIO_ENGEN_CON0, AUD_26M_EN_MASK,
> + AUD_26M_EN);
> +
> +skip_regmap:
> + return 0;
> +}
> +
> +static int mt79xx_afe_component_probe(struct snd_soc_component *component)
> +{
> + return mtk_afe_add_sub_dai_control(component);
> +}
> +
> +static const struct snd_soc_component_driver mt79xx_afe_component = {
> + .name = AFE_PCM_NAME,
> + .probe = mt79xx_afe_component_probe,
> + .pointer = mtk_afe_pcm_pointer,
> + .pcm_construct = mtk_afe_pcm_new,
> +};
> +
> +static int mt79xx_dai_memif_register(struct mtk_base_afe *afe)
> +{
> + struct mtk_base_afe_dai *dai;
> +
> + dai = devm_kzalloc(afe->dev, sizeof(*dai), GFP_KERNEL);
> + if (!dai)
> + return -ENOMEM;
> +
> + list_add(&dai->list, &afe->sub_dais);
> +
> + dai->dai_drivers = mt79xx_memif_dai_driver;
> + dai->num_dai_drivers = ARRAY_SIZE(mt79xx_memif_dai_driver);
> +
> + dai->dapm_widgets = mt79xx_memif_widgets;
> + dai->num_dapm_widgets = ARRAY_SIZE(mt79xx_memif_widgets);
> + dai->dapm_routes = mt79xx_memif_routes;
> + dai->num_dapm_routes = ARRAY_SIZE(mt79xx_memif_routes);
> +
> + return 0;
> +}
> +
> +typedef int (*dai_register_cb)(struct mtk_base_afe *);
> +static const dai_register_cb dai_register_cbs[] = {
> + mt79xx_dai_etdm_register,
> + mt79xx_dai_memif_register,
> +};
> +
> +static int mt79xx_afe_pcm_dev_probe(struct platform_device *pdev)
> +{
> + struct mtk_base_afe *afe;
> + struct mt79xx_afe_private *afe_priv;
> + struct device *dev;
> + int i, irq_id, ret;
> +
> + afe = devm_kzalloc(&pdev->dev, sizeof(*afe), GFP_KERNEL);
> + if (!afe)
> + return -ENOMEM;
> + platform_set_drvdata(pdev, afe);
> +
> + afe->platform_priv = devm_kzalloc(&pdev->dev, sizeof(*afe_priv),
> + GFP_KERNEL);
> + if (!afe->platform_priv)
> + return -ENOMEM;
> +
> + afe_priv = afe->platform_priv;
> + afe->dev = &pdev->dev;
> + dev = afe->dev;
> +
> + afe->base_addr = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(afe->base_addr))
> + return PTR_ERR(afe->base_addr);
> +
> + /* initial audio related clock */
> + ret = mt79xx_init_clock(afe);
> + if (ret) {
> + dev_err(dev, "init clock error\n");
> + return ret;
return dev_err_probe(dev, ret, "Cannot initialize clocks\n");
> + }
> +
> + pm_runtime_enable(dev);
ret = devm_pm_runtime_enable(dev);
if (ret)
return ret;
> +
> + /* enable clock for regcache get default value from hw */
> + afe_priv->pm_runtime_bypass_reg_ctl = true;
> + pm_runtime_get_sync(&pdev->dev);
> +
> + afe->regmap = devm_regmap_init_mmio(&pdev->dev, afe->base_addr,
> + &mt79xx_afe_regmap_config);
> + if (IS_ERR(afe->regmap)) {
> + ret = PTR_ERR(afe->regmap);
> + goto err_pm_disable;
> + }
> +
> + pm_runtime_put_sync(&pdev->dev);
> + afe_priv->pm_runtime_bypass_reg_ctl = false;
> +
> + /* init memif */
> + afe->memif_size = MT79XX_MEMIF_NUM;
> + afe->memif = devm_kcalloc(dev, afe->memif_size, sizeof(*afe->memif),
> + GFP_KERNEL);
> + if (!afe->memif)
> + goto err_pm_disable;
> +
> + for (i = 0; i < afe->memif_size; i++) {
> + afe->memif[i].data = &memif_data[i];
> + afe->memif[i].irq_usage = -1;
> + }
> +
> + mutex_init(&afe->irq_alloc_lock);
> +
> + /* irq initialize */
> + afe->irqs_size = MT79XX_IRQ_NUM;
> + afe->irqs = devm_kcalloc(dev, afe->irqs_size, sizeof(*afe->irqs),
> + GFP_KERNEL);
> + if (!afe->irqs)
> + goto err_pm_disable;
> +
> + for (i = 0; i < afe->irqs_size; i++)
> + afe->irqs[i].irq_data = &irq_data[i];
> +
> + /* request irq */
> + irq_id = platform_get_irq(pdev, 0);
> + if (!irq_id) {
> + dev_err(dev, "%pOFn no irq found\n", dev->of_node);
You're not setting any `ret` value to return an error: this will return 0!!!
> + goto err_pm_disable;
> + }
> + ret = devm_request_irq(dev, irq_id, mt79xx_afe_irq_handler,
> + IRQF_TRIGGER_NONE, "asys-isr", (void *)afe);
> + if (ret) {
> + dev_err(dev, "could not request_irq for asys-isr\n");
> + goto err_pm_disable;
> + }
> +
> + /* init sub_dais */
> + INIT_LIST_HEAD(&afe->sub_dais);
> +
> + for (i = 0; i < ARRAY_SIZE(dai_register_cbs); i++) {
> + ret = dai_register_cbs[i](afe);
> + if (ret) {
> + dev_warn(afe->dev, "dai register i %d fail, ret %d\n",
> + i, ret);
Please change this dev_warn() to dev_err().
> + goto err_pm_disable;
> + }
> + }
> +
> + /* init dai_driver and component_driver */
> + ret = mtk_afe_combine_sub_dai(afe);
> + if (ret) {
> + dev_warn(afe->dev, "mtk_afe_combine_sub_dai fail, ret %d\n",
> + ret);
dev_err()
> + goto err_pm_disable;
> + }
> +
> + afe->mtk_afe_hardware = &mt79xx_afe_hardware;
> + afe->memif_fs = mt79xx_memif_fs;
> + afe->irq_fs = mt79xx_irq_fs;
> +
> + afe->runtime_resume = mt79xx_afe_runtime_resume;
> + afe->runtime_suspend = mt79xx_afe_runtime_suspend;
> +
> + /* register component */
> + ret = devm_snd_soc_register_component(&pdev->dev,
> + &mt79xx_afe_component,
> + NULL, 0);
> + if (ret) {
> + dev_warn(dev, "err_platform\n");
> + goto err_pm_disable;
> + }
> +
> + ret = devm_snd_soc_register_component(afe->dev,
> + &mt79xx_afe_pcm_dai_component,
> + afe->dai_drivers,
> + afe->num_dai_drivers);
> + if (ret) {
> + dev_warn(dev, "err_dai_component\n");
> + goto err_pm_disable;
> + }
> +
> + return ret;
> +
> +err_pm_disable:
> + pm_runtime_put_sync(&pdev->dev);
> + pm_runtime_disable(&pdev->dev);
> + return ret;
> +}
> +
> +static int mt79xx_afe_pcm_dev_remove(struct platform_device *pdev)
> +{
> + pm_runtime_disable(&pdev->dev);
> + if (!pm_runtime_status_suspended(&pdev->dev))
> + mt79xx_afe_runtime_suspend(&pdev->dev);
> +
> + return 0;
> +}
> +
> +static const struct of_device_id mt79xx_afe_pcm_dt_match[] = {
> + { .compatible = "mediatek,mt79xx-afe", },
> + {},
Last entry is always { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, mt79xx_afe_pcm_dt_match);
> +
> +static const struct dev_pm_ops mt79xx_afe_pm_ops = {
> + SET_RUNTIME_PM_OPS(mt79xx_afe_runtime_suspend,
> + mt79xx_afe_runtime_resume, NULL)
> +};
> +
> +static struct platform_driver mt79xx_afe_pcm_driver = {
> + .driver = {
> + .name = "mt79xx-audio",
> + .of_match_table = mt79xx_afe_pcm_dt_match,
> + .pm = &mt79xx_afe_pm_ops,
> + },
> + .probe = mt79xx_afe_pcm_dev_probe,
> + .remove = mt79xx_afe_pcm_dev_remove,
> +};
> +
Remove this extra blank line.
> +module_platform_driver(mt79xx_afe_pcm_driver);
> +
> +MODULE_DESCRIPTION("Mediatek SoC AFE platform driver for ALSA MT79xx");
> +MODULE_AUTHOR("Vic Wu <vic.wu@mediatek.com>");
> +MODULE_LICENSE("GPL");
Thanks,
Angelo
On Wed, 2023-06-14 at 09:57 +0200, AngeloGioacchino Del Regno wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> Il 12/06/23 12:52, Maso Hunag ha scritto:
> > From: Maso Huang <maso.huang@mediatek.com>
> >
> > Add mt79xx platform driver.
> >
> > Signed-off-by: Maso Huang <maso.huang@mediatek.com>
> > ---
> > sound/soc/mediatek/Kconfig | 10 +
> > sound/soc/mediatek/Makefile | 1 +
> > sound/soc/mediatek/mt79xx/Makefile | 9 +
> > sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c | 608
> +++++++++++++++++++++
> > 4 files changed, 628 insertions(+)
> > create mode 100644 sound/soc/mediatek/mt79xx/Makefile
> > create mode 100644 sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c
> >
>
> ..snip..
>
> > diff --git a/sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c
> b/sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c
> > new file mode 100644
> > index 000000000000..69c5f3f3f84b
> > --- /dev/null
> > +++ b/sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c
> > @@ -0,0 +1,608 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * MediaTek ALSA SoC AFE platform driver for MT79xx
> > + *
> > + * Copyright (c) 2021 MediaTek Inc.
> > + * Author: Vic Wu <vic.wu@mediatek.com>
> > + * Maso Huang <maso.huang@mediatek.com>
> > + */
> > +
> > +#include <linux/delay.h>
> > +#include <linux/module.h>
> > +#include <linux/of.h>
> > +#include <linux/of_address.h>
> > +#include <linux/pm_runtime.h>
> > +
> > +#include "mt79xx-afe-common.h"
> > +#include "mt79xx-afe-clk.h"
> > +#include "mt79xx-reg.h"
> > +#include "../common/mtk-afe-platform-driver.h"
> > +#include "../common/mtk-afe-fe-dai.h"
> > +
> > +enum {
> > +MTK_AFE_RATE_8K = 0,
> > +MTK_AFE_RATE_11K = 1,
> > +MTK_AFE_RATE_12K = 2,
> > +MTK_AFE_RATE_16K = 4,
> > +MTK_AFE_RATE_22K = 5,
> > +MTK_AFE_RATE_24K = 6,
> > +MTK_AFE_RATE_32K = 8,
> > +MTK_AFE_RATE_44K = 9,
> > +MTK_AFE_RATE_48K = 10,
> > +MTK_AFE_RATE_88K = 13,
> > +MTK_AFE_RATE_96K = 14,
> > +MTK_AFE_RATE_176K = 17,
> > +MTK_AFE_RATE_192K = 18,
> > +};
> > +
> > +unsigned int mt79xx_afe_rate_transform(struct device *dev,
> > + unsigned int rate)
> > +{
> > +switch (rate) {
> > +case 8000:
> > +return MTK_AFE_RATE_8K;
> > +case 11025:
> > +return MTK_AFE_RATE_11K;
> > +case 12000:
> > +return MTK_AFE_RATE_12K;
> > +case 16000:
> > +return MTK_AFE_RATE_16K;
> > +case 22050:
> > +return MTK_AFE_RATE_22K;
> > +case 24000:
> > +return MTK_AFE_RATE_24K;
> > +case 32000:
> > +return MTK_AFE_RATE_32K;
> > +case 44100:
> > +return MTK_AFE_RATE_44K;
> > +case 48000:
> > +return MTK_AFE_RATE_48K;
> > +case 88200:
> > +return MTK_AFE_RATE_88K;
> > +case 96000:
> > +return MTK_AFE_RATE_96K;
> > +case 176400:
> > +return MTK_AFE_RATE_176K;
> > +case 192000:
> > +return MTK_AFE_RATE_192K;
> > +default:
> > +dev_warn(dev, "%s(), rate %u invalid, use %d!!!\n",
> > + __func__, rate, MTK_AFE_RATE_48K);
> > +return MTK_AFE_RATE_48K;
> > +}
> > +}
> > +
> > +static const struct snd_pcm_hardware mt79xx_afe_hardware = {
> > +.info = SNDRV_PCM_INFO_MMAP |
> > +SNDRV_PCM_INFO_INTERLEAVED |
> > +SNDRV_PCM_INFO_MMAP_VALID,
> > +.formats = SNDRV_PCM_FMTBIT_S16_LE |
> > + SNDRV_PCM_FMTBIT_S24_LE |
> > + SNDRV_PCM_FMTBIT_S32_LE,
> > +.period_bytes_min = 256,
> > +.period_bytes_max = 4 * 48 * 1024,
> > +.periods_min = 2,
> > +.periods_max = 256,
> > +.buffer_bytes_max = 8 * 48 * 1024,
> > +.fifo_size = 0,
> > +};
> > +
> > +static int mt79xx_memif_fs(struct snd_pcm_substream *substream,
> > + unsigned int rate)
> > +{
> > +struct snd_soc_pcm_runtime *rtd = substream->private_data;
> > +struct snd_soc_component *component =
> > +snd_soc_rtdcom_lookup(rtd, AFE_PCM_NAME);
>
> Fits in one line.
OK.
>
> > +struct mtk_base_afe *afe =
> snd_soc_component_get_drvdata(component);
> > +
> > +return mt79xx_afe_rate_transform(afe->dev, rate);
> > +}
> > +
> > +static int mt79xx_irq_fs(struct snd_pcm_substream *substream,
> > + unsigned int rate)
> > +{
> > +struct snd_soc_pcm_runtime *rtd = substream->private_data;
> > +struct snd_soc_component *component =
> > +snd_soc_rtdcom_lookup(rtd, AFE_PCM_NAME);
>
> Fits in one line.
>
OK.
> > +struct mtk_base_afe *afe =
> snd_soc_component_get_drvdata(component);
> > +
> > +return mt79xx_afe_rate_transform(afe->dev, rate);
> > +}
> > +
>
> ..snip..
>
> > +
> > +static irqreturn_t mt79xx_afe_irq_handler(int irq_id, void *dev)
> > +{
> > +struct mtk_base_afe *afe = dev;
> > +struct mtk_base_afe_irq *irq;
> > +unsigned int status;
> > +unsigned int status_mcu;
> > +unsigned int mcu_en;
>
> u32 mcu_en, status, status_mcu;
> int i, ret;
> irqreturn_t irq_ret = IRQ_HANDLED;
>
OK.
> > +int ret;
> > +int i;
> > +irqreturn_t irq_ret = IRQ_HANDLED;
>
>
>
> > +
> > +/* get irq that is sent to MCU */
> > +regmap_read(afe->regmap, AFE_IRQ_MCU_EN, &mcu_en);
> > +
> > +ret = regmap_read(afe->regmap, AFE_IRQ_MCU_STATUS, &status);
> > +/* only care IRQ which is sent to MCU */
> > +status_mcu = status & mcu_en & AFE_IRQ_STATUS_BITS;
> > +
> > +if (ret || status_mcu == 0) {
> > +dev_err(afe->dev, "%s(), irq status err, ret %d, status 0x%x,
> > +mcu_en 0x%x\n", __func__, ret, status, mcu_en);
> > +
> > +irq_ret = IRQ_NONE;
> > +goto err_irq;
> > +}
> > +
> > +for (i = 0; i < MT79XX_MEMIF_NUM; i++) {
> > +struct mtk_base_afe_memif *memif = &afe->memif[i];
> > +
> > +if (!memif->substream)
> > +continue;
> > +
> > +if (memif->irq_usage < 0)
> > +continue;
> > +
> > +irq = &afe->irqs[memif->irq_usage];
> > +
> > +if (status_mcu & (1 << irq->irq_data->irq_en_shift))
> > +snd_pcm_period_elapsed(memif->substream);
> > +}
> > +
> > +err_irq:
> > +/* clear irq */
> > +regmap_write(afe->regmap, AFE_IRQ_MCU_CLR, status_mcu);
> > +
> > +return irq_ret;
> > +}
> > +
> > +static int mt79xx_afe_runtime_suspend(struct device *dev)
> > +{
> > +struct mtk_base_afe *afe = dev_get_drvdata(dev);
> > +struct mt79xx_afe_private *afe_priv = afe->platform_priv;
> > +
> > +if (!afe->regmap || afe_priv->pm_runtime_bypass_reg_ctl)
> > +goto skip_regmap;
> > +
> > +/* disable clk*/
> > +regmap_update_bits(afe->regmap, AUDIO_TOP_CON4, 0x3fff, 0x3fff);
> > +regmap_update_bits(afe->regmap, AUDIO_ENGEN_CON0,
> AUD_APLL2_EN_MASK,
> > + 0);
> > +regmap_update_bits(afe->regmap, AUDIO_ENGEN_CON0, AUD_26M_EN_MASK,
> > + 0);
>
> Each regmap_update_bits() call fits in one line.
>
OK.
> > +
> > +/* make sure all irq status are cleared, twice intended */
> > +regmap_update_bits(afe->regmap, AFE_IRQ_MCU_CLR, 0xffff, 0xffff);
> > +
> > +skip_regmap:
> > +return mt79xx_afe_disable_clock(afe);
> > +}
> > +
> > +static int mt79xx_afe_runtime_resume(struct device *dev)
> > +{
> > +struct mtk_base_afe *afe = dev_get_drvdata(dev);
> > +struct mt79xx_afe_private *afe_priv = afe->platform_priv;
> > +int ret;
> > +
> > +ret = mt79xx_afe_enable_clock(afe);
> > +if (ret)
> > +return ret;
> > +
> > +if (!afe->regmap || afe_priv->pm_runtime_bypass_reg_ctl)
> > +goto skip_regmap;
>
> Just return 0 here instead of jumping.
>
OK.
> > +
> > +/* enable clk*/
> > +regmap_update_bits(afe->regmap, AUDIO_TOP_CON4, 0x3fff, 0);
> > +regmap_update_bits(afe->regmap, AUDIO_ENGEN_CON0,
> AUD_APLL2_EN_MASK,
> > + AUD_APLL2_EN);
> > +regmap_update_bits(afe->regmap, AUDIO_ENGEN_CON0, AUD_26M_EN_MASK,
> > + AUD_26M_EN);
> > +
> > +skip_regmap:
> > +return 0;
> > +}
> > +
> > +static int mt79xx_afe_component_probe(struct snd_soc_component
> *component)
> > +{
> > +return mtk_afe_add_sub_dai_control(component);
> > +}
> > +
> > +static const struct snd_soc_component_driver mt79xx_afe_component
> = {
> > +.name = AFE_PCM_NAME,
> > +.probe = mt79xx_afe_component_probe,
> > +.pointer= mtk_afe_pcm_pointer,
> > +.pcm_construct= mtk_afe_pcm_new,
> > +};
> > +
> > +static int mt79xx_dai_memif_register(struct mtk_base_afe *afe)
> > +{
> > +struct mtk_base_afe_dai *dai;
> > +
> > +dai = devm_kzalloc(afe->dev, sizeof(*dai), GFP_KERNEL);
> > +if (!dai)
> > +return -ENOMEM;
> > +
> > +list_add(&dai->list, &afe->sub_dais);
> > +
> > +dai->dai_drivers = mt79xx_memif_dai_driver;
> > +dai->num_dai_drivers = ARRAY_SIZE(mt79xx_memif_dai_driver);
> > +
> > +dai->dapm_widgets = mt79xx_memif_widgets;
> > +dai->num_dapm_widgets = ARRAY_SIZE(mt79xx_memif_widgets);
> > +dai->dapm_routes = mt79xx_memif_routes;
> > +dai->num_dapm_routes = ARRAY_SIZE(mt79xx_memif_routes);
> > +
> > +return 0;
> > +}
> > +
> > +typedef int (*dai_register_cb)(struct mtk_base_afe *);
> > +static const dai_register_cb dai_register_cbs[] = {
> > +mt79xx_dai_etdm_register,
> > +mt79xx_dai_memif_register,
> > +};
> > +
> > +static int mt79xx_afe_pcm_dev_probe(struct platform_device *pdev)
> > +{
> > +struct mtk_base_afe *afe;
> > +struct mt79xx_afe_private *afe_priv;
> > +struct device *dev;
> > +int i, irq_id, ret;
> > +
> > +afe = devm_kzalloc(&pdev->dev, sizeof(*afe), GFP_KERNEL);
> > +if (!afe)
> > +return -ENOMEM;
> > +platform_set_drvdata(pdev, afe);
> > +
> > +afe->platform_priv = devm_kzalloc(&pdev->dev, sizeof(*afe_priv),
> > + GFP_KERNEL);
> > +if (!afe->platform_priv)
> > +return -ENOMEM;
> > +
> > +afe_priv = afe->platform_priv;
> > +afe->dev = &pdev->dev;
> > +dev = afe->dev;
> > +
> > +afe->base_addr = devm_platform_ioremap_resource(pdev, 0);
> > +if (IS_ERR(afe->base_addr))
> > +return PTR_ERR(afe->base_addr);
> > +
> > +/* initial audio related clock */
> > +ret = mt79xx_init_clock(afe);
> > +if (ret) {
> > +dev_err(dev, "init clock error\n");
> > +return ret;
>
> return dev_err_probe(dev, ret, "Cannot initialize clocks\n");
>
OK.
> > +}
> > +
> > +pm_runtime_enable(dev);
>
> ret = devm_pm_runtime_enable(dev);
> if (ret)
> return ret;
>
OK.
> > +
> > +/* enable clock for regcache get default value from hw */
> > +afe_priv->pm_runtime_bypass_reg_ctl = true;
> > +pm_runtime_get_sync(&pdev->dev);
> > +
> > +afe->regmap = devm_regmap_init_mmio(&pdev->dev, afe->base_addr,
> > + &mt79xx_afe_regmap_config);
> > +if (IS_ERR(afe->regmap)) {
> > +ret = PTR_ERR(afe->regmap);
> > +goto err_pm_disable;
> > +}
> > +
> > +pm_runtime_put_sync(&pdev->dev);
> > +afe_priv->pm_runtime_bypass_reg_ctl = false;
> > +
> > +/* init memif */
> > +afe->memif_size = MT79XX_MEMIF_NUM;
> > +afe->memif = devm_kcalloc(dev, afe->memif_size, sizeof(*afe-
> >memif),
> > + GFP_KERNEL);
> > +if (!afe->memif)
> > +goto err_pm_disable;
> > +
> > +for (i = 0; i < afe->memif_size; i++) {
> > +afe->memif[i].data = &memif_data[i];
> > +afe->memif[i].irq_usage = -1;
> > +}
> > +
> > +mutex_init(&afe->irq_alloc_lock);
> > +
> > +/* irq initialize */
> > +afe->irqs_size = MT79XX_IRQ_NUM;
> > +afe->irqs = devm_kcalloc(dev, afe->irqs_size, sizeof(*afe->irqs),
> > + GFP_KERNEL);
> > +if (!afe->irqs)
> > +goto err_pm_disable;
> > +
> > +for (i = 0; i < afe->irqs_size; i++)
> > +afe->irqs[i].irq_data = &irq_data[i];
> > +
> > +/* request irq */
> > +irq_id = platform_get_irq(pdev, 0);
> > +if (!irq_id) {
> > +dev_err(dev, "%pOFn no irq found\n", dev->of_node);
>
> You're not setting any `ret` value to return an error: this will
> return 0!!!
>
OK. I'll add missing return value in v2 patch.
>
> > +goto err_pm_disable;
> > +}
> > +ret = devm_request_irq(dev, irq_id, mt79xx_afe_irq_handler,
> > + IRQF_TRIGGER_NONE, "asys-isr", (void *)afe);
> > +if (ret) {
> > +dev_err(dev, "could not request_irq for asys-isr\n");
> > +goto err_pm_disable;
> > +}
> > +
> > +/* init sub_dais */
> > +INIT_LIST_HEAD(&afe->sub_dais);
> > +
> > +for (i = 0; i < ARRAY_SIZE(dai_register_cbs); i++) {
> > +ret = dai_register_cbs[i](afe);
> > +if (ret) {
> > +dev_warn(afe->dev, "dai register i %d fail, ret %d\n",
> > + i, ret);
>
> Please change this dev_warn() to dev_err().
>
OK.
> > +goto err_pm_disable;
> > +}
> > +}
> > +
> > +/* init dai_driver and component_driver */
> > +ret = mtk_afe_combine_sub_dai(afe);
> > +if (ret) {
> > +dev_warn(afe->dev, "mtk_afe_combine_sub_dai fail, ret %d\n",
> > + ret);
>
> dev_err()
>
OK.
> > +goto err_pm_disable;
> > +}
> > +
> > +afe->mtk_afe_hardware = &mt79xx_afe_hardware;
> > +afe->memif_fs = mt79xx_memif_fs;
> > +afe->irq_fs = mt79xx_irq_fs;
> > +
> > +afe->runtime_resume = mt79xx_afe_runtime_resume;
> > +afe->runtime_suspend = mt79xx_afe_runtime_suspend;
> > +
> > +/* register component */
> > +ret = devm_snd_soc_register_component(&pdev->dev,
> > + &mt79xx_afe_component,
> > + NULL, 0);
> > +if (ret) {
> > +dev_warn(dev, "err_platform\n");
> > +goto err_pm_disable;
> > +}
> > +
> > +ret = devm_snd_soc_register_component(afe->dev,
> > + &mt79xx_afe_pcm_dai_component,
> > + afe->dai_drivers,
> > + afe->num_dai_drivers);
> > +if (ret) {
> > +dev_warn(dev, "err_dai_component\n");
> > +goto err_pm_disable;
> > +}
> > +
> > +return ret;
> > +
> > +err_pm_disable:
> > +pm_runtime_put_sync(&pdev->dev);
> > +pm_runtime_disable(&pdev->dev);
> > +return ret;
> > +}
> > +
> > +static int mt79xx_afe_pcm_dev_remove(struct platform_device *pdev)
> > +{
> > +pm_runtime_disable(&pdev->dev);
> > +if (!pm_runtime_status_suspended(&pdev->dev))
> > +mt79xx_afe_runtime_suspend(&pdev->dev);
> > +
> > +return 0;
> > +}
> > +
> > +static const struct of_device_id mt79xx_afe_pcm_dt_match[] = {
> > +{ .compatible = "mediatek,mt79xx-afe", },
> > +{},
>
> Last entry is always { /* sentinel */ }
>
OK.
> > +};
> > +MODULE_DEVICE_TABLE(of, mt79xx_afe_pcm_dt_match);
> > +
> > +static const struct dev_pm_ops mt79xx_afe_pm_ops = {
> > +SET_RUNTIME_PM_OPS(mt79xx_afe_runtime_suspend,
> > + mt79xx_afe_runtime_resume, NULL)
> > +};
> > +
> > +static struct platform_driver mt79xx_afe_pcm_driver = {
> > +.driver = {
> > + .name = "mt79xx-audio",
> > + .of_match_table = mt79xx_afe_pcm_dt_match,
> > + .pm = &mt79xx_afe_pm_ops,
> > +},
> > +.probe = mt79xx_afe_pcm_dev_probe,
> > +.remove = mt79xx_afe_pcm_dev_remove,
> > +};
> > +
>
> Remove this extra blank line.
>
OK.
> > +module_platform_driver(mt79xx_afe_pcm_driver);
> > +
> > +MODULE_DESCRIPTION("Mediatek SoC AFE platform driver for ALSA
> MT79xx");
> > +MODULE_AUTHOR("Vic Wu <vic.wu@mediatek.com>");
> > +MODULE_LICENSE("GPL");
>
> Thanks,
> Angelo
>
Hi Angelo,
I'll fix all of them in v2 patch!
Best regards,
Maso
Hi Maso,
kernel test robot noticed the following build errors:
[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on tiwai-sound/for-next tiwai-sound/for-linus linus/master v6.4-rc6 next-20230614]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Maso-Hunag/ASoC-mediatek-mt79xx-add-common-header/20230612-211033
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link: https://lore.kernel.org/r/20230612105250.15441-4-maso.huang%40mediatek.com
patch subject: [PATCH 3/7] ASoC: mediatek: mt79xx: add platform driver
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20230614/202306142005.uUyPtOQT-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add broonie-sound https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
git fetch broonie-sound for-next
git checkout broonie-sound/for-next
b4 shazam https://lore.kernel.org/r/20230612105250.15441-4-maso.huang@mediatek.com
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=arm olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash sound/soc/mediatek/mt79xx/
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306142005.uUyPtOQT-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c: In function 'mt79xx_afe_irq_handler':
>> sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:322:35: warning: missing terminating " character
322 | dev_err(afe->dev, "%s(), irq status err, ret %d, status 0x%x,
| ^
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:323:38: warning: missing terminating " character
323 | mcu_en 0x%x\n", __func__, ret, status, mcu_en);
| ^
>> sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:608:23: error: unterminated argument list invoking macro "dev_err"
608 | MODULE_LICENSE("GPL");
| ^
>> sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:322:17: error: 'dev_err' undeclared (first use in this function); did you mean '_dev_err'?
322 | dev_err(afe->dev, "%s(), irq status err, ret %d, status 0x%x,
| ^~~~~~~
| _dev_err
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:322:17: note: each undeclared identifier is reported only once for each function it appears in
>> sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:322:24: error: expected ';' at end of input
322 | dev_err(afe->dev, "%s(), irq status err, ret %d, status 0x%x,
| ^
| ;
......
>> sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:322:17: error: expected declaration or statement at end of input
322 | dev_err(afe->dev, "%s(), irq status err, ret %d, status 0x%x,
| ^~~~~~~
>> sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:322:17: error: expected declaration or statement at end of input
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:312:21: warning: unused variable 'irq_ret' [-Wunused-variable]
312 | irqreturn_t irq_ret = IRQ_HANDLED;
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:311:13: warning: unused variable 'i' [-Wunused-variable]
311 | int i;
| ^
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:306:34: warning: unused variable 'irq' [-Wunused-variable]
306 | struct mtk_base_afe_irq *irq;
| ^~~
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:322:17: error: no return statement in function returning non-void [-Werror=return-type]
322 | dev_err(afe->dev, "%s(), irq status err, ret %d, status 0x%x,
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c: At top level:
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:303:20: warning: 'mt79xx_afe_irq_handler' defined but not used [-Wunused-function]
303 | static irqreturn_t mt79xx_afe_irq_handler(int irq_id, void *dev)
| ^~~~~~~~~~~~~~~~~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:294:35: warning: 'mt79xx_afe_regmap_config' defined but not used [-Wunused-const-variable=]
294 | static const struct regmap_config mt79xx_afe_regmap_config = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:232:39: warning: 'irq_data' defined but not used [-Wunused-const-variable=]
232 | static const struct mtk_base_irq_data irq_data[MT79XX_IRQ_NUM] = {
| ^~~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:183:41: warning: 'memif_data' defined but not used [-Wunused-const-variable=]
183 | static const struct mtk_base_memif_data memif_data[MT79XX_MEMIF_NUM] = {
| ^~~~~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:179:46: warning: 'mt79xx_afe_pcm_dai_component' defined but not used [-Wunused-const-variable=]
179 | static const struct snd_soc_component_driver mt79xx_afe_pcm_dai_component = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:170:40: warning: 'mt79xx_memif_routes' defined but not used [-Wunused-const-variable=]
170 | static const struct snd_soc_dapm_route mt79xx_memif_routes[] = {
| ^~~~~~~~~~~~~~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:158:41: warning: 'mt79xx_memif_widgets' defined but not used [-Wunused-const-variable=]
158 | static const struct snd_soc_dapm_widget mt79xx_memif_widgets[] = {
| ^~~~~~~~~~~~~~~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:122:34: warning: 'mt79xx_memif_dai_driver' defined but not used [-Wunused-variable]
122 | static struct snd_soc_dai_driver mt79xx_memif_dai_driver[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:101:12: warning: 'mt79xx_irq_fs' defined but not used [-Wunused-function]
101 | static int mt79xx_irq_fs(struct snd_pcm_substream *substream,
| ^~~~~~~~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:90:12: warning: 'mt79xx_memif_fs' defined but not used [-Wunused-function]
90 | static int mt79xx_memif_fs(struct snd_pcm_substream *substream,
| ^~~~~~~~~~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c:75:38: warning: 'mt79xx_afe_hardware' defined but not used [-Wunused-const-variable=]
75 | static const struct snd_pcm_hardware mt79xx_afe_hardware = {
| ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c: In function 'mt79xx_init_clock':
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:43: warning: missing terminating " character
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:42: warning: missing terminating " character
47 | ret %ld\n", __func__, aud_clks[i],
| ^
In file included from include/linux/kernel.h:30,
from include/linux/clk.h:13,
from sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:10:
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:43: error: missing terminating " character
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/printk.h:379:42: note: in definition of macro '__printk_index_emit'
379 | if (__builtin_constant_p(_fmt) && __builtin_constant_p(_level)) { \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:33: error: 'ret' undeclared (first use in this function); did you mean 'net'?
47 | ret %ld\n", __func__, aud_clks[i],
| ^~~
include/linux/printk.h:379:42: note: in definition of macro '__printk_index_emit'
379 | if (__builtin_constant_p(_fmt) && __builtin_constant_p(_level)) { \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:33: note: each undeclared identifier is reported only once for each function it appears in
47 | ret %ld\n", __func__, aud_clks[i],
| ^~~
include/linux/printk.h:379:42: note: in definition of macro '__printk_index_emit'
379 | if (__builtin_constant_p(_fmt) && __builtin_constant_p(_level)) { \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:40: error: stray '\' in program
47 | ret %ld\n", __func__, aud_clks[i],
| ^
include/linux/printk.h:379:42: note: in definition of macro '__printk_index_emit'
379 | if (__builtin_constant_p(_fmt) && __builtin_constant_p(_level)) { \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:38: error: 'ld' undeclared (first use in this function)
47 | ret %ld\n", __func__, aud_clks[i],
| ^~
include/linux/printk.h:379:42: note: in definition of macro '__printk_index_emit'
379 | if (__builtin_constant_p(_fmt) && __builtin_constant_p(_level)) { \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:41: error: expected ')' before 'n'
47 | ret %ld\n", __func__, aud_clks[i],
| ^
include/linux/printk.h:379:42: note: in definition of macro '__printk_index_emit'
379 | if (__builtin_constant_p(_fmt) && __builtin_constant_p(_level)) { \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
include/linux/printk.h:379:41: note: to match this '('
379 | if (__builtin_constant_p(_fmt) && __builtin_constant_p(_level)) { \
| ^
include/linux/printk.h:422:9: note: in expansion of macro '__printk_index_emit'
422 | __printk_index_emit(fmt, level, subsys_fmt_prefix)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:42: error: missing terminating " character
47 | ret %ld\n", __func__, aud_clks[i],
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/printk.h:379:42: note: in definition of macro '__printk_index_emit'
379 | if (__builtin_constant_p(_fmt) && __builtin_constant_p(_level)) { \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:43: error: missing terminating " character
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/printk.h:388:61: note: in definition of macro '__printk_index_emit'
388 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:40: error: stray '\' in program
47 | ret %ld\n", __func__, aud_clks[i],
| ^
include/linux/printk.h:388:61: note: in definition of macro '__printk_index_emit'
388 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:41: error: expected ')' before 'n'
47 | ret %ld\n", __func__, aud_clks[i],
| ^
include/linux/printk.h:388:61: note: in definition of macro '__printk_index_emit'
388 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
include/linux/printk.h:388:60: note: to match this '('
388 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^
include/linux/printk.h:422:9: note: in expansion of macro '__printk_index_emit'
422 | __printk_index_emit(fmt, level, subsys_fmt_prefix)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:42: error: missing terminating " character
47 | ret %ld\n", __func__, aud_clks[i],
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/printk.h:388:61: note: in definition of macro '__printk_index_emit'
388 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:43: error: missing terminating " character
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/printk.h:388:70: note: in definition of macro '__printk_index_emit'
388 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:40: error: stray '\' in program
47 | ret %ld\n", __func__, aud_clks[i],
| ^
include/linux/printk.h:388:70: note: in definition of macro '__printk_index_emit'
388 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:41: error: expected ')' before 'n'
47 | ret %ld\n", __func__, aud_clks[i],
| ^
include/linux/printk.h:388:70: note: in definition of macro '__printk_index_emit'
388 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
include/linux/printk.h:388:69: note: to match this '('
388 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^
include/linux/printk.h:422:9: note: in expansion of macro '__printk_index_emit'
422 | __printk_index_emit(fmt, level, subsys_fmt_prefix)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:42: error: missing terminating " character
47 | ret %ld\n", __func__, aud_clks[i],
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/printk.h:388:70: note: in definition of macro '__printk_index_emit'
388 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^~~~
include/linux/dev_printk.h:105:9: note: in expansion of macro 'printk_index_subsys_emit'
105 | printk_index_subsys_emit("%s %s: ", level, fmt)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:109:17: note: in expansion of macro 'dev_printk_index_emit'
109 | dev_printk_index_emit(level, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
In file included from include/linux/device.h:15,
from include/linux/platform_device.h:13,
from include/sound/soc.h:14,
from sound/soc/mediatek/mt79xx/mt79xx-afe-common.h:13,
from sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:12:
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:43: error: missing terminating " character
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:40: error: stray '\' in program
47 | ret %ld\n", __func__, aud_clks[i],
| ^
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
>> sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:41: error: expected ')' before 'n'
47 | ret %ld\n", __func__, aud_clks[i],
| ^
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
include/linux/dev_printk.h:110:24: note: to match this '('
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^
include/linux/dev_printk.h:144:9: note: in expansion of macro 'dev_printk_index_wrap'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:47:42: error: missing terminating " character
47 | ret %ld\n", __func__, aud_clks[i],
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/mediatek/mt79xx/mt79xx-afe-clk.c:46:25: note: in expansion of macro 'dev_err'
46 | dev_err(afe->dev, "%s(), devm_clk_get %s fail,
| ^~~~~~~
vim +/dev_err +608 sound/soc/mediatek/mt79xx/mt79xx-afe-pcm.c
605
606 MODULE_DESCRIPTION("Mediatek SoC AFE platform driver for ALSA MT79xx");
607 MODULE_AUTHOR("Vic Wu <vic.wu@mediatek.com>");
> 608 MODULE_LICENSE("GPL");
@@ -54,6 +54,16 @@ config SND_SOC_MT6797_MT6351
Select Y if you have such device.
If unsure select "N".
+config SND_SOC_MT79XX
+ tristate "ASoC support for Mediatek MT79XX chip"
+ depends on ARCH_MEDIATEK
+ select SND_SOC_MEDIATEK
+ help
+ This adds ASoC platform driver support for MediaTek MT79XX chip
+ that can be used with other codecs.
+ Select Y if you have such device.
+ If unsure select "N".
+
config SND_SOC_MT8173
tristate "ASoC support for Mediatek MT8173 chip"
depends on ARCH_MEDIATEK
@@ -2,6 +2,7 @@
obj-$(CONFIG_SND_SOC_MEDIATEK) += common/
obj-$(CONFIG_SND_SOC_MT2701) += mt2701/
obj-$(CONFIG_SND_SOC_MT6797) += mt6797/
+obj-$(CONFIG_SND_SOC_MT79XX) += mt79xx/
obj-$(CONFIG_SND_SOC_MT8173) += mt8173/
obj-$(CONFIG_SND_SOC_MT8183) += mt8183/
obj-$(CONFIG_SND_SOC_MT8186) += mt8186/
new file mode 100644
@@ -0,0 +1,9 @@
+# SPDX-License-Identifier: GPL-2.0
+
+# platform driver
+snd-soc-mt79xx-afe-objs := \
+ mt79xx-afe-pcm.o \
+ mt79xx-afe-clk.o \
+ mt79xx-dai-etdm.o
+
+obj-$(CONFIG_SND_SOC_MT79XX) += snd-soc-mt79xx-afe.o
new file mode 100644
@@ -0,0 +1,608 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * MediaTek ALSA SoC AFE platform driver for MT79xx
+ *
+ * Copyright (c) 2021 MediaTek Inc.
+ * Author: Vic Wu <vic.wu@mediatek.com>
+ * Maso Huang <maso.huang@mediatek.com>
+ */
+
+#include <linux/delay.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/pm_runtime.h>
+
+#include "mt79xx-afe-common.h"
+#include "mt79xx-afe-clk.h"
+#include "mt79xx-reg.h"
+#include "../common/mtk-afe-platform-driver.h"
+#include "../common/mtk-afe-fe-dai.h"
+
+enum {
+ MTK_AFE_RATE_8K = 0,
+ MTK_AFE_RATE_11K = 1,
+ MTK_AFE_RATE_12K = 2,
+ MTK_AFE_RATE_16K = 4,
+ MTK_AFE_RATE_22K = 5,
+ MTK_AFE_RATE_24K = 6,
+ MTK_AFE_RATE_32K = 8,
+ MTK_AFE_RATE_44K = 9,
+ MTK_AFE_RATE_48K = 10,
+ MTK_AFE_RATE_88K = 13,
+ MTK_AFE_RATE_96K = 14,
+ MTK_AFE_RATE_176K = 17,
+ MTK_AFE_RATE_192K = 18,
+};
+
+unsigned int mt79xx_afe_rate_transform(struct device *dev,
+ unsigned int rate)
+{
+ switch (rate) {
+ case 8000:
+ return MTK_AFE_RATE_8K;
+ case 11025:
+ return MTK_AFE_RATE_11K;
+ case 12000:
+ return MTK_AFE_RATE_12K;
+ case 16000:
+ return MTK_AFE_RATE_16K;
+ case 22050:
+ return MTK_AFE_RATE_22K;
+ case 24000:
+ return MTK_AFE_RATE_24K;
+ case 32000:
+ return MTK_AFE_RATE_32K;
+ case 44100:
+ return MTK_AFE_RATE_44K;
+ case 48000:
+ return MTK_AFE_RATE_48K;
+ case 88200:
+ return MTK_AFE_RATE_88K;
+ case 96000:
+ return MTK_AFE_RATE_96K;
+ case 176400:
+ return MTK_AFE_RATE_176K;
+ case 192000:
+ return MTK_AFE_RATE_192K;
+ default:
+ dev_warn(dev, "%s(), rate %u invalid, use %d!!!\n",
+ __func__, rate, MTK_AFE_RATE_48K);
+ return MTK_AFE_RATE_48K;
+ }
+}
+
+static const struct snd_pcm_hardware mt79xx_afe_hardware = {
+ .info = SNDRV_PCM_INFO_MMAP |
+ SNDRV_PCM_INFO_INTERLEAVED |
+ SNDRV_PCM_INFO_MMAP_VALID,
+ .formats = SNDRV_PCM_FMTBIT_S16_LE |
+ SNDRV_PCM_FMTBIT_S24_LE |
+ SNDRV_PCM_FMTBIT_S32_LE,
+ .period_bytes_min = 256,
+ .period_bytes_max = 4 * 48 * 1024,
+ .periods_min = 2,
+ .periods_max = 256,
+ .buffer_bytes_max = 8 * 48 * 1024,
+ .fifo_size = 0,
+};
+
+static int mt79xx_memif_fs(struct snd_pcm_substream *substream,
+ unsigned int rate)
+{
+ struct snd_soc_pcm_runtime *rtd = substream->private_data;
+ struct snd_soc_component *component =
+ snd_soc_rtdcom_lookup(rtd, AFE_PCM_NAME);
+ struct mtk_base_afe *afe = snd_soc_component_get_drvdata(component);
+
+ return mt79xx_afe_rate_transform(afe->dev, rate);
+}
+
+static int mt79xx_irq_fs(struct snd_pcm_substream *substream,
+ unsigned int rate)
+{
+ struct snd_soc_pcm_runtime *rtd = substream->private_data;
+ struct snd_soc_component *component =
+ snd_soc_rtdcom_lookup(rtd, AFE_PCM_NAME);
+ struct mtk_base_afe *afe = snd_soc_component_get_drvdata(component);
+
+ return mt79xx_afe_rate_transform(afe->dev, rate);
+}
+
+#define MTK_PCM_RATES (SNDRV_PCM_RATE_8000_48000 |\
+ SNDRV_PCM_RATE_88200 |\
+ SNDRV_PCM_RATE_96000 |\
+ SNDRV_PCM_RATE_176400 |\
+ SNDRV_PCM_RATE_192000)
+
+#define MTK_PCM_FORMATS (SNDRV_PCM_FMTBIT_S16_LE |\
+ SNDRV_PCM_FMTBIT_S24_LE |\
+ SNDRV_PCM_FMTBIT_S32_LE)
+
+static struct snd_soc_dai_driver mt79xx_memif_dai_driver[] = {
+ /* FE DAIs: memory intefaces to CPU */
+ {
+ .name = "DL1",
+ .id = MT79XX_MEMIF_DL1,
+ .playback = {
+ .stream_name = "DL1",
+ .channels_min = 1,
+ .channels_max = 2,
+ .rates = MTK_PCM_RATES,
+ .formats = MTK_PCM_FORMATS,
+ },
+ .ops = &mtk_afe_fe_ops,
+ },
+ {
+ .name = "UL1",
+ .id = MT79XX_MEMIF_VUL12,
+ .capture = {
+ .stream_name = "UL1",
+ .channels_min = 1,
+ .channels_max = 2,
+ .rates = MTK_PCM_RATES,
+ .formats = MTK_PCM_FORMATS,
+ },
+ .ops = &mtk_afe_fe_ops,
+ },
+};
+
+static const struct snd_kcontrol_new o018_mix[] = {
+ SOC_DAPM_SINGLE_AUTODISABLE("I150_Switch", AFE_CONN018_4, 22, 1, 0),
+};
+
+static const struct snd_kcontrol_new o019_mix[] = {
+ SOC_DAPM_SINGLE_AUTODISABLE("I151_Switch", AFE_CONN019_4, 23, 1, 0),
+};
+
+static const struct snd_soc_dapm_widget mt79xx_memif_widgets[] = {
+ /* DL */
+ SND_SOC_DAPM_MIXER("I032", SND_SOC_NOPM, 0, 0, NULL, 0),
+ SND_SOC_DAPM_MIXER("I033", SND_SOC_NOPM, 0, 0, NULL, 0),
+
+ /* UL */
+ SND_SOC_DAPM_MIXER("O018", SND_SOC_NOPM, 0, 0,
+ o018_mix, ARRAY_SIZE(o018_mix)),
+ SND_SOC_DAPM_MIXER("O019", SND_SOC_NOPM, 0, 0,
+ o019_mix, ARRAY_SIZE(o019_mix)),
+};
+
+static const struct snd_soc_dapm_route mt79xx_memif_routes[] = {
+ {"I032", NULL, "DL1"},
+ {"I033", NULL, "DL1"},
+ {"UL1", NULL, "O018"},
+ {"UL1", NULL, "O019"},
+ {"O018", "I150_Switch", "I150"},
+ {"O019", "I151_Switch", "I151"},
+};
+
+static const struct snd_soc_component_driver mt79xx_afe_pcm_dai_component = {
+ .name = "mt79xx-afe-pcm-dai",
+};
+
+static const struct mtk_base_memif_data memif_data[MT79XX_MEMIF_NUM] = {
+ [MT79XX_MEMIF_DL1] = {
+ .name = "DL1",
+ .id = MT79XX_MEMIF_DL1,
+ .reg_ofs_base = AFE_DL0_BASE,
+ .reg_ofs_cur = AFE_DL0_CUR,
+ .reg_ofs_end = AFE_DL0_END,
+ .reg_ofs_base_msb = AFE_DL0_BASE_MSB,
+ .reg_ofs_cur_msb = AFE_DL0_CUR_MSB,
+ .reg_ofs_end_msb = AFE_DL0_END_MSB,
+ .fs_reg = AFE_DL0_CON0,
+ .fs_shift = DL0_MODE_SFT,
+ .fs_maskbit = DL0_MODE_MASK,
+ .mono_reg = AFE_DL0_CON0,
+ .mono_shift = DL0_MONO_SFT,
+ .enable_reg = AFE_DL0_CON0,
+ .enable_shift = DL0_ON_SFT,
+ .hd_reg = AFE_DL0_CON0,
+ .hd_shift = DL0_HD_MODE_SFT,
+ .hd_align_reg = AFE_DL0_CON0,
+ .hd_align_mshift = DL0_HALIGN_SFT,
+ .pbuf_reg = AFE_DL0_CON0,
+ .pbuf_shift = DL0_PBUF_SIZE_SFT,
+ .minlen_reg = AFE_DL0_CON0,
+ .minlen_shift = DL0_MINLEN_SFT,
+ },
+ [MT79XX_MEMIF_VUL12] = {
+ .name = "VUL12",
+ .id = MT79XX_MEMIF_VUL12,
+ .reg_ofs_base = AFE_VUL0_BASE,
+ .reg_ofs_cur = AFE_VUL0_CUR,
+ .reg_ofs_end = AFE_VUL0_END,
+ .reg_ofs_base_msb = AFE_VUL0_BASE_MSB,
+ .reg_ofs_cur_msb = AFE_VUL0_CUR_MSB,
+ .reg_ofs_end_msb = AFE_VUL0_END_MSB,
+ .fs_reg = AFE_VUL0_CON0,
+ .fs_shift = VUL0_MODE_SFT,
+ .fs_maskbit = VUL0_MODE_MASK,
+ .mono_reg = AFE_VUL0_CON0,
+ .mono_shift = VUL0_MONO_SFT,
+ .enable_reg = AFE_VUL0_CON0,
+ .enable_shift = VUL0_ON_SFT,
+ .hd_reg = AFE_VUL0_CON0,
+ .hd_shift = VUL0_HD_MODE_SFT,
+ .hd_align_reg = AFE_VUL0_CON0,
+ .hd_align_mshift = VUL0_HALIGN_SFT,
+ },
+};
+
+static const struct mtk_base_irq_data irq_data[MT79XX_IRQ_NUM] = {
+ [MT79XX_IRQ_0] = {
+ .id = MT79XX_IRQ_0,
+ .irq_cnt_reg = AFE_IRQ0_MCU_CFG1,
+ .irq_cnt_shift = AFE_IRQ_CNT_SHIFT,
+ .irq_cnt_maskbit = AFE_IRQ_CNT_MASK,
+ .irq_fs_reg = AFE_IRQ0_MCU_CFG0,
+ .irq_fs_shift = IRQ_MCU_MODE_SFT,
+ .irq_fs_maskbit = IRQ_MCU_MODE_MASK,
+ .irq_en_reg = AFE_IRQ0_MCU_CFG0,
+ .irq_en_shift = IRQ_MCU_ON_SFT,
+ .irq_clr_reg = AFE_IRQ_MCU_CLR,
+ .irq_clr_shift = IRQ0_MCU_CLR_SFT,
+ },
+ [MT79XX_IRQ_1] = {
+ .id = MT79XX_IRQ_1,
+ .irq_cnt_reg = AFE_IRQ1_MCU_CFG1,
+ .irq_cnt_shift = AFE_IRQ_CNT_SHIFT,
+ .irq_cnt_maskbit = AFE_IRQ_CNT_MASK,
+ .irq_fs_reg = AFE_IRQ1_MCU_CFG0,
+ .irq_fs_shift = IRQ_MCU_MODE_SFT,
+ .irq_fs_maskbit = IRQ_MCU_MODE_MASK,
+ .irq_en_reg = AFE_IRQ1_MCU_CFG0,
+ .irq_en_shift = IRQ_MCU_ON_SFT,
+ .irq_clr_reg = AFE_IRQ_MCU_CLR,
+ .irq_clr_shift = IRQ1_MCU_CLR_SFT,
+ },
+ [MT79XX_IRQ_2] = {
+ .id = MT79XX_IRQ_2,
+ .irq_cnt_reg = AFE_IRQ2_MCU_CFG1,
+ .irq_cnt_shift = AFE_IRQ_CNT_SHIFT,
+ .irq_cnt_maskbit = AFE_IRQ_CNT_MASK,
+ .irq_fs_reg = AFE_IRQ2_MCU_CFG0,
+ .irq_fs_shift = IRQ_MCU_MODE_SFT,
+ .irq_fs_maskbit = IRQ_MCU_MODE_MASK,
+ .irq_en_reg = AFE_IRQ2_MCU_CFG0,
+ .irq_en_shift = IRQ_MCU_ON_SFT,
+ .irq_clr_reg = AFE_IRQ_MCU_CLR,
+ .irq_clr_shift = IRQ2_MCU_CLR_SFT,
+ },
+};
+
+static bool mt79xx_is_volatile_reg(struct device *dev, unsigned int reg)
+{
+ /* these auto-gen reg has read-only bit, so put it as volatile */
+ /* volatile reg cannot be cached, so cannot be set when power off */
+ switch (reg) {
+ case AFE_DL0_CUR_MSB:
+ case AFE_DL0_CUR:
+ case AFE_DL0_RCH_MON:
+ case AFE_DL0_LCH_MON:
+ case AFE_VUL0_CUR_MSB:
+ case AFE_VUL0_CUR:
+ case AFE_IRQ_MCU_STATUS:
+ case AFE_MEMIF_RD_MON:
+ case AFE_MEMIF_WR_MON:
+ return true;
+ default:
+ return false;
+ };
+}
+
+static const struct regmap_config mt79xx_afe_regmap_config = {
+ .reg_bits = 32,
+ .reg_stride = 4,
+ .val_bits = 32,
+ .volatile_reg = mt79xx_is_volatile_reg,
+ .max_register = AFE_MAX_REGISTER,
+ .num_reg_defaults_raw = ((AFE_MAX_REGISTER / 4) + 1),
+};
+
+static irqreturn_t mt79xx_afe_irq_handler(int irq_id, void *dev)
+{
+ struct mtk_base_afe *afe = dev;
+ struct mtk_base_afe_irq *irq;
+ unsigned int status;
+ unsigned int status_mcu;
+ unsigned int mcu_en;
+ int ret;
+ int i;
+ irqreturn_t irq_ret = IRQ_HANDLED;
+
+ /* get irq that is sent to MCU */
+ regmap_read(afe->regmap, AFE_IRQ_MCU_EN, &mcu_en);
+
+ ret = regmap_read(afe->regmap, AFE_IRQ_MCU_STATUS, &status);
+ /* only care IRQ which is sent to MCU */
+ status_mcu = status & mcu_en & AFE_IRQ_STATUS_BITS;
+
+ if (ret || status_mcu == 0) {
+ dev_err(afe->dev, "%s(), irq status err, ret %d, status 0x%x,
+ mcu_en 0x%x\n", __func__, ret, status, mcu_en);
+
+ irq_ret = IRQ_NONE;
+ goto err_irq;
+ }
+
+ for (i = 0; i < MT79XX_MEMIF_NUM; i++) {
+ struct mtk_base_afe_memif *memif = &afe->memif[i];
+
+ if (!memif->substream)
+ continue;
+
+ if (memif->irq_usage < 0)
+ continue;
+
+ irq = &afe->irqs[memif->irq_usage];
+
+ if (status_mcu & (1 << irq->irq_data->irq_en_shift))
+ snd_pcm_period_elapsed(memif->substream);
+ }
+
+err_irq:
+ /* clear irq */
+ regmap_write(afe->regmap, AFE_IRQ_MCU_CLR, status_mcu);
+
+ return irq_ret;
+}
+
+static int mt79xx_afe_runtime_suspend(struct device *dev)
+{
+ struct mtk_base_afe *afe = dev_get_drvdata(dev);
+ struct mt79xx_afe_private *afe_priv = afe->platform_priv;
+
+ if (!afe->regmap || afe_priv->pm_runtime_bypass_reg_ctl)
+ goto skip_regmap;
+
+ /* disable clk*/
+ regmap_update_bits(afe->regmap, AUDIO_TOP_CON4, 0x3fff, 0x3fff);
+ regmap_update_bits(afe->regmap, AUDIO_ENGEN_CON0, AUD_APLL2_EN_MASK,
+ 0);
+ regmap_update_bits(afe->regmap, AUDIO_ENGEN_CON0, AUD_26M_EN_MASK,
+ 0);
+
+ /* make sure all irq status are cleared, twice intended */
+ regmap_update_bits(afe->regmap, AFE_IRQ_MCU_CLR, 0xffff, 0xffff);
+
+skip_regmap:
+ return mt79xx_afe_disable_clock(afe);
+}
+
+static int mt79xx_afe_runtime_resume(struct device *dev)
+{
+ struct mtk_base_afe *afe = dev_get_drvdata(dev);
+ struct mt79xx_afe_private *afe_priv = afe->platform_priv;
+ int ret;
+
+ ret = mt79xx_afe_enable_clock(afe);
+ if (ret)
+ return ret;
+
+ if (!afe->regmap || afe_priv->pm_runtime_bypass_reg_ctl)
+ goto skip_regmap;
+
+ /* enable clk*/
+ regmap_update_bits(afe->regmap, AUDIO_TOP_CON4, 0x3fff, 0);
+ regmap_update_bits(afe->regmap, AUDIO_ENGEN_CON0, AUD_APLL2_EN_MASK,
+ AUD_APLL2_EN);
+ regmap_update_bits(afe->regmap, AUDIO_ENGEN_CON0, AUD_26M_EN_MASK,
+ AUD_26M_EN);
+
+skip_regmap:
+ return 0;
+}
+
+static int mt79xx_afe_component_probe(struct snd_soc_component *component)
+{
+ return mtk_afe_add_sub_dai_control(component);
+}
+
+static const struct snd_soc_component_driver mt79xx_afe_component = {
+ .name = AFE_PCM_NAME,
+ .probe = mt79xx_afe_component_probe,
+ .pointer = mtk_afe_pcm_pointer,
+ .pcm_construct = mtk_afe_pcm_new,
+};
+
+static int mt79xx_dai_memif_register(struct mtk_base_afe *afe)
+{
+ struct mtk_base_afe_dai *dai;
+
+ dai = devm_kzalloc(afe->dev, sizeof(*dai), GFP_KERNEL);
+ if (!dai)
+ return -ENOMEM;
+
+ list_add(&dai->list, &afe->sub_dais);
+
+ dai->dai_drivers = mt79xx_memif_dai_driver;
+ dai->num_dai_drivers = ARRAY_SIZE(mt79xx_memif_dai_driver);
+
+ dai->dapm_widgets = mt79xx_memif_widgets;
+ dai->num_dapm_widgets = ARRAY_SIZE(mt79xx_memif_widgets);
+ dai->dapm_routes = mt79xx_memif_routes;
+ dai->num_dapm_routes = ARRAY_SIZE(mt79xx_memif_routes);
+
+ return 0;
+}
+
+typedef int (*dai_register_cb)(struct mtk_base_afe *);
+static const dai_register_cb dai_register_cbs[] = {
+ mt79xx_dai_etdm_register,
+ mt79xx_dai_memif_register,
+};
+
+static int mt79xx_afe_pcm_dev_probe(struct platform_device *pdev)
+{
+ struct mtk_base_afe *afe;
+ struct mt79xx_afe_private *afe_priv;
+ struct device *dev;
+ int i, irq_id, ret;
+
+ afe = devm_kzalloc(&pdev->dev, sizeof(*afe), GFP_KERNEL);
+ if (!afe)
+ return -ENOMEM;
+ platform_set_drvdata(pdev, afe);
+
+ afe->platform_priv = devm_kzalloc(&pdev->dev, sizeof(*afe_priv),
+ GFP_KERNEL);
+ if (!afe->platform_priv)
+ return -ENOMEM;
+
+ afe_priv = afe->platform_priv;
+ afe->dev = &pdev->dev;
+ dev = afe->dev;
+
+ afe->base_addr = devm_platform_ioremap_resource(pdev, 0);
+ if (IS_ERR(afe->base_addr))
+ return PTR_ERR(afe->base_addr);
+
+ /* initial audio related clock */
+ ret = mt79xx_init_clock(afe);
+ if (ret) {
+ dev_err(dev, "init clock error\n");
+ return ret;
+ }
+
+ pm_runtime_enable(dev);
+
+ /* enable clock for regcache get default value from hw */
+ afe_priv->pm_runtime_bypass_reg_ctl = true;
+ pm_runtime_get_sync(&pdev->dev);
+
+ afe->regmap = devm_regmap_init_mmio(&pdev->dev, afe->base_addr,
+ &mt79xx_afe_regmap_config);
+ if (IS_ERR(afe->regmap)) {
+ ret = PTR_ERR(afe->regmap);
+ goto err_pm_disable;
+ }
+
+ pm_runtime_put_sync(&pdev->dev);
+ afe_priv->pm_runtime_bypass_reg_ctl = false;
+
+ /* init memif */
+ afe->memif_size = MT79XX_MEMIF_NUM;
+ afe->memif = devm_kcalloc(dev, afe->memif_size, sizeof(*afe->memif),
+ GFP_KERNEL);
+ if (!afe->memif)
+ goto err_pm_disable;
+
+ for (i = 0; i < afe->memif_size; i++) {
+ afe->memif[i].data = &memif_data[i];
+ afe->memif[i].irq_usage = -1;
+ }
+
+ mutex_init(&afe->irq_alloc_lock);
+
+ /* irq initialize */
+ afe->irqs_size = MT79XX_IRQ_NUM;
+ afe->irqs = devm_kcalloc(dev, afe->irqs_size, sizeof(*afe->irqs),
+ GFP_KERNEL);
+ if (!afe->irqs)
+ goto err_pm_disable;
+
+ for (i = 0; i < afe->irqs_size; i++)
+ afe->irqs[i].irq_data = &irq_data[i];
+
+ /* request irq */
+ irq_id = platform_get_irq(pdev, 0);
+ if (!irq_id) {
+ dev_err(dev, "%pOFn no irq found\n", dev->of_node);
+ goto err_pm_disable;
+ }
+ ret = devm_request_irq(dev, irq_id, mt79xx_afe_irq_handler,
+ IRQF_TRIGGER_NONE, "asys-isr", (void *)afe);
+ if (ret) {
+ dev_err(dev, "could not request_irq for asys-isr\n");
+ goto err_pm_disable;
+ }
+
+ /* init sub_dais */
+ INIT_LIST_HEAD(&afe->sub_dais);
+
+ for (i = 0; i < ARRAY_SIZE(dai_register_cbs); i++) {
+ ret = dai_register_cbs[i](afe);
+ if (ret) {
+ dev_warn(afe->dev, "dai register i %d fail, ret %d\n",
+ i, ret);
+ goto err_pm_disable;
+ }
+ }
+
+ /* init dai_driver and component_driver */
+ ret = mtk_afe_combine_sub_dai(afe);
+ if (ret) {
+ dev_warn(afe->dev, "mtk_afe_combine_sub_dai fail, ret %d\n",
+ ret);
+ goto err_pm_disable;
+ }
+
+ afe->mtk_afe_hardware = &mt79xx_afe_hardware;
+ afe->memif_fs = mt79xx_memif_fs;
+ afe->irq_fs = mt79xx_irq_fs;
+
+ afe->runtime_resume = mt79xx_afe_runtime_resume;
+ afe->runtime_suspend = mt79xx_afe_runtime_suspend;
+
+ /* register component */
+ ret = devm_snd_soc_register_component(&pdev->dev,
+ &mt79xx_afe_component,
+ NULL, 0);
+ if (ret) {
+ dev_warn(dev, "err_platform\n");
+ goto err_pm_disable;
+ }
+
+ ret = devm_snd_soc_register_component(afe->dev,
+ &mt79xx_afe_pcm_dai_component,
+ afe->dai_drivers,
+ afe->num_dai_drivers);
+ if (ret) {
+ dev_warn(dev, "err_dai_component\n");
+ goto err_pm_disable;
+ }
+
+ return ret;
+
+err_pm_disable:
+ pm_runtime_put_sync(&pdev->dev);
+ pm_runtime_disable(&pdev->dev);
+ return ret;
+}
+
+static int mt79xx_afe_pcm_dev_remove(struct platform_device *pdev)
+{
+ pm_runtime_disable(&pdev->dev);
+ if (!pm_runtime_status_suspended(&pdev->dev))
+ mt79xx_afe_runtime_suspend(&pdev->dev);
+
+ return 0;
+}
+
+static const struct of_device_id mt79xx_afe_pcm_dt_match[] = {
+ { .compatible = "mediatek,mt79xx-afe", },
+ {},
+};
+MODULE_DEVICE_TABLE(of, mt79xx_afe_pcm_dt_match);
+
+static const struct dev_pm_ops mt79xx_afe_pm_ops = {
+ SET_RUNTIME_PM_OPS(mt79xx_afe_runtime_suspend,
+ mt79xx_afe_runtime_resume, NULL)
+};
+
+static struct platform_driver mt79xx_afe_pcm_driver = {
+ .driver = {
+ .name = "mt79xx-audio",
+ .of_match_table = mt79xx_afe_pcm_dt_match,
+ .pm = &mt79xx_afe_pm_ops,
+ },
+ .probe = mt79xx_afe_pcm_dev_probe,
+ .remove = mt79xx_afe_pcm_dev_remove,
+};
+
+module_platform_driver(mt79xx_afe_pcm_driver);
+
+MODULE_DESCRIPTION("Mediatek SoC AFE platform driver for ALSA MT79xx");
+MODULE_AUTHOR("Vic Wu <vic.wu@mediatek.com>");
+MODULE_LICENSE("GPL");