From patchwork Mon Jun 12 03:35:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ze Gao X-Patchwork-Id: 106209 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2340702vqr; Sun, 11 Jun 2023 20:54:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5dOqlQ4ELRp6GeTTcyu8PNirW9FEo8xuTeZ3HSO54cQq+tn80ZWpR3vf1TdH3uY9hSeJND X-Received: by 2002:a05:6359:639e:b0:12b:c37e:d46b with SMTP id sg30-20020a056359639e00b0012bc37ed46bmr1209918rwb.21.1686542085306; Sun, 11 Jun 2023 20:54:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686542085; cv=none; d=google.com; s=arc-20160816; b=ag+NqZI/A0/wqDr62JnXNwvU+jBZ7nF9QNRLlnB7vr2MIQYQhR8YjEJMCpCOSyHSvu Y0im3yPufpPQxoCtQ0Om/9tc6hTu9VMGZPEXRNjEsIcWw3U2+vWQXFgsfBI2+8facUyu MNit6bJegsBnqxiZujdpzlSz+DGBT1Lrp1eEB7/+sy8nvZniMaTp5qYU3Gf99sS3Ta8q lYXpUkeHbhiXMFNdFxiuxHNmGvbseE2tkQlh8Le0PUSlLeISTWR+wGcOumGD2ef2AGSS 4D5GhNZFEalnTiy7oqItiwNys9wrtIg44yO4XSUsAqJ/9RPaKzIEwPintCEpkGCb8Bm+ uWuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=13wsVNDxAZaF4hfb/peWxhJE5uamDpPrqEy4mn/h2BI=; b=JOQqHo3LRZesYvgIan9tzT2wJBLdiydixxnSmTzwD8OKdfsnOfGv3z5uW+5ROEB+nL fywjvjB3gq55uDXZffl1a/+oz+FRPANU+pQCKKzWhhD7EiIu93s+qOQSULGAG/FF2tmm CdWnAdsGF/DUtHEyzzJrjl7Prhmq6wfehQQzMUagHDo++aVeGTu5BFAsrgatbaIUH55Q e5KPf9e96ZJswDlCKZy26+sEVeH+VcPLNvYOmrwpxxIkF+eWP8fXt3eQwZiMMu/OD/6X +8c8qAqNAIV//IPjDeUICkcEuTbIBLI6h+xf1ZNk7/Mz+X9Weh2K8X7HxWAcU7t7l2B6 Rjow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=KQnr5xGo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g23-20020aa796b7000000b006293f8330fcsi2524466pfk.322.2023.06.11.20.54.32; Sun, 11 Jun 2023 20:54:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=KQnr5xGo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233238AbjFLDfZ (ORCPT + 99 others); Sun, 11 Jun 2023 23:35:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230215AbjFLDfX (ORCPT ); Sun, 11 Jun 2023 23:35:23 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AEA0F5 for ; Sun, 11 Jun 2023 20:35:21 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id af79cd13be357-75d4dd6f012so393391085a.2 for ; Sun, 11 Jun 2023 20:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686540920; x=1689132920; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=13wsVNDxAZaF4hfb/peWxhJE5uamDpPrqEy4mn/h2BI=; b=KQnr5xGoMlKKSGmOAC6jhuNnwZxpoXkXmccClIm8F0EwQfjAc0w4ko8/yH0nCjbzXT cHk+393MMYOicZ3XlgPWk0krMighNb910/vwL+LJjLITAFWPY/PoZQr2Our7uFs015u/ ySxDoItQnpen88LObdmevgGZm+00n6RVsMKLiQc6wZKIf6J9b2O/lCAl1lbpUdVuLQBd 9CmXoOYv6Bw+O2rOHMvkFNm0ANPiteFYnV2c4vpejJMLRjrjhrxTOXUE/oZh2eS9Nv82 //eloe0mz1w7QI+f4K8nRuQmPgMuPp2zt9qXmtCG0wMGEI2seCI1+16cMScbMCKaUMbE 6KXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686540920; x=1689132920; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=13wsVNDxAZaF4hfb/peWxhJE5uamDpPrqEy4mn/h2BI=; b=Y58tYaMnHIh6gzDV6MUQ0pm33Z9HY5KmNfhh1SJDeyj5L9tIJd4Sy6xvExijxB3YD9 WlVQsQZaNltAmGbgukf/8jya9brZQS/13j+COHjBazbNwsdscATuNoOlboMbEwpqLK1Y SwDYiuVBVlTbC7P/qc3nrPZYWjzPwCnXEAPFtL2FTdubZlC69WWYyN/Nux5jopoBGRYs khCJNYBfTgrk5hG2JtV6XPfW5sKkihrHz4Ar2/4iNvrSx9QD6iU0YOQoy8mfxIBNvj3j uxbgqcpMtCK/rSBEYgcibp7PeRwquUrB0izq3YtFYYNUsNAXDo80fjG/PrVCFGtZIJuD Z9UA== X-Gm-Message-State: AC+VfDytm2V+GQfwsL/pxPxBya3Lmm7sPpsre+4D0NwjuRf1Iul1xktZ +rfkLzcwHHlCRn0+vB51ltI= X-Received: by 2002:a05:620a:871a:b0:75c:b919:b4e5 with SMTP id px26-20020a05620a871a00b0075cb919b4e5mr7828850qkn.32.1686540920564; Sun, 11 Jun 2023 20:35:20 -0700 (PDT) Received: from localhost.localdomain ([203.205.141.10]) by smtp.googlemail.com with ESMTPSA id jk14-20020a170903330e00b001b050df0a93sm7019107plb.93.2023.06.11.20.35.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jun 2023 20:35:20 -0700 (PDT) From: Ze Gao X-Google-Original-From: Ze Gao To: Peter Zijlstra Cc: Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Mel Gorman , Steven Rostedt , Valentin Schneider , Vincent Guittot , linux-kernel@vger.kernel.org, Ze Gao Subject: [PATCH] sched_fork: Use READ_ONCE() for lockless read of current->normal_prio Date: Mon, 12 Jun 2023 11:35:05 +0800 Message-Id: <20230612033505.8148-1-zegao@tencent.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768467553855199315?= X-GMAIL-MSGID: =?utf-8?q?1768467553855199315?= The current->normal_prio is locklessly accessed from sched_fork and child's scheduler related initialization procedures heavily rely on the value loaded. Thus we mark this load as READ_ONCE in case of possible load tearing due to concurrent access from other paths, for example if changes of parent's normal_prio happens to be requested via some syscall. Signed-off-by: Ze Gao --- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 944c3ae39861..37a13e4b734d 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4699,7 +4699,7 @@ int sched_fork(unsigned long clone_flags, struct task_struct *p) /* * Make sure we do not leak PI boosting priority to the child. */ - p->prio = current->normal_prio; + p->prio = READ_ONCE(current->normal_prio); uclamp_fork(p);