Message ID | 20230611155100.2553804-2-masahiroy@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2103802vqr; Sun, 11 Jun 2023 08:57:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4J/DDk7ug0RbLmqqYF3CS+Cx2TrnJWpaHcrACnCrup4oQDTeIrMkriTgsEUknuBZz3zich X-Received: by 2002:a05:6a00:1396:b0:663:ee11:b1 with SMTP id t22-20020a056a00139600b00663ee1100b1mr6073844pfg.28.1686499065132; Sun, 11 Jun 2023 08:57:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686499065; cv=none; d=google.com; s=arc-20160816; b=cTj8tpu2I3A8u3CADVxciLs5nOgAwdGl1pNwm5yS0nwVc3yokiWGrR7tNl0/FdNGXl /J5njuvzpNdF7iEEqfQUQaZVqriuRd9gqnM545myUQN4bOtS35yqdwET4aWxChh2Q1I4 oPxHxh+yQH/U/q5Md1ATa38mKpeRqTEkff+0/HF4TOTHoWAVtMLq+hab80OMEz5NLJl+ /iaLUT4Sw+gtNjUhJEyfsvQ8EuuRNSuJjOjDzybeDw5H1S7uya1LoOwHJ8MrXnZm2SWK 20FIUi53JF1ufji+tRFFyBjLCqzC1KOOQU4UWFuaustFAPvNlQfXQYtJYXalTfWWYW5h 9RIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yc/gtwIfuqiPYmsUjm9leEERLBUY899g4C8ehPR05Ag=; b=ZIPhrbNBpgYzgw6oFWTugmEg3ACHViftps7ppZs1c/CNdFTzIG4iUw/MU6QshqIuM3 az/dvdobFlJyLw1EIpny8AqBBUg6BWeZJC9o1eh2ovaDTHSaes6eCncdkOddgJDol+Zp 7IR8AZI/mHiI7p2TLv1DpZmI/4tfKNiQl0kIfQgiiWDJWUhyQRipCucZU5Zi0jyw4byC Ht2WTzshVb1O3VTMpFgCTVKqq3P4zKN4QQDL7K5WqmcFCKIIjzY6YBvs+MRKczN0QANK 2FBXm1Gkv9RrVeqKi3kRg82KlLOYnnIrQR3eiYch9XNKhA+kfDeBRUZvKMZXEBpU22Mt z3Ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ic2i57gZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b13-20020a65578d000000b00543c1b1be55si5543195pgr.132.2023.06.11.08.57.30; Sun, 11 Jun 2023 08:57:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ic2i57gZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232733AbjFKPvN (ORCPT <rfc822;liningstudo@gmail.com> + 99 others); Sun, 11 Jun 2023 11:51:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbjFKPvL (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 11 Jun 2023 11:51:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC8E91AB; Sun, 11 Jun 2023 08:51:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EFCD0614CC; Sun, 11 Jun 2023 15:51:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6B82C4339E; Sun, 11 Jun 2023 15:51:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686498669; bh=ohH8mqMz+mXglbA45Ds1jfSagXOIlvRutfQtwCUj3/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ic2i57gZYwIfogDlu4RmI5E2wOnHoEnzliq3mGLWE6seXUTZ20FF9XYZxw6zKt/pj ri1meBiMMfM/4IIXQmdXsggVpZY9i7PPdlx4RBHNkzCxE++HAbeBNORXVBqkvS69mj JW6i67J7nAuwIMilYmDd7ZApCZ1+iQlHOC1qv8oOMP2PJS952GyiHbxPFzWaDLuqNB QVeMAOokTu9PxQK7n8P9mATF20SykM+Ced+47w7pyUcWMyiGCeGJ3u0QnaWHEour0j LUSDM2INF3MTsPTP4bXnCdXZl77OaAdleOZ4O63KizsI6SY7NJS6fn3eazbggHI+as YMMvep96YmzVw== From: Masahiro Yamada <masahiroy@kernel.org> To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, Nicolas Schier <nicolas@fjasle.eu>, linux-snps-arc@lists.infradead.org, Masahiro Yamada <masahiroy@kernel.org> Subject: [PATCH v9 01/11] ARC: define ASM_NL and __ALIGN(_STR) outside #ifdef __ASSEMBLY__ guard Date: Mon, 12 Jun 2023 00:50:50 +0900 Message-Id: <20230611155100.2553804-2-masahiroy@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230611155100.2553804-1-masahiroy@kernel.org> References: <20230611155100.2553804-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768422443654671666?= X-GMAIL-MSGID: =?utf-8?q?1768422443654671666?= |
Series |
Unify <linux/export.h> and <asm/export.h>, remove EXPORT_DATA_SYMBOL(), faster TRIM_UNUSED_KSYMS
|
|
Commit Message
Masahiro Yamada
June 11, 2023, 3:50 p.m. UTC
ASM_NL is useful not only in *.S files but also in .c files for using
inline assembler in C code.
On ARC, however, ASM_NL is evaluated inconsistently. It is expanded to
a backquote (`) in *.S files, but a semicolon (;) in *.c files because
arch/arc/include/asm/linkage.h defines it inside #ifdef __ASSEMBLY__,
so the definition for C code falls back to the default value defined in
include/linux/linkage.h.
If ASM_NL is used in inline assembler in .c files, it will result in
wrong assembly code because a semicolon is not an instruction separator,
but the start of a comment for ARC.
Move ASM_NL (also __ALIGN and __ALIGN_STR) out of the #ifdef.
Fixes: 9df62f054406 ("arch: use ASM_NL instead of ';' for assembler new line character in the macro")
Fixes: 8d92e992a785 ("ARC: define __ALIGN_STR and __ALIGN symbols for ARC")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
Changes in v9:
- New patch
arch/arc/include/asm/linkage.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arc/include/asm/linkage.h b/arch/arc/include/asm/linkage.h index c9434ff3aa4c..8a3fb71e9cfa 100644 --- a/arch/arc/include/asm/linkage.h +++ b/arch/arc/include/asm/linkage.h @@ -8,6 +8,10 @@ #include <asm/dwarf.h> +#define ASM_NL ` /* use '`' to mark new line in macro */ +#define __ALIGN .align 4 +#define __ALIGN_STR __stringify(__ALIGN) + #ifdef __ASSEMBLY__ .macro ST2 e, o, off @@ -28,10 +32,6 @@ #endif .endm -#define ASM_NL ` /* use '`' to mark new line in macro */ -#define __ALIGN .align 4 -#define __ALIGN_STR __stringify(__ALIGN) - /* annotation for data we want in DCCM - if enabled in .config */ .macro ARCFP_DATA nm #ifdef CONFIG_ARC_HAS_DCCM