From patchwork Sat Jun 10 09:13:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 105913 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1442106vqr; Sat, 10 Jun 2023 02:35:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ48LR6aCPXkXgbpVnfbOpTHw1K1lQlBXAuEL1uP+deOuqR+JYswSc5wLerB5IQZjnF54izQ X-Received: by 2002:a17:906:ee86:b0:974:e767:e1e7 with SMTP id wt6-20020a170906ee8600b00974e767e1e7mr4890919ejb.28.1686389749295; Sat, 10 Jun 2023 02:35:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686389749; cv=none; d=google.com; s=arc-20160816; b=CEMNtdChTgx2sO2AIxbr/lNUJ/8UuvD2+v5zTGWPKNEGa5LDPcFgj1ZnJf7Tsijkdt S4Y6YyQbElO/C1dAAVgf3hb6izRO5OhfJtKfcSzL6i0Xcc7Mag4BFgw1IkESy/9T9BuQ UNUJvApAZpevzMQ+Un8v89MphC9LWR725UDAv+3/auvWAMV0fZNe3R03dOPvZFNUhLoz aYxOqIYhvUz3PFEkAZntLYTfgPRL1FAubej4xfAu5LvDHVqxnI1CCjz4AL9ClKBzq8hI HKBS3z4tozgYok0guo/iPL267/ELJ0A6OWnDmatgJ4JV21yeiTm0v1L00h8izm3FAyAE nW4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=W3+AgKd+TJZXlYDtsLg3ZizQVMWIZ3FRWoIR0aUmQ6Q=; b=d1Bw/ZKSpe/cKypgO/lJjrnGcEnk/JYXoUXNM4cG5FmAI9A7pDuSZKEfvL3mhFda/G +tLM+MgBdGtN/W7wXchLQ4CLCHxvDyJDveUZaqoxBElQI3Gz+xcnp9uS8d0rsDK6MFl6 ETDgJElc4t3GsGK+UIyfRfMAGLzh+Wo/z+SfxYAhOpgME9OjIdWBC3rR2LmQkoKzIazK oM4YPe5WGOqS3TkUv69zgJM+r29MH0pvOBsSYdkr6AxUmUf/kBJfLAeECPtPasPTIw6d at870I4TdvTYgz1zFcbc7K0s0Z6K4FgjAH7qOe3krZmw9VywvWeMZFu95nhLObuzxGry 2D0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hv8O9+nc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n12-20020aa7d04c000000b005149e642610si3463540edo.296.2023.06.10.02.35.25; Sat, 10 Jun 2023 02:35:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hv8O9+nc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234190AbjFJJOq (ORCPT + 99 others); Sat, 10 Jun 2023 05:14:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234273AbjFJJOS (ORCPT ); Sat, 10 Jun 2023 05:14:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 195483C12; Sat, 10 Jun 2023 02:14:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6210760B9A; Sat, 10 Jun 2023 09:14:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96415C433D2; Sat, 10 Jun 2023 09:13:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686388441; bh=bSgiFXb7ZTjwLTsJwq+dnf6gUoYaRAfD7X61i4sz3V8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hv8O9+nc+vktReYdxDm4KB3gyGRtONLjgrcTDTVxRRW85xNwf1HWmKH//k61Z+pDj iP7E6VsZBFfxZuKuqix+YFGkkKA2BE4bjUP4I4H3KsFHNHb4wcm44cZh+/0WGpP288 EYpwyZm0D6mPYdWfmOOKjNzzNvJkMCuEC5D4DcbQQGs9aHsgFze0++EH+Zkh8Bi4tJ ulS1aYe4CZYHL5pyHU8wJB441JQveiDXFB3Ocp+8q/p26D9vRFO7IOS9aYziL3ZDG4 C7Td6mMkaa0PUF3RncOQZ0HxczaQCffx36G3c1US88x4bFgOitvhmVepVCbeu8v+w2 SxvM7fWV3qJvg== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Nicolas Schier , linux-um@lists.infradead.org, Masahiro Yamada Subject: [PATCH v8 10/11] modpost: show offset from symbol for section mismatch warnings Date: Sat, 10 Jun 2023 18:13:19 +0900 Message-Id: <20230610091320.1054554-11-masahiroy@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230610091320.1054554-1-masahiroy@kernel.org> References: <20230610091320.1054554-1-masahiroy@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768307817743080683?= X-GMAIL-MSGID: =?utf-8?q?1768307817743080683?= Currently, modpost only shows the symbol names and section names, so it repeats the same message if there are multiple relocations in the same symbol. It is common the relocation spans across multiple instructions. It is better to show the offset from the symbol. Signed-off-by: Masahiro Yamada Reviewed-by: Nick Desaulniers --- scripts/mod/modpost.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 85df3f3ba9ee..40967ed816df 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1147,8 +1147,8 @@ static void default_mismatch_handler(const char *modname, struct elf_info *elf, sec_mismatch_count++; - warn("%s: section mismatch in reference: %s (section: %s) -> %s (section: %s)\n", - modname, fromsym, fromsec, tosym, tosec); + warn("%s: section mismatch in reference: %s+0x%x (section: %s) -> %s (section: %s)\n", + modname, fromsym, (unsigned int)(faddr - from->st_value), fromsec, tosym, tosec); if (mismatch->mismatch == EXTABLE_TO_NON_TEXT) { if (match(tosec, mismatch->bad_tosec))