Message ID | 20230610090414.90529-1-avromanov@sberdevices.ru |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1440330vqr; Sat, 10 Jun 2023 02:30:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ59i+kHMNeLYnHHLN5shw8hy3BwpKnNcZxv8J2DJiAkCHRckrqpsHJq8fHaP6Mzpk+Rr1rs X-Received: by 2002:a17:907:2d08:b0:965:6075:d100 with SMTP id gs8-20020a1709072d0800b009656075d100mr5019311ejc.39.1686389423557; Sat, 10 Jun 2023 02:30:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686389423; cv=none; d=google.com; s=arc-20160816; b=T2fUjCGVMxqXb7QguUjs08FOzsdnUvEo0LWPREhJPZkxraMocbJiySQpOUXI53qW9+ 7kBp5qC7EDpB0+Z3PYfdc2Q2jBEJqovsWqbdHCrHi0+baL2nBAvS9IpyK8Ypl73xKEOJ CDIlvfMQaxAKRGbJu2lipgT2mdC9z02g1vBGQ5j65yU4VwW3Y+RM9xkCasDOxgi5ucYu phJAlc1NPHRKl5BThjkK8Xcr/i/dHWYx/xFBv+fxCc/OVlTmMG5r352VCXGfya3EOvEV mlL9JDtPIsq6pymmk3fjBBVtNO2HuBi0ttBDLDzLeII7q/N1tkLXKeWQyZ6kWLK915Rp xMEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=xdrE0qSZT9DJMknXlOlA3GHw6tt6TuBcUDeBnwfeW5U=; b=qFPXB4NhCd6ToSO64AWklyazTP9wkWWrOgJ9oJNpq5y65p6pjj9mVtocEjQW/7cVEJ RgL/uPQ8L3frzgGLw2Xnx7lbIG+equjF57W+UHbKPfgNtcha7/cpCBEzdPD7YlGPQyC/ jDrYz5I64GcSKRcMopqoedog8wskeEywCqhgd7iV6TksUK+GX5j5bEQqlOW5wQnMC1sd 0RZl0pMxsHwMpYbuFd+2K1JOqIJCI6yWC8T1fDDtMNenhUl6hIQCZ4WmJ3DNKHzEBUBo mxMfZExWC+RM6UfhPOhYMvcxeZVOR3z0/AnjO//U89rRK8YsGACunt7J8SEUiDhbhjM/ Xwkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=nZWZ6Om6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n12-20020aa7d04c000000b005149e642610si3463540edo.296.2023.06.10.02.29.55; Sat, 10 Jun 2023 02:30:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=nZWZ6Om6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230505AbjFJJEe (ORCPT <rfc822;rust.linux@gmail.com> + 99 others); Sat, 10 Jun 2023 05:04:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229652AbjFJJEb (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 10 Jun 2023 05:04:31 -0400 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2547935B6 for <linux-kernel@vger.kernel.org>; Sat, 10 Jun 2023 02:04:29 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 47F215FD0C; Sat, 10 Jun 2023 12:04:26 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1686387866; bh=xdrE0qSZT9DJMknXlOlA3GHw6tt6TuBcUDeBnwfeW5U=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=nZWZ6Om6Mf5PtBD39msvoiY+AyLIyz+WL1YthOLd6zmvxqMEhWPB8tL+3L8eNyW83 /hIc0vzOpwSFz0H8Rtn18pt6VjCyurahmdLMviJy9iCBT44hD86TYrRhFkH1zw32fA uHTh2qvcy03MooEciaT7r7tv5tIcHfisPxVgheqlXxzr53Gao/oB+ydpfMLAnzsy3B 1WQYoggEt++Fe2Rs6ttbAk3Zw+wY2/dvAWNDfik/2Mul8vTlIFsAL/CtarNRfT4zDT IXGa85AhoXlVKqx7yH3WJJJqV481O04Y9W2DHqmru/fPyE2CiDXb389cKdul028cdo Wjf4g9ZHymlIA== Received: from S-MS-EXCH02.sberdevices.ru (S-MS-EXCH02.sberdevices.ru [172.16.1.5]) by mx.sberdevices.ru (Postfix) with ESMTP; Sat, 10 Jun 2023 12:04:25 +0300 (MSK) From: Alexey Romanov <avromanov@sberdevices.ru> To: <narmstrong@baylibre.com>, <neil.armstrong@linaro.org>, <khilman@baylibre.com>, <jbrunet@baylibre.com>, <martin.blumenstingl@googlemail.com> CC: <linux-arm-kernel@lists.infradead.org>, <kernel@sberdevices.ru>, <linux-amlogic@lists.infradead.org>, <linux-kernel@vger.kernel.org>, "Alexey Romanov" <avromanov@sberdevices.ru> Subject: [PATCH v1] drivers: meson: secure-pwrc: always enable DMA domain Date: Sat, 10 Jun 2023 12:04:14 +0300 Message-ID: <20230610090414.90529-1-avromanov@sberdevices.ru> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH02.sberdevices.ru (172.16.1.5) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/06/10 03:45:00 #21472184 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768307475964579942?= X-GMAIL-MSGID: =?utf-8?q?1768307475964579942?= |
Series |
[v1] drivers: meson: secure-pwrc: always enable DMA domain
|
|
Commit Message
Alexey Romanov
June 10, 2023, 9:04 a.m. UTC
Starting from commit e45f243409db ("firmware: meson_sm:
populate platform devices from sm device tree data") pwrc
is probed successfully and disables unused pwr domains.
By A1 SoC family design, any TEE requires DMA pwr domain
always enabled.
Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
---
I'm not entirely sure if this domain should always be enabled on or it
should be separately enabled in dts file. Comments are welcome.
---
drivers/soc/amlogic/meson-secure-pwrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 10/06/2023 11:04, Alexey Romanov wrote: > Starting from commit e45f243409db ("firmware: meson_sm: > populate platform devices from sm device tree data") pwrc > is probed successfully and disables unused pwr domains. > By A1 SoC family design, any TEE requires DMA pwr domain > always enabled. > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> > --- > I'm not entirely sure if this domain should always be enabled on or it > should be separately enabled in dts file. Comments are welcome. > --- > drivers/soc/amlogic/meson-secure-pwrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c > index e93518763526..25b4b71df9b8 100644 > --- a/drivers/soc/amlogic/meson-secure-pwrc.c > +++ b/drivers/soc/amlogic/meson-secure-pwrc.c > @@ -105,7 +105,7 @@ static struct meson_secure_pwrc_domain_desc a1_pwrc_domains[] = { > SEC_PD(ACODEC, 0), > SEC_PD(AUDIO, 0), > SEC_PD(OTP, 0), > - SEC_PD(DMA, 0), > + SEC_PD(DMA, GENPD_FLAG_ALWAYS_ON | GENPD_FLAG_IRQ_SAFE), > SEC_PD(SD_EMMC, 0), > SEC_PD(RAMA, 0), > /* SRAMB is used as ATF runtime memory, and should be always on */ It's fine to keep it enabled. Acked-by: Neil Armstrong <neil.armstrong@linaro.org> Neil
Hi, On Sat, 10 Jun 2023 12:04:14 +0300, Alexey Romanov wrote: > Starting from commit e45f243409db ("firmware: meson_sm: > populate platform devices from sm device tree data") pwrc > is probed successfully and disables unused pwr domains. > By A1 SoC family design, any TEE requires DMA pwr domain > always enabled. > > > [...] Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.5/drivers) [1/1] drivers: meson: secure-pwrc: always enable DMA domain https://git.kernel.org/amlogic/c/0bb4644d583789c97e74d3e3047189f0c59c4742 These changes has been applied on the intermediate git tree [1]. The v6.5/drivers branch will then be sent via a formal Pull Request to the Linux SoC maintainers for inclusion in their intermediate git branches in order to be sent to Linus during the next merge window, or sooner if it's a set of fixes. In the cases of fixes, those will be merged in the current release candidate kernel and as soon they appear on the Linux master branch they will be backported to the previous Stable and Long-Stable kernels [2]. The intermediate git branches are merged daily in the linux-next tree [3], people are encouraged testing these pre-release kernels and report issues on the relevant mailing-lists. If problems are discovered on those changes, please submit a signed-off-by revert patch followed by a corrective changeset. [1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git [3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c index e93518763526..25b4b71df9b8 100644 --- a/drivers/soc/amlogic/meson-secure-pwrc.c +++ b/drivers/soc/amlogic/meson-secure-pwrc.c @@ -105,7 +105,7 @@ static struct meson_secure_pwrc_domain_desc a1_pwrc_domains[] = { SEC_PD(ACODEC, 0), SEC_PD(AUDIO, 0), SEC_PD(OTP, 0), - SEC_PD(DMA, 0), + SEC_PD(DMA, GENPD_FLAG_ALWAYS_ON | GENPD_FLAG_IRQ_SAFE), SEC_PD(SD_EMMC, 0), SEC_PD(RAMA, 0), /* SRAMB is used as ATF runtime memory, and should be always on */