From patchwork Fri Jun 9 14:39:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 105678 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1003474vqr; Fri, 9 Jun 2023 07:52:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4/0caq2Y26MdR0E3TIt4sPB+irBoRe6Fj84RfNwi9TtBXu/Ks7TN+UXKK/lntR4lv8ecgb X-Received: by 2002:a05:6a20:3d12:b0:103:b0f9:7110 with SMTP id y18-20020a056a203d1200b00103b0f97110mr1359956pzi.11.1686322378297; Fri, 09 Jun 2023 07:52:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686322378; cv=none; d=google.com; s=arc-20160816; b=hNoYyG6aDnl5Pz8t0jtGWnOwTk7lLFXVqDSUk+N8fhfAucOcBx5ZMEymVURQDLZjLX Y2FFGI0IVA9rpS+qLFH6bPEfrAh9PBWxxv4ffKe3VG8emRyBVILX9XVfEKd6Gta8rQJ4 viU0AivyQAzb6mLw77cCSB9dQr775MP4OVQCxO8TaDAvtZlBO7OYyUNJjXo8ViUd16ok 33hxkHrUYoPXO2lmWMKCtgjsjJveh5tn+T6pkf6PC9hsd79+SIJtC7jw/bFp07iUOWGF 9WJpwBJmxpVhke2C0r/HGF2I5ADhObwMdVg+DwHBudW2N+2eEFBVlxc7lGNst4kpImIh DRSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EFPA+iF1oDnlDYWPONEIrlc2JlsGAiwXm8sKilpLnOk=; b=fNAJjLON1f6FSBSG7uDVCRUpnZ5YzKoomGPM9jsDjOdUEFSO647cQbrl9P6Fi7TOZ1 p15VtoWknjFEgTz1i5sVuk5sd3DxTV7qEpEfN/tvUVSGqPtTkb2NBULu7YWX4+ggJO4J lBd9kZzgMbhc6s7j0L3vIndkm/isVKXKO3T/HYDcSeRnYPW4Hq4fqrCTUIIKEX9ac5s7 qOv3lZSNhkgHkEobd+O7PHPZ3kP1qwOVRwY/yBnPK9ySi8YC/uKjVTwXnkWS4CfDjYln 4Gxvid28Db5v9ijC9zXrExK3KXpJDCcJXZqs8rNy72ij89QUnaaiYiA8qRBcgq+MoH/R D3BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=pZ1jNqjS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j184-20020a638bc1000000b0053ff2caa766si2689307pge.550.2023.06.09.07.52.43; Fri, 09 Jun 2023 07:52:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=pZ1jNqjS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241537AbjFIOjW (ORCPT + 99 others); Fri, 9 Jun 2023 10:39:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231819AbjFIOjS (ORCPT ); Fri, 9 Jun 2023 10:39:18 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EACA136; Fri, 9 Jun 2023 07:39:17 -0700 (PDT) X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1686321556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EFPA+iF1oDnlDYWPONEIrlc2JlsGAiwXm8sKilpLnOk=; b=pZ1jNqjSB01eYJK+iVJNl1WJucinc7z4V/+U4lwOOQ7cEr1056xU3pB8wk1R2R4FcYPGr9 baOzltFc4Al22YTf8cmCrOzjkCILsbE4hxLM3+bzv4qWznAs4sH8IzkKxFKjEwdJcmhUbt TerWuex0XSyP+IP5PxjwAhK60e9FWkXz4WR8RiHQzCWnZ/GM/vhq1wtcHegOB5gB7IPa+8 ZDpanMlbzoe3U59GSJfCNxzi9+gcp3a4lljxbn1QwMUl4+kL3dzu0AfsOH95uSBl3jJYUY HYl9d7+L5mvNd5vwhMe7N/9Dc9gcGpBANr9/9RfWu9bXOm5VhXtg+2P+rCaBYg== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 3D9B56000A; Fri, 9 Jun 2023 14:39:15 +0000 (UTC) From: Miquel Raynal To: Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: , , linux-pm@vger.kernel.org, Thomas Petazzoni , Miquel Raynal Subject: [PATCH 1/2] power: reset: at91-reset: use driver structure as status parameter Date: Fri, 9 Jun 2023 16:39:11 +0200 Message-Id: <20230609143912.849995-2-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230609143912.849995-1-miquel.raynal@bootlin.com> References: <20230609143912.849995-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768237174313710614?= X-GMAIL-MSGID: =?utf-8?q?1768237174313710614?= It is quite uncommon to use a driver helper with parameters like *pdev and __iomem *base. It is much cleaner and close to today's standards to provide the per-device driver structure and then access its internals. Let's do this with at91_resete_status() before making more modifications to this helper. Signed-off-by: Miquel Raynal --- drivers/power/reset/at91-reset.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c index 741e44a017c3..a8a6f3997768 100644 --- a/drivers/power/reset/at91-reset.c +++ b/drivers/power/reset/at91-reset.c @@ -149,11 +149,10 @@ static int at91_reset(struct notifier_block *this, unsigned long mode, return NOTIFY_DONE; } -static void __init at91_reset_status(struct platform_device *pdev, - void __iomem *base) +static void __init at91_reset_status(struct at91_reset *reset) { + u32 reg = readl(reset->rstc_base + AT91_RSTC_SR); const char *reason; - u32 reg = readl(base + AT91_RSTC_SR); switch ((reg & AT91_RSTC_RSTTYP) >> 8) { case RESET_TYPE_GENERAL: