Message ID | 20230609081732.3842341-7-lee@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp791586vqr; Fri, 9 Jun 2023 01:21:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4jn78ekT6Ov3EpbsjhyidP2OG0PqBvtt93OV1wytCQMzXN0qTKCwjo7P27u80IUAtSsRt/ X-Received: by 2002:a05:6a00:2794:b0:658:e9f4:f7b6 with SMTP id bd20-20020a056a00279400b00658e9f4f7b6mr4303392pfb.15.1686298906098; Fri, 09 Jun 2023 01:21:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686298906; cv=none; d=google.com; s=arc-20160816; b=jxcvo22H4U/+/BzwJx3vO6QTpRCPdASSEFZX67tF1kgQLZTV8cyW0WC0uXY86wPpEa 7GFndVRuYzsFN3jvnYWy03TqxWj5M40CHC7qqEp7Ocygw0PJN1wVBDZLEoy7CXixgXdW LiySDOun7nKxPkVAyyT9knS582uTTqBCqBAzwecvYoavOxSknFmK/+EQnUDPwsjmXM2f 6VhLFlcyuKy93S1Zo/N1b2qT3cnCojIxM/NPBWtS1jFeoalDRrMLBceDsNtiZkg2pFl8 +/cwuhf6QjgRk0IwVg7ikbmep4Ag9Wv6vzCkvFb2ARSX71ZQtrO8odsZUYIHYVNcHShO rPzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=uPUVWut9femRvmBhnzpwruimcFx8q53h130cEwwAAfg=; b=cx0YMTTVS7dKQUJ/ZAruTtkdkRzNSl7lMf3V++lT2PiU8FjAKLUVq2JdBTP21PNAbm EPz5NlnroC2O62WJ67kqSy4AiADHBLGqxqLDhqFlgpkNb6rGvL+4agRaPL8Fi9W2XYql cHRt1WFl8My7YRmABBxBYIXqJLpfpfpeg39GAQkv2BgF1HOnNYMPKAhe4MUqllQEUI6g QI3aLGuq96uMTz6pfA37Vn0QpKH4lpt/XpucYAtL5tfKC+Cbvjjnw8UeiPm2aQgi8AXJ MExA3DNhDqTGkX7IpmCjqxiG4neyAmcF+WnNjtkm9hr37xlZAjIMxXE0xdyigfnr1SoT wJTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="lrM08NU/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q2-20020a632a02000000b0054405fa9251si2300611pgq.896.2023.06.09.01.21.33; Fri, 09 Jun 2023 01:21:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="lrM08NU/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240387AbjFIIUQ (ORCPT <rfc822;liningstudo@gmail.com> + 99 others); Fri, 9 Jun 2023 04:20:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240400AbjFIITm (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 9 Jun 2023 04:19:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E3B64228 for <linux-kernel@vger.kernel.org>; Fri, 9 Jun 2023 01:18:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0FAC765476 for <linux-kernel@vger.kernel.org>; Fri, 9 Jun 2023 08:18:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D2E1C433EF; Fri, 9 Jun 2023 08:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686298679; bh=4OOUF/ysv6+g/EYobM5DFqzUmhksGsgNibALRCne10Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lrM08NU/TNcTOa4aa43rG6Ow5ypxWfYIfpqP3DKV10rSJC8k009h8xtD2bXajOV9s WvuDzj7pV4j28I0gl6bjmyuIHsXj9MomOpnWDHx9K3/mcBn2nFeJ1mi1ZE4SdBvnyI y0ggX15wASY/8gCJVPz11NlgZ+1/5svac5vlFUh7BNq0yyDjcLWP1KeqbWN5YaJ6At gehgITgO1vPHEAzIdT5bF1sGH7yxga+ng++spGWxtaKd+C1G8VRgiOmOgI78WC/tNQ oY4tHa1oyZbHcL4Pom7ebnUims/vZ3mNlMRIMhX09hb8g6kydCCLT2fVjTPRcPb9J1 Fe+Ewb/UapYng== From: Lee Jones <lee@kernel.org> To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Ben Skeggs <bskeggs@redhat.com>, Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Gourav Samaiya <gsamaiya@nvidia.com>, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org Subject: [RESEND 06/15] drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc' Date: Fri, 9 Jun 2023 09:17:09 +0100 Message-ID: <20230609081732.3842341-7-lee@kernel.org> X-Mailer: git-send-email 2.41.0.162.gfafddb0af9-goog In-Reply-To: <20230609081732.3842341-1-lee@kernel.org> References: <20230609081732.3842341-1-lee@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768212561538631802?= X-GMAIL-MSGID: =?utf-8?q?1768212561538631802?= |
Series |
Rid W=1 warnings from GPU
|
|
Commit Message
Lee Jones
June 9, 2023, 8:17 a.m. UTC
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c: In function ‘nvkm_acr_lsfw_load_sig_image_desc_v2’:
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable ‘loc’ set but not used [-Wunused-but-set-variable]
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Gourav Samaiya <gsamaiya@nvidia.com>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Signed-off-by: Lee Jones <lee@kernel.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
On Fri, Jun 9, 2023 at 10:18 AM Lee Jones <lee@kernel.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c: In function ‘nvkm_acr_lsfw_load_sig_image_desc_v2’: > drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable ‘loc’ set but not used [-Wunused-but-set-variable] > > Cc: Ben Skeggs <bskeggs@redhat.com> > Cc: Karol Herbst <kherbst@redhat.com> > Cc: Lyude Paul <lyude@redhat.com> > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Gourav Samaiya <gsamaiya@nvidia.com> > Cc: dri-devel@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Signed-off-by: Lee Jones <lee@kernel.org> > --- > drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c > index f36a359d4531c..bd104a030243a 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c > @@ -218,7 +218,7 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev, > const struct firmware *hsbl; > const struct nvfw_ls_hsbl_bin_hdr *hdr; > const struct nvfw_ls_hsbl_hdr *hshdr; > - u32 loc, sig, cnt, *meta; > + u32 sig, cnt, *meta; > > ret = nvkm_firmware_load_name(subdev, path, "hs_bl_sig", ver, &hsbl); > if (ret) > @@ -227,7 +227,6 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev, > hdr = nvfw_ls_hsbl_bin_hdr(subdev, hsbl->data); > hshdr = nvfw_ls_hsbl_hdr(subdev, hsbl->data + hdr->header_offset); > meta = (u32 *)(hsbl->data + hshdr->meta_data_offset); > - loc = *(u32 *)(hsbl->data + hshdr->patch_loc); Ben: should we do anything with this value or is it safe to ignore? > sig = *(u32 *)(hsbl->data + hshdr->patch_sig); > cnt = *(u32 *)(hsbl->data + hshdr->num_sig); > > -- > 2.41.0.162.gfafddb0af9-goog >
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c index f36a359d4531c..bd104a030243a 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c @@ -218,7 +218,7 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev, const struct firmware *hsbl; const struct nvfw_ls_hsbl_bin_hdr *hdr; const struct nvfw_ls_hsbl_hdr *hshdr; - u32 loc, sig, cnt, *meta; + u32 sig, cnt, *meta; ret = nvkm_firmware_load_name(subdev, path, "hs_bl_sig", ver, &hsbl); if (ret) @@ -227,7 +227,6 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev, hdr = nvfw_ls_hsbl_bin_hdr(subdev, hsbl->data); hshdr = nvfw_ls_hsbl_hdr(subdev, hsbl->data + hdr->header_offset); meta = (u32 *)(hsbl->data + hshdr->meta_data_offset); - loc = *(u32 *)(hsbl->data + hshdr->patch_loc); sig = *(u32 *)(hsbl->data + hshdr->patch_sig); cnt = *(u32 *)(hsbl->data + hshdr->num_sig);