[RESEND,05/15] drm/mediatek/mtk_disp_ccorr: Remove half completed incorrect struct header
Message ID | 20230609081732.3842341-6-lee@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp795129vqr; Fri, 9 Jun 2023 01:30:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4dOyVqlF2EafRWmMOWm+pmWLcCxW86a4J7Jq7+ZIVSI5Q+ZgqxKDP9/pD/wvtL6SfGtLdr X-Received: by 2002:a05:6808:3a1:b0:398:2da0:21d2 with SMTP id n1-20020a05680803a100b003982da021d2mr761666oie.59.1686299455197; Fri, 09 Jun 2023 01:30:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686299455; cv=none; d=google.com; s=arc-20160816; b=r4o7QqYw0k9hslmGq6568A9kLFsrkWJEelFS72zMQg4W7fyaq2ajuPVQHGoNS7ZBnD VrKdqa40UQ9YQ8DclDYj3PpzhYHAFfNOJvk5lVQQgUY5c8M1AuOq9lD3xQkGQhSZRXlj 1mzQYqlt/BufrMz7qpGmqSrNRZgBDvn29CXovCKc4SAeO/nflv/PYHguL7y0n7bGFJrd /Pw5AzuaCE1DZIUhIQBzjgVv5wpp0Xql62kV8vdyfM7dcAfkL2K7hnCIa18Al+ZChhc5 RdqElCZEEYfY5CkBjgTGWNoCGtAhwK7CS9mFeoNVB5fVo958Zu2peg1u9hlekPqprr3a MIRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=y+U5jMsKsBkB7dVFNWm6U+XPj29iQB244bzGbPYhsf8=; b=gKNJyM0wt94Zw33KdX81kD9JZhvq7BoNnf0VQWd0OGxA7BqEs3vAtUKwYDWLrjz7rD jByZFTrbWH2OA5B3Wv+02ZJQSUIyc7agDhc0nsxBkB0RvXYyclIr+nwYqazsNLcXbJ/5 ZJkEY/O64a6/b0vkVhbsWs6rgdbS7oyflRUYYA6l9yVT1E2pDzHofK7FNedHOxHMWcAh wJo0Lj9Zmjsoz0ZA+x9j5mN6U0lAM5AYdDivOqMOhgfB1gK6FZsY/WxaR0Koz2i6PZbc ow5LxACsLfvPeiiiVGmfVYPO0Iunl9sbf4Oketw1phXsyUy1Gdt2rfOHmuLbkil+GdRr pJhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WnT5Nm3N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h6-20020a056a00000600b006430bec8238si2058598pfk.328.2023.06.09.01.30.42; Fri, 09 Jun 2023 01:30:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WnT5Nm3N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240680AbjFIIU5 (ORCPT <rfc822;liningstudo@gmail.com> + 99 others); Fri, 9 Jun 2023 04:20:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240508AbjFIIU3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 9 Jun 2023 04:20:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D230270F for <linux-kernel@vger.kernel.org>; Fri, 9 Jun 2023 01:19:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7E4396548A for <linux-kernel@vger.kernel.org>; Fri, 9 Jun 2023 08:17:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0246C433A0; Fri, 9 Jun 2023 08:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686298676; bh=Xwk4+4906LxoPOQvJy2nJCGhGicOPCINkG/q+wgp1HY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WnT5Nm3Nqb+fZ43YcskNRpDLUAzNH2KDlKr2VBEHKhU7LXxnC3PxLCk+K6XJR+xbP VZ1ZS8RAtYpjzxfzr72CAu0XPYOuAzn8vtNfSXRx5mVvwEMbs+vZt63dkLEHSeN7Mv fp2iWaRj8E+ZWRlSk7vbl8USPnMqM6OjbPWnfOyB3HpSUZgAv+Dd7vd8pkW8tomE80 ETNi/QV16RjK0CNGkZfZwE/6w0JT5Hy4OA0/Gy3zs9QciQEUI0j9M4F4iDdveeTv9R J1W96IAClipiIyNlNqqd0EoQ6VrFru0nxaySAaOBasWIkz4Aiqic327P24uWIQHyYF leRA2sqAvCRxg== From: Lee Jones <lee@kernel.org> To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Chun-Kuang Hu <chunkuang.hu@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [RESEND 05/15] drm/mediatek/mtk_disp_ccorr: Remove half completed incorrect struct header Date: Fri, 9 Jun 2023 09:17:08 +0100 Message-ID: <20230609081732.3842341-6-lee@kernel.org> X-Mailer: git-send-email 2.41.0.162.gfafddb0af9-goog In-Reply-To: <20230609081732.3842341-1-lee@kernel.org> References: <20230609081732.3842341-1-lee@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768213137740372365?= X-GMAIL-MSGID: =?utf-8?q?1768213137740372365?= |
Series |
Rid W=1 warnings from GPU
|
|
Commit Message
Lee Jones
June 9, 2023, 8:17 a.m. UTC
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'clk' not described in 'mtk_disp_ccorr'
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'regs' not described in 'mtk_disp_ccorr'
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_ccorr'
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'data' not described in 'mtk_disp_ccorr'
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <lee@kernel.org>
---
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 5 -----
1 file changed, 5 deletions(-)
Comments
Il 09/06/23 10:17, Lee Jones ha scritto: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'clk' not described in 'mtk_disp_ccorr' > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'regs' not described in 'mtk_disp_ccorr' > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_ccorr' > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'data' not described in 'mtk_disp_ccorr' > > Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Lee Jones <lee@kernel.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On 09/06/2023 10:17, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'clk' not described in 'mtk_disp_ccorr' > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'regs' not described in 'mtk_disp_ccorr' > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_ccorr' > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'data' not described in 'mtk_disp_ccorr' > > Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Lee Jones <lee@kernel.org> > --- > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c > index 1773379b24398..720f3c7ef7b4f 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c > @@ -34,11 +34,6 @@ struct mtk_disp_ccorr_data { > u32 matrix_bits; > }; > > -/** > - * struct mtk_disp_ccorr - DISP_CCORR driver structure > - * @ddp_comp - structure containing type enum and hardware resources > - * @crtc - associated crtc to report irq events to > - */ That surely suppress the warning but I think the correct to do here is to fix the documentation instead of deleting it. Regards, Matthias > struct mtk_disp_ccorr { > struct clk *clk; > void __iomem *regs;
On Fri, 09 Jun 2023, Matthias Brugger wrote: > > > On 09/06/2023 10:17, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'clk' not described in 'mtk_disp_ccorr' > > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'regs' not described in 'mtk_disp_ccorr' > > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_ccorr' > > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'data' not described in 'mtk_disp_ccorr' > > > > Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > Cc: David Airlie <airlied@gmail.com> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > Cc: Matthias Brugger <matthias.bgg@gmail.com> > > Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-mediatek@lists.infradead.org > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Lee Jones <lee@kernel.org> > > --- > > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c > > index 1773379b24398..720f3c7ef7b4f 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c > > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c > > @@ -34,11 +34,6 @@ struct mtk_disp_ccorr_data { > > u32 matrix_bits; > > }; > > -/** > > - * struct mtk_disp_ccorr - DISP_CCORR driver structure > > - * @ddp_comp - structure containing type enum and hardware resources > > - * @crtc - associated crtc to report irq events to > > - */ > > That surely suppress the warning but I think the correct to do here is to > fix the documentation instead of deleting it. If someone wants to take responsibility for it and author correct documentation, I'm all for it. That is the perfect resolution. If that's not going to happen immediately, I suggest we remove it in the first instance.
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c index 1773379b24398..720f3c7ef7b4f 100644 --- a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c @@ -34,11 +34,6 @@ struct mtk_disp_ccorr_data { u32 matrix_bits; }; -/** - * struct mtk_disp_ccorr - DISP_CCORR driver structure - * @ddp_comp - structure containing type enum and hardware resources - * @crtc - associated crtc to report irq events to - */ struct mtk_disp_ccorr { struct clk *clk; void __iomem *regs;