| Message ID | 20230608080316.84203-1-yang.lee@linux.alibaba.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp133934vqr;
Thu, 8 Jun 2023 01:48:13 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ6/zVvS1p6u538OwJ0GD+Ys9uQJJ9P10iFVbRj6S6ZTTYiwtg2QuIvLo+a9V+NxyrgzO6Yc
X-Received: by 2002:a05:6a20:258a:b0:114:748f:f2dc with SMTP id
k10-20020a056a20258a00b00114748ff2dcmr7473393pzd.59.1686214093385;
Thu, 08 Jun 2023 01:48:13 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1686214093; cv=none;
d=google.com; s=arc-20160816;
b=G3+QF191QWo3zviWj9YTFgC68Y/GLch1YXYCBxKa/uWT+XVXJVvV0MLIPJ1ECTH8QZ
kLOrMy4eINgFoBYFmwMBgiIYnbLqOiiJ8kG07qu0pMWE+Dl8QjWOLJ1Bq9+544GQYbze
BogVpmdwplcvs53uEp8vWZVJWhu4jllZxYoTEs3b4np9z06D5FK9EvOdW0XXnyuqwRsi
M6O5LlV3mHgtUFGr+hLwt61xAy4nWiyRn/JeZPR56ucJHMiOt4IZ8CyDPzyl2zWBKn9R
rxXUUnAuF6B1GdGdYzR/lze1MrNTADsf/3ur6EH2UobI6ykVLL6C+ZUSJ5/sg3m3HaaG
EesQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=RuWHw/ZRZzAzboc+f+57KdjDAU/LKC3fkUyj1UH3sCQ=;
b=Loa59lTvV1yKQQPBpdy/c5RoTET/hw6ikGY1ls3HMpduWh1u8MLY03iAH5wEPjIf3f
i2GPK86oHdRrD3z2AbVMiQjPPjoT3aYPJi5xtqUQ/aAStdQzwonpAVQYXQw7+Hndpzwx
wSnnBfLrZiVSadhgg2Etu6IXAQ+vX6k2sSM2at+bvo+LlUJkkd95s6XFYDaihuGlBiv0
878dGzHRkx2NdAd/UToDCd+6gCTDnStQIUTbUi6BF1+9C84+aChPuiz0VjqwI+nxwi+r
sVA0qAOLY3aZNxBIlLCMn4heZCH7RPO6GDJV2fQe1ig4Awfge7aTC91v6TJnch/oEpuD
hAnw==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
k10-20020a170902c40a00b001a691f376e8si797360plk.415.2023.06.08.01.47.59;
Thu, 08 Jun 2023 01:48:13 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S233226AbjFHIDj (ORCPT <rfc822;liningstudo@gmail.com>
+ 99 others); Thu, 8 Jun 2023 04:03:39 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50398 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S234398AbjFHIDY (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 8 Jun 2023 04:03:24 -0400
Received: from out30-132.freemail.mail.aliyun.com
(out30-132.freemail.mail.aliyun.com [115.124.30.132])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 222C7271B;
Thu, 8 Jun 2023 01:03:21 -0700 (PDT)
X-Alimail-AntiSpam:
AC=PASS;BC=-1|-1;BR=01201311R391e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0VkdVVRT_1686211397;
Received: from localhost(mailfrom:yang.lee@linux.alibaba.com
fp:SMTPD_---0VkdVVRT_1686211397)
by smtp.aliyun-inc.com;
Thu, 08 Jun 2023 16:03:18 +0800
From: Yang Li <yang.lee@linux.alibaba.com>
To: davem@davemloft.net
Cc: edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, linux-hyperv@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Yang Li <yang.lee@linux.alibaba.com>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: [PATCH -next] net: hv_netvsc: Remove duplicated include in
rndis_filter.c
Date: Thu, 8 Jun 2023 16:03:16 +0800
Message-Id: <20230608080316.84203-1-yang.lee@linux.alibaba.com>
X-Mailer: git-send-email 2.20.1.7.g153144c
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,
ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,
T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1768123629140624962?=
X-GMAIL-MSGID: =?utf-8?q?1768123629140624962?=
|
| Series |
[-next] net: hv_netvsc: Remove duplicated include in rndis_filter.c
|
|
Commit Message
Yang Li
June 8, 2023, 8:03 a.m. UTC
./drivers/net/hyperv/rndis_filter.c: linux/slab.h is included more than once.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5462
Fixes: 4cab498f33f7 ("hv_netvsc: Allocate rx indirection table size dynamically")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/net/hyperv/rndis_filter.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Thu, Jun 08, 2023 at 04:03:16PM +0800, Yang Li wrote: > ./drivers/net/hyperv/rndis_filter.c: linux/slab.h is included more than once. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5462 > Fixes: 4cab498f33f7 ("hv_netvsc: Allocate rx indirection table size dynamically") > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Hi Yang Li, A few nits from my side; 1. The subject should include the target tree, in this case net-next. [PATCH net-next] ... 2. I don't think this needs a fixes tag: nothing was broken I'm not sure this warrants a v2. If you do decide to post a v2, please allow for 24h since v1 was posted. Link: https://kernel.org/doc/html/v6.3/process/maintainer-netdev.html Lastly, I think at least one other similar change has been posted recently. Please consider batching up such changes, say in groups of 10 patches, and posting them as a patch-set. The change itself seems fine to me. Reviewed-by: Simon Horman <simon.horman@corigine.com> > --- > drivers/net/hyperv/rndis_filter.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c > index af95947a87c5..ecc2128ca9b7 100644 > --- a/drivers/net/hyperv/rndis_filter.c > +++ b/drivers/net/hyperv/rndis_filter.c > @@ -21,7 +21,6 @@ > #include <linux/rtnetlink.h> > #include <linux/ucs2_string.h> > #include <linux/string.h> > -#include <linux/slab.h> > > #include "hyperv_net.h" > #include "netvsc_trace.h" > -- > 2.20.1.7.g153144c > >
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c index af95947a87c5..ecc2128ca9b7 100644 --- a/drivers/net/hyperv/rndis_filter.c +++ b/drivers/net/hyperv/rndis_filter.c @@ -21,7 +21,6 @@ #include <linux/rtnetlink.h> #include <linux/ucs2_string.h> #include <linux/string.h> -#include <linux/slab.h> #include "hyperv_net.h" #include "netvsc_trace.h"