From patchwork Thu Jun 8 07:19:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jerome Neanne X-Patchwork-Id: 104856 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp99986vqr; Thu, 8 Jun 2023 00:24:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4aQ9uPuNIwtDgpgiiUxkamneTpcHv64teNshwO5v7TilF/RunmYmq58ygp8W1EvM0HQFUy X-Received: by 2002:a17:902:cec5:b0:1aa:ef83:34be with SMTP id d5-20020a170902cec500b001aaef8334bemr5060126plg.47.1686209052950; Thu, 08 Jun 2023 00:24:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686209052; cv=none; d=google.com; s=arc-20160816; b=YVLd3YhWEzXfJxNPvlIGg7oFpma32dh1wD2w58fpTrUXxM0vYsBnjeVrQifgtP/bLP LIVjDQ6a8FA0F2pB2iTm2vipprvXCiD5YBdovpXLOiB6b4WgZx7QN6GA1h9rTPXxFIVQ kg2LRuv7YURpD6jzFIEgsudLTHdihu0bl3wYzjs90DDj7gqjwY8aDikvnLPnFAmfTgNm jZXlrthBOaJDYxDqxvB2Q3sn5WJRdUvO9BHh5SdgRpHoq8k0K3P9ultxaGS2NOJcofCa KNiFPW50QowNRPi8g+P1wzyCsjVGe4tIIvj/OMQo8bTSisY/ZFcQYqAyfhswEffFSH6G kh3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=J4070cfF5PAleKzRCTMiKt0VwtD6qDiaa/t3zF9r6Pw=; b=s85CI14A7GUoZfj61vYWR/sZPHJPovlnISXwHLm2xUkSy2Toxt6ZiBbiBo2r0gymrf 3121mrgCcwKZTM5tc81oKY48Oixeks25uvpLEgxVddB07JTZbUP2fLVeXbQRdomnKM2w 8w7nZPYnINBj1kNBq3OJgMuNiLKQs8L3GyNdJiuALrRmtxez1KZjKOP/fIJoNC1BqCdr yH7t6cCbTO0fnIwEfHkj0DeX5NY5TBmSf5SwUj1yNsx6dc+tfaEqFoZ2Uq7mgsty5KQ6 /a2wUqweY72MyvmdywUD5A5jLEF6G2I6zSSGlOshdR3z5ucv5chONZIz2dyx68SjRfRP OqpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20221208.gappssmtp.com header.s=20221208 header.b="3l0tt/gE"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b7-20020a170902d50700b001adc3a1b3fasi660974plg.282.2023.06.08.00.24.00; Thu, 08 Jun 2023 00:24:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20221208.gappssmtp.com header.s=20221208 header.b="3l0tt/gE"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234825AbjFHHUI (ORCPT + 99 others); Thu, 8 Jun 2023 03:20:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235171AbjFHHTz (ORCPT ); Thu, 8 Jun 2023 03:19:55 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31A141AE for ; Thu, 8 Jun 2023 00:19:53 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f6e68cc738so1202185e9.1 for ; Thu, 08 Jun 2023 00:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1686208791; x=1688800791; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=J4070cfF5PAleKzRCTMiKt0VwtD6qDiaa/t3zF9r6Pw=; b=3l0tt/gEy2ZmUawIigas/dQcBroxP8nUFOqTF93ZItYcV7eA/Ccm9NTmmTqOJghjsZ 3+AMlPL/R5sQ4Fe+IycH+oPAYpvwDyJaZj2OAUXXVk0ws3Vcy/YXKUJmhB+wbDYKDXQW FvKTHcziAd6NySKGq/XtDD9BqXZY5MfZGudz7JLHySJLadwmUoY7k1V1c6LcO2pvzDG8 HkP+5yH9PaYhyWJlOFfxUsF20LPgMvJBJGTc1KID8wG9lOL5pTfu8MZGG3nMmDv86c5f ilA81ugcfQyDyoV7lunznyDzDhi8bYIgQTPK5fb/EJ9O1l2LnhLQCgxuQk0bn1QHX2s+ FGAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686208791; x=1688800791; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J4070cfF5PAleKzRCTMiKt0VwtD6qDiaa/t3zF9r6Pw=; b=SgwHkqGuTFkxGpMwXqIbO2/MkxK+83+MZeaZ4c875NClyJ+9qOi4R861h4P8keBIvu Jb+rC+WCxoqtkOldldLM3gbT2/W5Uf/8COA/FNvmbRWdsWq1wUSR5GqSBYHop19kwtYb ud9KAVz9RFPiTdHZTWzPh8/4ld6doxek4+CCZgnt8QUL+vshxx1IgoduuGV1F32KsmSO WDIWLmvQ9aM985hSJUNR7wsdFWDO9VK60JKr6Mvv19jTQxmn9DPxAk0IdMCawUbDCs+U 2RWt1S4Vy1OsV3T9g8OEjnHziyUELvWn98oNfPg1wlGQqYOtDDM6kX1lSYt+2xRiIyPS RLaA== X-Gm-Message-State: AC+VfDz1d8Mk4PcBXPt3Y4iguYwSBY2x5GIvqYRTXptN20lSZI24CYhc 8PPzcNcW6xP3Mn0iRzJcEXeVkw== X-Received: by 2002:a05:600c:20c:b0:3f6:be1:b8d6 with SMTP id 12-20020a05600c020c00b003f60be1b8d6mr579770wmi.9.1686208791643; Thu, 08 Jun 2023 00:19:51 -0700 (PDT) Received: from jerome-BL.. (192.201.68.85.rev.sfr.net. [85.68.201.192]) by smtp.gmail.com with ESMTPSA id c22-20020a7bc856000000b003f42ceb3bf4sm1012572wml.32.2023.06.08.00.19.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 00:19:51 -0700 (PDT) From: Jerome Neanne To: tony@atomide.com, lee@kernel.org Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, khilman@baylibre.com, nm@ti.com, afd@ti.com, msp@baylibre.com, Jerome Neanne Subject: [RESEND PATCH v3] mfd: tps65219: Add support for soft shutdown via sys-off API Date: Thu, 8 Jun 2023 09:19:47 +0200 Message-Id: <20230608071947.3467751-1-jneanne@baylibre.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768118343962598767?= X-GMAIL-MSGID: =?utf-8?q?1768118343962598767?= Use new API for power-off mode support: Link: https://lwn.net/Articles/894511/ Link: https://lore.kernel.org/all/7hfseqa7l0.fsf@baylibre.com/ sys-off API allows support of shutdown handler and restart handler. Shutdown was not supported before that enhancement. This is required for platform that are not using PSCI. Test: - restart: # reboot Default is cold reset: # cat /sys/kernel/reboot/mode Switch boot mode to warm reset: # echo warm > /sys/kernel/reboot/mode - power-off: # halt Tested on AM62-LP-SK board. Signed-off-by: Jerome Neanne Suggested-by: Andrew Davis Reviewed-by: Andrew Davis --- Notes: Change-log v3 to v2 v2: Link: https://lore.kernel.org/lkml/20230511122100.2225417-1-jneanne@baylibre.com/ Lee Jones Review: nits: rm not needed line wraps and restore a cr deleted not related with the patch. Change-log v2 to v1 v1: Link: https://lore.kernel.org/all/20230203140150.13071-1-jneanne@baylibre.com/ Andrew Davis Review: - Use new helpers devm_register_restart_handler and devm_register_power_off_handler Vignesh Raghavendra: - Fix typo on board name in commit message drivers/mfd/tps65219.c | 38 ++++++++++++++++++++++++++++---------- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/drivers/mfd/tps65219.c b/drivers/mfd/tps65219.c index 0e402fda206b..3d9164491e20 100644 --- a/drivers/mfd/tps65219.c +++ b/drivers/mfd/tps65219.c @@ -25,13 +25,21 @@ static int tps65219_cold_reset(struct tps65219 *tps) TPS65219_MFP_COLD_RESET_I2C_CTRL_MASK); } -static int tps65219_restart(struct notifier_block *this, - unsigned long reboot_mode, void *cmd) +static int tps65219_soft_shutdown(struct tps65219 *tps) { - struct tps65219 *tps; + return regmap_update_bits(tps->regmap, TPS65219_REG_MFP_CTRL, + TPS65219_MFP_I2C_OFF_REQ_MASK, + TPS65219_MFP_I2C_OFF_REQ_MASK); +} - tps = container_of(this, struct tps65219, nb); +static int tps65219_power_off_handler(struct sys_off_data *data) +{ + tps65219_soft_shutdown(data->cb_data); + return NOTIFY_DONE; +} +static int tps65219_restart(struct tps65219 *tps, unsigned long reboot_mode) +{ if (reboot_mode == REBOOT_WARM) tps65219_warm_reset(tps); else @@ -40,10 +48,11 @@ static int tps65219_restart(struct notifier_block *this, return NOTIFY_DONE; } -static struct notifier_block pmic_rst_restart_nb = { - .notifier_call = tps65219_restart, - .priority = 200, -}; +static int tps65219_restart_handler(struct sys_off_data *data) +{ + tps65219_restart(data->cb_data, data->mode); + return NOTIFY_DONE; +} static const struct resource tps65219_pwrbutton_resources[] = { DEFINE_RES_IRQ_NAMED(TPS65219_INT_PB_FALLING_EDGE_DETECT, "falling"), @@ -269,13 +278,22 @@ static int tps65219_probe(struct i2c_client *client) } } - tps->nb = pmic_rst_restart_nb; - ret = register_restart_handler(&tps->nb); + ret = devm_register_restart_handler(tps->dev, + tps65219_restart_handler, + tps); + if (ret) { dev_err(tps->dev, "cannot register restart handler, %d\n", ret); return ret; } + ret = devm_register_power_off_handler(tps->dev, + tps65219_power_off_handler, + tps); + if (ret) { + dev_err(tps->dev, "failed to register power-off handler: %d\n", ret); + return ret; + } return 0; }