From patchwork Thu Jun 8 04:36:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 104820 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp43547vqr; Wed, 7 Jun 2023 21:53:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6SStnXlIIy6PxTVmv3MYaFEJjufOa80sbCNVyJt7NisxJCQReFKJ2eYHkz6CRykXWu9kut X-Received: by 2002:a05:6870:768f:b0:188:1195:5ec5 with SMTP id dx15-20020a056870768f00b0018811955ec5mr6479813oab.39.1686199995977; Wed, 07 Jun 2023 21:53:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686199995; cv=none; d=google.com; s=arc-20160816; b=mwSbME+CJlGk9F0njivQt30q+9jcwRu6IjnYBOgHxjlSyuQtzJa8zf5AkosJaniijk /xzfooq2UwVqLEvWMabDQOfWwikWq4MobgedcI/7J9lTSR6irl8GmOOEMlCj4sJ6bk6A NjI9SPrUS778F8hSf8YGWBiRpnxgUq9+z7IlPCNoGrqWA6BFLlskbi5RnxXbVYfjjApR PT8Jm1PQObtV4EEyqddoMzkgK/AjZkxnBOBH3aw19Z4xC3iKXLjXIhaj49uYJ6OblL5U jVHJqEhmtwSWdVpGc3dxcIqdLk1qr2agb0i/vC8utEek+ZPf5l95WQT5mVDbE2YPNHFy YHMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LpIzyCBJY6jE9pEgPEdaViRUSV3QsiKuyw4HBlkJGNg=; b=WmTUenSC2IPsSRuz1jbIyA5WQ3VOuhKVqSMNmfQ/lmbWIWD3Pffb+gccH2+WAQQEYE ulfJRFldGGjzuRDV3MkSD1q+cOkjmQHeYnqrdHxb2piNVNKQdQiNEhgR0AJFhLuCcVo/ g3Ot/w8mswJSF/U+uTo0x9cwPRTMUctirCYRCtWvUKnhAphW4cQJrZYO5+X+KCmut60n KBmBe1gq/VkI24tBGjNfWciTxTfOFo1hJkKIpTFGOCXjZKrHnhuCPK7qtxplm1IpG5lT a+76AVxyF8J4LBIp66T9MFkym1Uno7mLs52Py5eDig8zHJU/knHPkVXLAnariuGGvhmO 5mow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=K+vdAbFe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f10-20020a63de0a000000b00528ca427963si378797pgg.709.2023.06.07.21.53.00; Wed, 07 Jun 2023 21:53:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=K+vdAbFe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234126AbjFHEmB (ORCPT + 99 others); Thu, 8 Jun 2023 00:42:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234090AbjFHEl7 (ORCPT ); Thu, 8 Jun 2023 00:41:59 -0400 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2E8C1988 for ; Wed, 7 Jun 2023 21:41:54 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 468AC5FD71; Thu, 8 Jun 2023 07:41:52 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1686199312; bh=LpIzyCBJY6jE9pEgPEdaViRUSV3QsiKuyw4HBlkJGNg=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=K+vdAbFe62te0cvVfiaxQ/F8O3UQzpWgy3aFtkskuue+TN5L6Wpe1gmkhD/aDUJOR 2CPi/5IXb0zfcB8UdnRjqQqyE8cJvOmW6NTKfCAOlZDv09BUox3frgMOFaklC3drOZ 7a/gxiXcTaK7IdD8R3XlTDsPY5iNZe03FfPVVTnFluXZXZE+xKZOVcWiuEptqiMyh1 jCNX5gcvaZWz6UZNJnF0OdhxRl76EqbEs8sI++4R8Svaqkmy668toXwB56AsIvDLeZ +HWSoTXNQ14a65XAp73+v25KUgTE5ABlBYSxXPyhh8U2RTvlqM89SOlHLKfXGPGGR8 VV72eBcdllxGw== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Thu, 8 Jun 2023 07:41:50 +0300 (MSK) From: Arseniy Krasnov To: Liang Yang , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl CC: , , Arseniy Krasnov , , , , Subject: [PATCH v2] mtd: rawnand: meson: replace integer consts with proper defines Date: Thu, 8 Jun 2023 07:36:44 +0300 Message-ID: <20230608043644.1271186-1-AVKrasnov@sberdevices.ru> X-Mailer: git-send-email 2.35.0 MIME-Version: 1.0 X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH02.sberdevices.ru (172.16.1.5) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/06/08 00:23:00 #21457426 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768108847284578512?= X-GMAIL-MSGID: =?utf-8?q?1768108847284578512?= Add defines for column address. It makes driver more readable, because bitwise OR with 0 looks useless. Suggested-by: Liang Yang Signed-off-by: Arseniy Krasnov --- Changelog: v1 -> v2: * Use defines with zero values instead of dropping both operations in v1. drivers/mtd/nand/raw/meson_nand.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c index 0154131e1d54..9034b3ca9e5b 100644 --- a/drivers/mtd/nand/raw/meson_nand.c +++ b/drivers/mtd/nand/raw/meson_nand.c @@ -109,6 +109,9 @@ #define PER_INFO_BYTE 8 +#define NFC_COLUMN_ADDR_0 0 +#define NFC_COLUMN_ADDR_1 0 + struct meson_nfc_nand_chip { struct list_head node; struct nand_chip nand; @@ -672,12 +675,12 @@ static int meson_nfc_rw_cmd_prepare_and_execute(struct nand_chip *nand, cmd0 = in ? NAND_CMD_READ0 : NAND_CMD_SEQIN; nfc->cmdfifo.rw.cmd0 = cs | NFC_CMD_CLE | cmd0; - addrs[0] = cs | NFC_CMD_ALE | 0; + addrs[0] = cs | NFC_CMD_ALE | NFC_COLUMN_ADDR_0; if (mtd->writesize <= 512) { cmd_num--; row_start = 1; } else { - addrs[1] = cs | NFC_CMD_ALE | 0; + addrs[1] = cs | NFC_CMD_ALE | NFC_COLUMN_ADDR_1; row_start = 2; }