diff mbox series

[v1,4/6] arm64: dts: meson: a1: introduce SPI Flash Controller

Message ID 20230607201641.20982-5-ddrokosov@sberdevices.ru
State New
Headers
Series arm64: dts: meson: a1: introduce several peripheral IPs |

Commit Message

Dmitry Rokosov June 7, 2023, 8:16 p.m. UTC 
  From: Martin Kurbanov <mmkurbanov@sberdevices.ru>

This controller can be used for spinand flash connection.

Signed-off-by: Martin Kurbanov <mmkurbanov@sberdevices.ru>
Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
---
 arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Martin Blumenstingl June 25, 2023, 9:03 p.m. UTC | #1 
On Wed, Jun 7, 2023 at 10:16 PM Dmitry Rokosov <ddrokosov@sberdevices.ru> wrote:
>
> From: Martin Kurbanov <mmkurbanov@sberdevices.ru>
>
> This controller can be used for spinand flash connection.
>
> Signed-off-by: Martin Kurbanov <mmkurbanov@sberdevices.ru>
> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> ---
>  arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> index 63faccfc1134..0efd922ca7e1 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> @@ -199,6 +199,16 @@ gic: interrupt-controller@ff901000 {
>                         #address-cells = <0>;
>                 };
>
> +               spifc: spi@fd000400 {
please also sort this numerically, so it should appear before &apb
Dmitry Rokosov June 28, 2023, 2:23 p.m. UTC | #2 
On Sun, Jun 25, 2023 at 11:03:21PM +0200, Martin Blumenstingl wrote:
> On Wed, Jun 7, 2023 at 10:16 PM Dmitry Rokosov <ddrokosov@sberdevices.ru> wrote:
> >
> > From: Martin Kurbanov <mmkurbanov@sberdevices.ru>
> >
> > This controller can be used for spinand flash connection.
> >
> > Signed-off-by: Martin Kurbanov <mmkurbanov@sberdevices.ru>
> > Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> > ---
> >  arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > index 63faccfc1134..0efd922ca7e1 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > @@ -199,6 +199,16 @@ gic: interrupt-controller@ff901000 {
> >                         #address-cells = <0>;
> >                 };
> >
> > +               spifc: spi@fd000400 {
> please also sort this numerically, so it should appear before &apb

Sure, not a problem. If things have base addresses, all of them ought to
be sorted numerically.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
index 63faccfc1134..0efd922ca7e1 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
@@ -199,6 +199,16 @@  gic: interrupt-controller@ff901000 {
 			#address-cells = <0>;
 		};
 
+		spifc: spi@fd000400 {
+			compatible = "amlogic,a1-spifc";
+			reg = <0x0 0xfd000400 0x0 0x290>;
+			clocks = <&clkc_periphs CLKID_SPIFC>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			power-domains = <&pwrc PWRC_SPIFC_ID>;
+			status = "disabled";
+		};
+
 		usb: usb@fe004400 {
 			status = "disabled";
 			compatible = "amlogic,meson-a1-usb-ctrl";