Message ID | 20230607162954.2651657-1-jaegeuk@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp352931vqr; Wed, 7 Jun 2023 10:11:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ60FfJPT9o1/Kauvho+33oj2gTuwACbwJ8dYc6NNCSYrxtJBEW6IBaSU52QzeBc+qcHaukY X-Received: by 2002:a05:6a20:549d:b0:10c:3cf3:ef7e with SMTP id i29-20020a056a20549d00b0010c3cf3ef7emr4437618pzk.42.1686157892480; Wed, 07 Jun 2023 10:11:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686157892; cv=none; d=google.com; s=arc-20160816; b=Wl+jWfrsjL9GQcWLrQjzPCdBIWGBwR1Sf9Rz16k9wLq3l9daktYrwSnMUJmZopXrhD vja0KjidOUfRR6Tdvgc1E5ad5zVBxZq+JDa9rvKEExg+JM3ioeiHtNbYBT+r2e9ibjEw x+x8EV0REVfdvq7XuJuURDzYtP0LSbtF+kXyiyQmR/L+oExuwd3ZXzoMtQzNdZkk5Fn/ zn5YrYL4zfP97r25WDUKcatOw9rll0g01JeM++IsxseBb7pUpb0rP9xRf1kVD80Yeeyh fd5xSYRHkqy8aYhhq0YsuAm2MxMv81pb2GQ3MsBY0IIheicZmmNUZ74vlhUrhDIWxhd+ oOdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=XtYWopUfUV3pjUxzKYdcP2P01GlJicaI6mldYrZ0TNM=; b=T52GOvwtZbdAq2rdF+TAGrHj5/UbOhzQIryZdzb9seDajTvXBlzoz158wxFVGYEOIq vBi3syUs1K5OjM6rPPnLIqcGH223dkObP6+UPnCOgSW7yZ0TEz6JaGJwylOaVEN56WKV dm1fEE9dz6trx0vR5urolTTqX9FDj/4iPCdrHv+Z/dOB2CHU5dlC0aus1N42nwNzFbRP Y7+bD2m30kYA8uV1uNl+glSOgEi95e66SKSpnXYnU4QFUf0mCLTRd/a+WfYKecKWfztG iDRjq9mBzgqVa5If5TV6JlK3ol0E90yJoERelvdDGBxXwhhQeHA7cU3CEOievN3IPfgD ZANA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F44bcrz7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z11-20020a6552cb000000b00543a6ce8c34si5799147pgp.463.2023.06.07.10.11.17; Wed, 07 Jun 2023 10:11:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F44bcrz7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231801AbjFGQaf (ORCPT <rfc822;literming00@gmail.com> + 99 others); Wed, 7 Jun 2023 12:30:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232170AbjFGQa2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 7 Jun 2023 12:30:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2CFB2114 for <linux-kernel@vger.kernel.org>; Wed, 7 Jun 2023 09:29:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 63B0E6416A for <linux-kernel@vger.kernel.org>; Wed, 7 Jun 2023 16:29:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B61A6C433A0; Wed, 7 Jun 2023 16:29:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686155395; bh=rAXf1ZqsGnObsvjcYvsmTKbEZgNJCNBl1IG2c3vyIFw=; h=From:To:Cc:Subject:Date:From; b=F44bcrz7p0Q3Fonp/7x2+bCCOA5CjLELo3I7hay4Bfwg0htX0PWV89tvwlUS/XopD AcV0rC+4DVFa6SiUrmmiiKgWYWeRfq4gsy1ZO/x9c0EyZSVuUhtecpLX/obu7Vz7OH YGY8xIyCvpxmsLkPdYpWkwjPL8ZC9yyrweCKcM+0LW6pqM8K223ZCJ7DnCr8NRUWwZ cUePkopnKDmMAeT1Ik3Z3mMXsLmszn8h/Q7KMBIAsI7XPXg7NT1WsEe+lEtHZddTMi WLf9CYwK2lQFwPTaOcbQdEX9pN0xKD/RaocJxysScC6CvxrTElxcffwJUw3O6CTuTc aAWXw9ZWODmZw== From: Jaegeuk Kim <jaegeuk@kernel.org> To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim <jaegeuk@kernel.org> Subject: [PATCH] f2fs: set zstd default compression level to 3 Date: Wed, 7 Jun 2023 09:29:54 -0700 Message-ID: <20230607162954.2651657-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768064698314385535?= X-GMAIL-MSGID: =?utf-8?q?1768064698314385535?= |
Series |
f2fs: set zstd default compression level to 3
|
|
Commit Message
Jaegeuk Kim
June 7, 2023, 4:29 p.m. UTC
ZSTD does not support compress_level=0.
The commit d7ffafc99c42 ("f2fs: add sanity compress level check for compressed file")
revealed the issue.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 2023/6/8 0:29, Jaegeuk Kim wrote: > ZSTD does not support compress_level=0. IIUC, it looks the range is [0, ZSTD_MAX_CLEVEL], 0 equals to default (ZSTD_CLEVEL_DEFAULT). zstd_compress.c /* row */ if (compressionLevel == 0) row = ZSTD_CLEVEL_DEFAULT; /* 0 == default */ else if (compressionLevel < 0) row = 0; /* entry 0 is baseline for fast mode */ else if (compressionLevel > ZSTD_MAX_CLEVEL) row = ZSTD_MAX_CLEVEL; else row = compressionLevel; Thanks, > > The commit d7ffafc99c42 ("f2fs: add sanity compress level check for compressed file") > revealed the issue. > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > --- > fs/f2fs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index 8fd23caa1ed9..1fb8d4f27a40 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -627,7 +627,7 @@ static int f2fs_set_zstd_level(struct f2fs_sb_info *sbi, const char *str) > int len = 4; > > if (strlen(str) == len) { > - F2FS_OPTION(sbi).compress_level = 0; > + F2FS_OPTION(sbi).compress_level = 3; > return 0; > } >
On 06/12, Chao Yu wrote: > On 2023/6/8 0:29, Jaegeuk Kim wrote: > > ZSTD does not support compress_level=0. > > IIUC, it looks the range is [0, ZSTD_MAX_CLEVEL], 0 equals to default > (ZSTD_CLEVEL_DEFAULT). Ok, that seems a quick workaround of zstd, since it'd be quite hard to know level=0 will be interpreted to whatever default behind the scenes. > > zstd_compress.c > > /* row */ > if (compressionLevel == 0) row = ZSTD_CLEVEL_DEFAULT; /* 0 == default */ > else if (compressionLevel < 0) row = 0; /* entry 0 is baseline for fast mode */ > else if (compressionLevel > ZSTD_MAX_CLEVEL) row = ZSTD_MAX_CLEVEL; > else row = compressionLevel; > > Thanks, > > > > > The commit d7ffafc99c42 ("f2fs: add sanity compress level check for compressed file") > > revealed the issue. > > > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > > --- > > fs/f2fs/super.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > > index 8fd23caa1ed9..1fb8d4f27a40 100644 > > --- a/fs/f2fs/super.c > > +++ b/fs/f2fs/super.c > > @@ -627,7 +627,7 @@ static int f2fs_set_zstd_level(struct f2fs_sb_info *sbi, const char *str) > > int len = 4; > > if (strlen(str) == len) { > > - F2FS_OPTION(sbi).compress_level = 0; > > + F2FS_OPTION(sbi).compress_level = 3; > > return 0; > > }
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 8fd23caa1ed9..1fb8d4f27a40 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -627,7 +627,7 @@ static int f2fs_set_zstd_level(struct f2fs_sb_info *sbi, const char *str) int len = 4; if (strlen(str) == len) { - F2FS_OPTION(sbi).compress_level = 0; + F2FS_OPTION(sbi).compress_level = 3; return 0; }